diff mbox series

[net] selftests: net: remove unneeded IP_GRE config

Message ID 20240624055539.2092322-1-yujie.liu@intel.com (mailing list archive)
State Accepted
Commit c4532232fa2a4f8d9b9a88135a666545157f3d13
Headers show
Series [net] selftests: net: remove unneeded IP_GRE config | expand

Commit Message

Yujie Liu June 24, 2024, 5:55 a.m. UTC
It seems that there is no definition for config IP_GRE, and it is not a
dependency of other configs, so remove it.

linux$ find -name Kconfig | xargs grep "IP_GRE"
<-- nothing

There is a IPV6_GRE config defined in net/ipv6/Kconfig. It only depends
on NET_IPGRE_DEMUX but not IP_GRE.

Fixes: 04fe7c5029cb ("selftests: fill in some missing configs for net")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Yujie Liu <yujie.liu@intel.com>
---
 tools/testing/selftests/net/config | 1 -
 1 file changed, 1 deletion(-)

Comments

Jakub Kicinski June 24, 2024, 11:31 p.m. UTC | #1
On Mon, 24 Jun 2024 13:55:39 +0800 Yujie Liu wrote:
> It seems that there is no definition for config IP_GRE, and it is not a
> dependency of other configs, so remove it.
> 
> linux$ find -name Kconfig | xargs grep "IP_GRE"
> <-- nothing
> 
> There is a IPV6_GRE config defined in net/ipv6/Kconfig. It only depends
> on NET_IPGRE_DEMUX but not IP_GRE.
> 
> Fixes: 04fe7c5029cb ("selftests: fill in some missing configs for net")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Yujie Liu <yujie.liu@intel.com>

Patch makes sense, that said it's harmless so I'd suggest net-next.

Acked-by: Jakub Kicinski <kuba@kernel.org>
patchwork-bot+netdevbpf@kernel.org June 25, 2024, 3:50 p.m. UTC | #2
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 24 Jun 2024 13:55:39 +0800 you wrote:
> It seems that there is no definition for config IP_GRE, and it is not a
> dependency of other configs, so remove it.
> 
> linux$ find -name Kconfig | xargs grep "IP_GRE"
> <-- nothing
> 
> There is a IPV6_GRE config defined in net/ipv6/Kconfig. It only depends
> on NET_IPGRE_DEMUX but not IP_GRE.
> 
> [...]

Here is the summary with links:
  - [net] selftests: net: remove unneeded IP_GRE config
    https://git.kernel.org/netdev/net-next/c/c4532232fa2a

You are awesome, thank you!
diff mbox series

Patch

diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config
index d4891f7a2bfa..f46e27cd1e70 100644
--- a/tools/testing/selftests/net/config
+++ b/tools/testing/selftests/net/config
@@ -26,7 +26,6 @@  CONFIG_INET_ESP=y
 CONFIG_INET_ESP_OFFLOAD=y
 CONFIG_NET_FOU=y
 CONFIG_NET_FOU_IP_TUNNELS=y
-CONFIG_IP_GRE=m
 CONFIG_NETFILTER=y
 CONFIG_NETFILTER_ADVANCED=y
 CONFIG_NF_CONNTRACK=m