From patchwork Tue Jun 25 19:53:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mina Almasry X-Patchwork-Id: 13711875 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 671D517E441 for ; Tue, 25 Jun 2024 19:54:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719345264; cv=none; b=C8hZ7TjvQFmnZa4PgxE+NCYnyE8jG0hYGPNr36onudNh2Fa3hRFDmER7TGl62HShe4SGXtDALaesQv2eHtq5f8cnN6HWmKmxheYV2Ke0wnn2MECX9hQbDmCEKsyFaYHwr6jQ85CKXYdfCxntUNwhgMNKzuvJpwu5yqe5eOp7OcU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719345264; c=relaxed/simple; bh=SpMPi77DsJFlhQjGUdfJ2ImAR5GLXHN1rrSnFoFyLdQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=qkVV93SCV2WpjYtI59ccAI2KD49oKqTmUVRxCXVk3YdsTd0VC2KlT2qBoutTjT8g9hqQpt7ntJu6OFI1HrF+5SmDJD7TcyWIslTDq7J8VLTDD6Tj1wU/BbriuQySaXNNZjdMmpJmzJxWpPjE8ErJKAGIlUfFxT2JxgudQ9u24YM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--almasrymina.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=vvu2irNH; arc=none smtp.client-ip=209.85.128.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--almasrymina.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="vvu2irNH" Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-62f43c95de4so135150317b3.3 for ; Tue, 25 Jun 2024 12:54:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719345258; x=1719950058; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=AwQAJUWNyaIevRNs1wg9XO3i1KEUwjv3iWNWn0kUg7E=; b=vvu2irNHIxnF/RIJuJYIkwvVDmQTau2Ndosy3xsqdC0tJsedM+2BHlzNGxSMZDRPaO 53I4CU+ME+t3QC5htWJiIoFFmtBdBGZ1ZoP7SB57UR3rzlDQve2cvMbIYTyrz3wCTAoi FcA2vvClaRIis/Qrfc0yiDGrt4qSwud3Upf/62+XZpabfI+yS97ymWj2YjzpInt3yJSB ub2K6v5uGbyZYPgJlzYzzxD/Cog8AIlpemcgqRSDxPMhDWL8oQWBqy1TazfNU4ac84GT JVfuEDDzFcbdqren9jyZzjzI3SNPDU8xHKLiwgvealp54MnYIrUKLfndHmFT98R5j3BR rwsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719345258; x=1719950058; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AwQAJUWNyaIevRNs1wg9XO3i1KEUwjv3iWNWn0kUg7E=; b=j8Ejk8Hw0nlX1P49BVb5fyW/JXctYMZFuT2NnUdFiO41iazb47f6/FnGmL676sj3Ui yOu2kNUantM6fi2IrydMirXVDd/g6PiGYDgRprT0DpTGq3mbx/WHFcY/mfarLBoczaBx ztL/4lutB9tTOyrLdUXXCxFCpxZ41YS3Ff2PpkM3PiH0ytijxVgrU9LjdRfQRJFVo3jO fYE3TZc3HfKLmp0IQjatBbm93929ASRc8BaJ5QKfJ5/qkBy8fNSz1ERyK4CviVs2LrmS K7842aUx+M+J7ikCm6dZn3MnnxMIymPolGnOaAlbdb+6Nijzwd1ZJA+rp+mi3FsGhqXW 3uGA== X-Forwarded-Encrypted: i=1; AJvYcCXIOFGvX3kw3KPob3GSMyv4jBKGLHmRCqXnzCqTEQM5lzP1E+m7K4P0ymzA1HD46p0ETs9WduF7DfSsKKqvAHztkgeXbDWjNz3yHXs9dICn X-Gm-Message-State: AOJu0Yw4UjVqalI8wi2Y9GKX9zJZV7YTQHrqfoftDNOooWIpr2EfC6zI a+tmHauAFS8SwjKBzV0NoJcD97caTHH7f9qtp5wduKv8gh/wrbakv5sZW5Uut5Vl2TXZZBZFdXp lKzovcEyMnygE+6XsO0rANg== X-Google-Smtp-Source: AGHT+IF9ju6vlvrQLPjJRx0nnm38sWXRmCTxMf3Ww8hbK9EnqllPnzvxgIp/5REaQZy5wBI1rthqBj/4OmShK2iQRQ== X-Received: from almasrymina.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:4bc5]) (user=almasrymina job=sendgmr) by 2002:a05:6902:1893:b0:e02:5b08:d3a with SMTP id 3f1490d57ef6-e02fc29cc0emr60260276.0.1719345258139; Tue, 25 Jun 2024 12:54:18 -0700 (PDT) Date: Tue, 25 Jun 2024 19:53:52 +0000 In-Reply-To: <20240625195407.1922912-1-almasrymina@google.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240625195407.1922912-1-almasrymina@google.com> X-Mailer: git-send-email 2.45.2.741.gdbec12cfda-goog Message-ID: <20240625195407.1922912-5-almasrymina@google.com> Subject: [PATCH net-next v14 04/13] netdev: netdevice devmem allocator From: Mina Almasry To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-alpha@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arch@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: Mina Almasry , Donald Hunter , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , Jonathan Corbet , Richard Henderson , Ivan Kokshaysky , Matt Turner , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Andreas Larsson , Jesper Dangaard Brouer , Ilias Apalodimas , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Arnd Bergmann , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Steffen Klassert , Herbert Xu , David Ahern , Willem de Bruijn , Shuah Khan , Sumit Semwal , " =?utf-8?q?Christian_K=C3=B6nig?= " , Bagas Sanjaya , Christoph Hellwig , Nikolay Aleksandrov , Pavel Begunkov , David Wei , Jason Gunthorpe , Yunsheng Lin , Shailend Chand , Harshitha Ramamurthy , Shakeel Butt , Jeroen de Borst , Praveen Kaligineedi , Willem de Bruijn , Kaiyuan Zhang Implement netdev devmem allocator. The allocator takes a given struct netdev_dmabuf_binding as input and allocates net_iov from that binding. The allocation simply delegates to the binding's genpool for the allocation logic and wraps the returned memory region in a net_iov struct. Signed-off-by: Willem de Bruijn Signed-off-by: Kaiyuan Zhang Signed-off-by: Mina Almasry Reviewed-by: Pavel Begunkov --- v11: - Fix extraneous inline directive (Paolo) v8: - Rename netdev_dmabuf_binding -> net_devmem_dmabuf_binding to avoid patch-by-patch build error. - Move niov->pp_magic/pp/pp_ref_counter usage to later patch to avoid patch-by-patch build error. v7: - netdev_ -> net_devmem_* naming (Yunsheng). v6: - Add comment on net_iov_dma_addr to explain why we don't use niov->dma_addr (Pavel) - Refactor new functions into net/core/devmem.c (Pavel) v1: - Rename devmem -> dmabuf (David). --- include/net/devmem.h | 13 +++++++++++++ include/net/netmem.h | 18 ++++++++++++++++++ net/core/devmem.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 75 insertions(+) diff --git a/include/net/devmem.h b/include/net/devmem.h index eaf3fd965d7a8..b65795a8f8f13 100644 --- a/include/net/devmem.h +++ b/include/net/devmem.h @@ -68,7 +68,20 @@ int net_devmem_bind_dmabuf(struct net_device *dev, unsigned int dmabuf_fd, void net_devmem_unbind_dmabuf(struct net_devmem_dmabuf_binding *binding); int net_devmem_bind_dmabuf_to_queue(struct net_device *dev, u32 rxq_idx, struct net_devmem_dmabuf_binding *binding); +struct net_iov * +net_devmem_alloc_dmabuf(struct net_devmem_dmabuf_binding *binding); +void net_devmem_free_dmabuf(struct net_iov *ppiov); #else +static inline struct net_iov * +net_devmem_alloc_dmabuf(struct net_devmem_dmabuf_binding *binding) +{ + return NULL; +} + +static inline void net_devmem_free_dmabuf(struct net_iov *ppiov) +{ +} + static inline void __net_devmem_dmabuf_binding_free(struct net_devmem_dmabuf_binding *binding) { diff --git a/include/net/netmem.h b/include/net/netmem.h index 72e932a1a9489..01dbdd216fae7 100644 --- a/include/net/netmem.h +++ b/include/net/netmem.h @@ -14,8 +14,26 @@ struct net_iov { struct dmabuf_genpool_chunk_owner *owner; + unsigned long dma_addr; }; +static inline struct dmabuf_genpool_chunk_owner * +net_iov_owner(const struct net_iov *niov) +{ + return niov->owner; +} + +static inline unsigned int net_iov_idx(const struct net_iov *niov) +{ + return niov - net_iov_owner(niov)->niovs; +} + +static inline struct net_devmem_dmabuf_binding * +net_iov_binding(const struct net_iov *niov) +{ + return net_iov_owner(niov)->binding; +} + /* netmem */ /** diff --git a/net/core/devmem.c b/net/core/devmem.c index cfb5a2f69dcd2..aeee25c91b844 100644 --- a/net/core/devmem.c +++ b/net/core/devmem.c @@ -32,6 +32,14 @@ static void net_devmem_dmabuf_free_chunk_owner(struct gen_pool *genpool, kfree(owner); } +static dma_addr_t net_devmem_get_dma_addr(const struct net_iov *niov) +{ + struct dmabuf_genpool_chunk_owner *owner = net_iov_owner(niov); + + return owner->base_dma_addr + + ((dma_addr_t)net_iov_idx(niov) << PAGE_SHIFT); +} + void __net_devmem_dmabuf_binding_free(struct net_devmem_dmabuf_binding *binding) { size_t size, avail; @@ -54,6 +62,42 @@ void __net_devmem_dmabuf_binding_free(struct net_devmem_dmabuf_binding *binding) kfree(binding); } +struct net_iov * +net_devmem_alloc_dmabuf(struct net_devmem_dmabuf_binding *binding) +{ + struct dmabuf_genpool_chunk_owner *owner; + unsigned long dma_addr; + struct net_iov *niov; + ssize_t offset; + ssize_t index; + + dma_addr = gen_pool_alloc_owner(binding->chunk_pool, PAGE_SIZE, + (void **)&owner); + if (!dma_addr) + return NULL; + + offset = dma_addr - owner->base_dma_addr; + index = offset / PAGE_SIZE; + niov = &owner->niovs[index]; + + niov->dma_addr = 0; + + net_devmem_dmabuf_binding_get(binding); + + return niov; +} + +void net_devmem_free_dmabuf(struct net_iov *niov) +{ + struct net_devmem_dmabuf_binding *binding = net_iov_binding(niov); + unsigned long dma_addr = net_devmem_get_dma_addr(niov); + + if (gen_pool_has_addr(binding->chunk_pool, dma_addr, PAGE_SIZE)) + gen_pool_free(binding->chunk_pool, dma_addr, PAGE_SIZE); + + net_devmem_dmabuf_binding_put(binding); +} + /* Protected by rtnl_lock() */ static DEFINE_XARRAY_FLAGS(net_devmem_dmabuf_bindings, XA_FLAGS_ALLOC1);