| Message ID | 20240725121212.808206-1-usama.anjum@collabora.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 38cde27f74d8bbe2f705fb1f80384acab9762e9e |
| Headers | show |
| Series | [v2] selftests: lib: remove strscpy test | expand |
On 7/25/24 06:11, Muhammad Usama Anjum wrote: > The strscpy test loads test_strscpy module for testing. But test_strscpy > was converted to Kunit (see fixes). Hence remove strscpy. > > Fixes: 41eefc46a3a4 ("string: Convert strscpy() self-test to KUnit") Remove fixes tag - this isn't a fix and we don't want this propagating to stable releases without kunit test for this. It appears fixes tag is being used too generously for things that aren't fixes. Let's use it only when it is a real fix. > Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> > --- thanks, -- Shuah
On 7/25/24 06:11, Muhammad Usama Anjum wrote: > The strscpy test loads test_strscpy module for testing. But test_strscpy > was converted to Kunit (see fixes). Hence remove strscpy. > > Fixes: 41eefc46a3a4 ("string: Convert strscpy() self-test to KUnit") > Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> > --- > Changes since v1: > - Remove from Makefile and config file as well > --- As mentioned in other threads on this conversion to kunit and removal of kselfttest - NACK on this patch. Please don't send me any more of these conversion and removal patches. thanks, -- Shuah
On 7/31/24 3:37 AM, Shuah Khan wrote: > On 7/25/24 06:11, Muhammad Usama Anjum wrote: >> The strscpy test loads test_strscpy module for testing. But test_strscpy >> was converted to Kunit (see fixes). Hence remove strscpy. >> >> Fixes: 41eefc46a3a4 ("string: Convert strscpy() self-test to KUnit") >> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> >> --- >> Changes since v1: >> - Remove from Makefile and config file as well >> --- > > As mentioned in other threads on this conversion to kunit and removal > of kselfttest - NACK on this patch. > > Please don't send me any more of these conversion and removal patches. This patch is removing a dead kselftest as its corresponding test module was moved years ago (in 2022). This test has been failing since then. It seems like misunderstanding that I'm removing something. > > thanks, > -- Shuah >
On 7/31/24 02:32, Muhammad Usama Anjum wrote: > On 7/31/24 3:37 AM, Shuah Khan wrote: >> On 7/25/24 06:11, Muhammad Usama Anjum wrote: >>> The strscpy test loads test_strscpy module for testing. But test_strscpy >>> was converted to Kunit (see fixes). Hence remove strscpy. >>> >>> Fixes: 41eefc46a3a4 ("string: Convert strscpy() self-test to KUnit") >>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> >>> --- >>> Changes since v1: >>> - Remove from Makefile and config file as well >>> --- >> >> As mentioned in other threads on this conversion to kunit and removal >> of kselfttest - NACK on this patch. >> >> Please don't send me any more of these conversion and removal patches. > This patch is removing a dead kselftest as its corresponding test module > was moved years ago (in 2022). This test has been failing since then. It > seems like misunderstanding that I'm removing something. > Thank you for the clarification Applied linux-kselftest for Linux 6.12-rc1 thanks, -- Shuah
diff --git a/tools/testing/selftests/lib/Makefile b/tools/testing/selftests/lib/Makefile index ee71fc99d5b51..c52fe3ad8e986 100644 --- a/tools/testing/selftests/lib/Makefile +++ b/tools/testing/selftests/lib/Makefile @@ -4,6 +4,5 @@ # No binaries, but make sure arg-less "make" doesn't trigger "run_tests" all: -TEST_PROGS := printf.sh bitmap.sh prime_numbers.sh scanf.sh strscpy.sh - +TEST_PROGS := printf.sh bitmap.sh prime_numbers.sh scanf.sh include ../lib.mk diff --git a/tools/testing/selftests/lib/config b/tools/testing/selftests/lib/config index 645839b50b0a2..dc15aba8d0a3d 100644 --- a/tools/testing/selftests/lib/config +++ b/tools/testing/selftests/lib/config @@ -2,5 +2,4 @@ CONFIG_TEST_PRINTF=m CONFIG_TEST_SCANF=m CONFIG_TEST_BITMAP=m CONFIG_PRIME_NUMBERS=m -CONFIG_TEST_STRSCPY=m CONFIG_TEST_BITOPS=m diff --git a/tools/testing/selftests/lib/strscpy.sh b/tools/testing/selftests/lib/strscpy.sh deleted file mode 100755 index be60ef6e1a7fb..0000000000000 --- a/tools/testing/selftests/lib/strscpy.sh +++ /dev/null @@ -1,3 +0,0 @@ -#!/bin/sh -# SPDX-License-Identifier: GPL-2.0+ -$(dirname $0)/../kselftest/module.sh "strscpy*" test_strscpy
The strscpy test loads test_strscpy module for testing. But test_strscpy was converted to Kunit (see fixes). Hence remove strscpy. Fixes: 41eefc46a3a4 ("string: Convert strscpy() self-test to KUnit") Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> --- Changes since v1: - Remove from Makefile and config file as well --- tools/testing/selftests/lib/Makefile | 3 +-- tools/testing/selftests/lib/config | 1 - tools/testing/selftests/lib/strscpy.sh | 3 --- 3 files changed, 1 insertion(+), 6 deletions(-) delete mode 100755 tools/testing/selftests/lib/strscpy.sh