| Message ID | 20240729-dt-kselftest-parent-disabled-v2-1-d7a001c4930d@collabora.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 05144ab7b7eaf531fc728fcb79dcf36b621ff42d |
| Headers | show |
| Series | [v2] kselftest: dt: Ignore nodes that have ancestors disabled | expand |
On Mon, Jul 29, 2024 at 04:56:02PM -0400, Nícolas F. R. A. Prado wrote: > Filter out nodes that have one of its ancestors disabled as they aren't > expected to probe. > > This removes the following false-positive failures on the > sc7180-trogdor-lazor-limozeen-nots-r5 platform: > > /soc@0/geniqup@8c0000/i2c@894000/proximity@28 > /soc@0/geniqup@ac0000/spi@a90000/ec@0 > /soc@0/remoteproc@62400000/glink-edge/apr > /soc@0/remoteproc@62400000/glink-edge/apr/service@3 > /soc@0/remoteproc@62400000/glink-edge/apr/service@4 > /soc@0/remoteproc@62400000/glink-edge/apr/service@4/clock-controller > /soc@0/remoteproc@62400000/glink-edge/apr/service@4/dais > /soc@0/remoteproc@62400000/glink-edge/apr/service@7 > /soc@0/remoteproc@62400000/glink-edge/apr/service@7/dais > /soc@0/remoteproc@62400000/glink-edge/apr/service@8 > /soc@0/remoteproc@62400000/glink-edge/apr/service@8/routing > /soc@0/remoteproc@62400000/glink-edge/fastrpc > /soc@0/remoteproc@62400000/glink-edge/fastrpc/compute-cb@3 > /soc@0/remoteproc@62400000/glink-edge/fastrpc/compute-cb@4 > /soc@0/remoteproc@62400000/glink-edge/fastrpc/compute-cb@5 > /soc@0/spmi@c440000/pmic@0/pon@800/pwrkey > > Fixes: 14571ab1ad21 ("kselftest: Add new test for detecting unprobed Devicetree devices") > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > --- > Changes in v2: > - Rebased on v6.11-rc1 > - Link to v1: https://lore.kernel.org/r/20240619-dt-kselftest-parent-disabled-v1-1-b8f7a8778906@collabora.com Hi Rob, gentle ping on this patch. It's a fix and has been around for a while. Thanks, Nícolas
On Mon, Jul 29, 2024 at 04:56:02PM -0400, Nícolas F. R. A. Prado wrote: > Filter out nodes that have one of its ancestors disabled as they aren't > expected to probe. > > This removes the following false-positive failures on the > sc7180-trogdor-lazor-limozeen-nots-r5 platform: > > /soc@0/geniqup@8c0000/i2c@894000/proximity@28 > /soc@0/geniqup@ac0000/spi@a90000/ec@0 > /soc@0/remoteproc@62400000/glink-edge/apr > /soc@0/remoteproc@62400000/glink-edge/apr/service@3 > /soc@0/remoteproc@62400000/glink-edge/apr/service@4 > /soc@0/remoteproc@62400000/glink-edge/apr/service@4/clock-controller > /soc@0/remoteproc@62400000/glink-edge/apr/service@4/dais > /soc@0/remoteproc@62400000/glink-edge/apr/service@7 > /soc@0/remoteproc@62400000/glink-edge/apr/service@7/dais > /soc@0/remoteproc@62400000/glink-edge/apr/service@8 > /soc@0/remoteproc@62400000/glink-edge/apr/service@8/routing > /soc@0/remoteproc@62400000/glink-edge/fastrpc > /soc@0/remoteproc@62400000/glink-edge/fastrpc/compute-cb@3 > /soc@0/remoteproc@62400000/glink-edge/fastrpc/compute-cb@4 > /soc@0/remoteproc@62400000/glink-edge/fastrpc/compute-cb@5 > /soc@0/spmi@c440000/pmic@0/pon@800/pwrkey > > Fixes: 14571ab1ad21 ("kselftest: Add new test for detecting unprobed Devicetree devices") > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > --- > Changes in v2: > - Rebased on v6.11-rc1 > - Link to v1: https://lore.kernel.org/r/20240619-dt-kselftest-parent-disabled-v1-1-b8f7a8778906@collabora.com > --- > tools/testing/selftests/dt/test_unprobed_devices.sh | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) Applied. Sorry for missing this. Rob
diff --git a/tools/testing/selftests/dt/test_unprobed_devices.sh b/tools/testing/selftests/dt/test_unprobed_devices.sh index 2d7e70c5ad2d..5e3f42ef249e 100755 --- a/tools/testing/selftests/dt/test_unprobed_devices.sh +++ b/tools/testing/selftests/dt/test_unprobed_devices.sh @@ -34,8 +34,21 @@ nodes_compatible=$( # Check if node is available if [[ -e "${node}"/status ]]; then status=$(tr -d '\000' < "${node}"/status) - [[ "${status}" != "okay" && "${status}" != "ok" ]] && continue + if [[ "${status}" != "okay" && "${status}" != "ok" ]]; then + if [ -n "${disabled_nodes_regex}" ]; then + disabled_nodes_regex="${disabled_nodes_regex}|${node}" + else + disabled_nodes_regex="${node}" + fi + continue + fi fi + + # Ignore this node if one of its ancestors was disabled + if [ -n "${disabled_nodes_regex}" ]; then + echo "${node}" | grep -q -E "${disabled_nodes_regex}" && continue + fi + echo "${node}" | sed -e 's|\/proc\/device-tree||' done | sort )
Filter out nodes that have one of its ancestors disabled as they aren't expected to probe. This removes the following false-positive failures on the sc7180-trogdor-lazor-limozeen-nots-r5 platform: /soc@0/geniqup@8c0000/i2c@894000/proximity@28 /soc@0/geniqup@ac0000/spi@a90000/ec@0 /soc@0/remoteproc@62400000/glink-edge/apr /soc@0/remoteproc@62400000/glink-edge/apr/service@3 /soc@0/remoteproc@62400000/glink-edge/apr/service@4 /soc@0/remoteproc@62400000/glink-edge/apr/service@4/clock-controller /soc@0/remoteproc@62400000/glink-edge/apr/service@4/dais /soc@0/remoteproc@62400000/glink-edge/apr/service@7 /soc@0/remoteproc@62400000/glink-edge/apr/service@7/dais /soc@0/remoteproc@62400000/glink-edge/apr/service@8 /soc@0/remoteproc@62400000/glink-edge/apr/service@8/routing /soc@0/remoteproc@62400000/glink-edge/fastrpc /soc@0/remoteproc@62400000/glink-edge/fastrpc/compute-cb@3 /soc@0/remoteproc@62400000/glink-edge/fastrpc/compute-cb@4 /soc@0/remoteproc@62400000/glink-edge/fastrpc/compute-cb@5 /soc@0/spmi@c440000/pmic@0/pon@800/pwrkey Fixes: 14571ab1ad21 ("kselftest: Add new test for detecting unprobed Devicetree devices") Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> --- Changes in v2: - Rebased on v6.11-rc1 - Link to v1: https://lore.kernel.org/r/20240619-dt-kselftest-parent-disabled-v1-1-b8f7a8778906@collabora.com --- tools/testing/selftests/dt/test_unprobed_devices.sh | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) --- base-commit: 8400291e289ee6b2bf9779ff1c83a291501f017b change-id: 20240619-dt-kselftest-parent-disabled-2282a7223d26 Best regards,