| Message ID | 20241008065123.26422-1-richard120310@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [RESEND,v4] list: test: Check the size of every lists for list_cut_position*() | expand |
Hi I Hsin, On Tue, Oct 08, 2024 at 02:51:23PM +0800, I Hsin Cheng wrote: > Check the total number of elements in both resultant lists are correct > within list_cut_position*(). Previously, only the first list's size was > checked. wo additional elements in the second list would not have been > caught. > > Signed-off-by: I Hsin Cheng <richard120310@gmail.com> > --- > change in v4: > Amend the description of commit message, make it less confusing > and focus on the correct check which is performed now. > Generally, we don't add the prefix "RESEND" to the subject line of the next version of a patch. "RESEND" is only used for resubmissions of a patch that hasn't been modified in any way from the previous submission. See: https://www.kernel.org/doc/html/v6.11/process/submitting-patches.html#don-t-get-discouraged-or-impatient Regards, Kuan-Wei
diff --git a/lib/list-test.c b/lib/list-test.c index 37cbc33e9fdb..b4b3810c71d0 100644 --- a/lib/list-test.c +++ b/lib/list-test.c @@ -408,6 +408,8 @@ static void list_test_list_cut_position(struct kunit *test) KUNIT_EXPECT_PTR_EQ(test, cur, &entries[i]); i++; } + + KUNIT_EXPECT_EQ(test, i, 3); } static void list_test_list_cut_before(struct kunit *test) @@ -436,6 +438,8 @@ static void list_test_list_cut_before(struct kunit *test) KUNIT_EXPECT_PTR_EQ(test, cur, &entries[i]); i++; } + + KUNIT_EXPECT_EQ(test, i, 3); } static void list_test_list_splice(struct kunit *test)
Check the total number of elements in both resultant lists are correct within list_cut_position*(). Previously, only the first list's size was checked. wo additional elements in the second list would not have been caught. Signed-off-by: I Hsin Cheng <richard120310@gmail.com> --- change in v4: Amend the description of commit message, make it less confusing and focus on the correct check which is performed now. lib/list-test.c | 4 ++++ 1 file changed, 4 insertions(+)