| Message ID | 20241213152244.3080955-4-kuba@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
On Fri, Dec 13, 2024 at 07:22:42AM -0800, Jakub Kicinski wrote: > recv_size parameter allows constraining the buffer size for dumps. > It's useful in testing kernel handling of dump continuation, > IOW testing dumps which span multiple skbs. > > Let the tests set this parameter when initializing the YNL family. > Keep the normal default, we don't want tests to unintentionally > behave very differently than normal code. > > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > --- > CC: shuah@kernel.org > CC: jiri@resnulli.us > CC: petrm@nvidia.com > CC: linux-kselftest@vger.kernel.org > --- > tools/testing/selftests/net/lib/py/ynl.py | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/tools/testing/selftests/net/lib/py/ynl.py b/tools/testing/selftests/net/lib/py/ynl.py > index a0d689d58c57..076a7e8dc3eb 100644 > --- a/tools/testing/selftests/net/lib/py/ynl.py > +++ b/tools/testing/selftests/net/lib/py/ynl.py > @@ -32,23 +32,23 @@ from .ksft import ksft_pr, ktap_result > # Set schema='' to avoid jsonschema validation, it's slow > # > class EthtoolFamily(YnlFamily): > - def __init__(self): > + def __init__(self, recv_size=0): > super().__init__((SPEC_PATH / Path('ethtool.yaml')).as_posix(), > - schema='') > + schema='', recv_size=recv_size) > > > class RtnlFamily(YnlFamily): > - def __init__(self): > + def __init__(self, recv_size=0): > super().__init__((SPEC_PATH / Path('rt_link.yaml')).as_posix(), > - schema='') > + schema='', recv_size=recv_size) > > > class NetdevFamily(YnlFamily): > - def __init__(self): > + def __init__(self, recv_size=0): > super().__init__((SPEC_PATH / Path('netdev.yaml')).as_posix(), > - schema='') > + schema='', recv_size=recv_size) > > class NetshaperFamily(YnlFamily): > - def __init__(self): > + def __init__(self, recv_size=0): > super().__init__((SPEC_PATH / Path('net_shaper.yaml')).as_posix(), > - schema='') > + schema='', recv_size=recv_size) Reviewed-by: Joe Damato <jdamato@fastly.com>
Jakub Kicinski <kuba@kernel.org> writes: > recv_size parameter allows constraining the buffer size for dumps. > It's useful in testing kernel handling of dump continuation, > IOW testing dumps which span multiple skbs. > > Let the tests set this parameter when initializing the YNL family. > Keep the normal default, we don't want tests to unintentionally > behave very differently than normal code. > > Signed-off-by: Jakub Kicinski <kuba@kernel.org> Reviewed-by: Petr Machata <petrm@nvidia.com>
diff --git a/tools/testing/selftests/net/lib/py/ynl.py b/tools/testing/selftests/net/lib/py/ynl.py index a0d689d58c57..076a7e8dc3eb 100644 --- a/tools/testing/selftests/net/lib/py/ynl.py +++ b/tools/testing/selftests/net/lib/py/ynl.py @@ -32,23 +32,23 @@ from .ksft import ksft_pr, ktap_result # Set schema='' to avoid jsonschema validation, it's slow # class EthtoolFamily(YnlFamily): - def __init__(self): + def __init__(self, recv_size=0): super().__init__((SPEC_PATH / Path('ethtool.yaml')).as_posix(), - schema='') + schema='', recv_size=recv_size) class RtnlFamily(YnlFamily): - def __init__(self): + def __init__(self, recv_size=0): super().__init__((SPEC_PATH / Path('rt_link.yaml')).as_posix(), - schema='') + schema='', recv_size=recv_size) class NetdevFamily(YnlFamily): - def __init__(self): + def __init__(self, recv_size=0): super().__init__((SPEC_PATH / Path('netdev.yaml')).as_posix(), - schema='') + schema='', recv_size=recv_size) class NetshaperFamily(YnlFamily): - def __init__(self): + def __init__(self, recv_size=0): super().__init__((SPEC_PATH / Path('net_shaper.yaml')).as_posix(), - schema='') + schema='', recv_size=recv_size)
recv_size parameter allows constraining the buffer size for dumps. It's useful in testing kernel handling of dump continuation, IOW testing dumps which span multiple skbs. Let the tests set this parameter when initializing the YNL family. Keep the normal default, we don't want tests to unintentionally behave very differently than normal code. Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- CC: shuah@kernel.org CC: jiri@resnulli.us CC: petrm@nvidia.com CC: linux-kselftest@vger.kernel.org --- tools/testing/selftests/net/lib/py/ynl.py | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)