diff mbox series

selftests/damon/damos_quota_goal: handle minimum quota that cannot be further reduced

Message ID 20250217182304.45215-1-sj@kernel.org (mailing list archive)
State New
Headers show
Series selftests/damon/damos_quota_goal: handle minimum quota that cannot be further reduced | expand

Commit Message

SeongJae Park Feb. 17, 2025, 6:23 p.m. UTC
damos_quota_goal.py selftest see if DAMOS quota goals tuning feature
increases or reduces the effective size quota for given score as
expected.  The tuning feature sets the minimum quota size as one byte,
so if the effective size quota is already one, we cannot expect it
further be reduced.  However the test is not aware of the edge case, and
fails since it shown no expected change of the effective quota.  Handle
the case by updating the failure logic for no change to see if it was
the case, and simply skips to next test input.

Fixes: f1c07c0a1662b ("selftests/damon: add a test for DAMOS quota goal")
Cc: <stable@vger.kernel.org> # 6.10.x
Reported-by: kernel test robot <oliver.sang@intel.com>
Closes: https://lore.kernel.org/oe-lkp/202502171423.b28a918d-lkp@intel.com
Signed-off-by: SeongJae Park <sj@kernel.org>
---
 tools/testing/selftests/damon/damos_quota_goal.py | 3 +++
 1 file changed, 3 insertions(+)


base-commit: 20017459916819f8ae15ca3840e71fbf0ea8354e
diff mbox series

Patch

diff --git a/tools/testing/selftests/damon/damos_quota_goal.py b/tools/testing/selftests/damon/damos_quota_goal.py
index 18246f3b62f7..f76e0412b564 100755
--- a/tools/testing/selftests/damon/damos_quota_goal.py
+++ b/tools/testing/selftests/damon/damos_quota_goal.py
@@ -63,6 +63,9 @@  def main():
             if last_effective_bytes != 0 else -1.0))
 
         if last_effective_bytes == goal.effective_bytes:
+            # effective quota was already minimum that cannot be more reduced
+            if expect_increase is False and last_effective_bytes == 1:
+                continue
             print('efective bytes not changed: %d' % goal.effective_bytes)
             exit(1)