From patchwork Mon Feb 24 09:22:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Seiderer X-Patchwork-Id: 13987657 Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 778EE24BC08; Mon, 24 Feb 2025 09:22:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740388980; cv=none; b=OEGr4HOHIJmZ9lvoYtwEHHi0dfBRocqX4pouPhyuQtmC0iUlN+LfYLSwSf0YNKIaAIHnwVTGMkMy39pPGdeyJOeR2qxQtHnP+D3A96m3J/JZBl3Y61iSNAGIT/4E6y1q6ogXKHXcqhywePKuq4gYZZBwkdOeDg3n6+YrGH9jmJU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740388980; c=relaxed/simple; bh=j+ZMvUdvZ7CSrVjG/S0MjvEWJ5CEcbjC4jhnBGbsaxs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kJBXe3AEEpgVCru9JTvk8pytsOxH7AvIC//94gAn9ZYvy3sg7FQoiaNSVxohBUF+satxInTy9IfnxrCVx9PXCEfCLwjhbp2o4KOT4pWM8LR52eRWpcrxV4VbwnalPYZHazOz6ChWHGHe6EyuRfEBXToOJN1MiEHoM9cnjKqGLew= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b=Mibq8nS0; arc=none smtp.client-ip=212.227.15.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b="Mibq8nS0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1740388972; x=1740993772; i=ps.report@gmx.net; bh=j+ZMvUdvZ7CSrVjG/S0MjvEWJ5CEcbjC4jhnBGbsaxs=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-ID:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=Mibq8nS0dkfxO5upgth1mXJBmiBkquiDvxJezOPmKv7Ao2H9nT6RnylAxFHCP5Dk CEvSw6IEswfq0mUthaPk8K8WKG/U5YWLjz/w7dev36MU16z5JU3I35121h4ua717I nquH1/5mOVTejeGTtJSDzD/w6frYf5UjPe2RzdRii8WBPbST4fCtKW++zZ1Bi1X7/ /uO9NolkzViIHiZUQFSr1su3NeB25MoBayUx2lFHx/JV5ubGhRohnF7O+UDwNU4pK oc3RDlSOdRaPDj5c/RF1m7yakpFlhCXiWShdWjWBS03QSf5zHZPTDEPNFvrb4ccfD F0heFun1WJzslfKOng== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from localhost.fritz.box ([82.135.81.227]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mk0Ne-1t2OLD3Dy4-00n9Tu; Mon, 24 Feb 2025 10:22:51 +0100 From: Peter Seiderer To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Shuah Khan , Peter Seiderer , Thomas Gleixner , Artem Chernyshev , Frederic Weisbecker , Nam Cao Subject: [PATCH net-next v7 3/8] net: pktgen: remove some superfluous variable initializing Date: Mon, 24 Feb 2025 10:22:37 +0100 Message-ID: <20250224092242.13192-4-ps.report@gmx.net> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250224092242.13192-1-ps.report@gmx.net> References: <20250224092242.13192-1-ps.report@gmx.net> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:3o6Ia6EmkO6p/MdUU5yA8mxbjTpHv0TYmStRBQccVuD/XjaM6d5 wB8/gsQVENCs8xCe1CBmBtgPLw6694rXG61Js4sJ43tOA5TAdG7OyQ9hKlJbmNHr3q5ZGIi KOe1zWJxeGEWK036/KE7RhMOf2PA4AVTUSmKy0g/Hp2AZesYuZQXF/D/NXOk4Wz4+h1JXx4 1npj2GQGMd7LiNhnfVNog== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:IU7UvSRrSqw=;uLmh5DULuauslwE8XtK8gCzjuLr segtQwEVYNF5u/G2n83iNBOAQLsiRNHGFKyD8i8hOTXG9KlGUVuaMeMeftiIQcBI4KKIOX05C 6TqvRSXDVhSfKOymZs9r8SRiFFSznmoiygTFm+/G92B91gzv8BOikwHFLqhhyNdLmeg6WsaO7 iyMb5xXfoEJf1Wt2pgKmvjsoz9nFoGHltUrP4ccmNyu11bJOyQdcxz/IXIH96PS1mS3K7A2dG w8beBp6LVrE+Kvu4Gv54rcbUAixlI31KK2hcSdAGGg+gNZ13k0wa5WjmOK58DY7LyGT4ymu0s oAsGaBGemHw9u0BWC6pfqNXWlDiwvR5Na96lRUC3jGjwML6TlT8xXVU/pKgKN8Zr9nwqbk0ob R4CSS91MtBEkpKI/289ifvxEJjUTC3sHNHln+iyt1vEnSE/TtP0nhkrq4OxxK934x0LHy+T6T S9eG58YVSpK7AaWssvTjdQaTVmtrCbeAYYivOTCs8AuVn/LMov34jWrRJKTVAJA3P6O2A9kxn kQNJFbm96Rfa444Px7RFBNkfgkHQFGQwafKKEKlFD+AWXgs7sZ56zVaYFFXFKijElJkDZi2Q+ ie9aaZu57ZOPJAAD3jnNTUrp9E4jQMPm/CgrgCiu5soJiGReX+JNPQHcczTkqWbudfVWuWWR7 9R9v3UFXffjqiXvlEF2kNVYLnA/Pi11VK8Wdy+98HbRO6RKgIVBs1n/qNCMVMoJakcKRruumk i6lHMUKteAEnxgrSGbw8uMGaFQrc0lJNSRkcAb1GQG2ImsAaPUObZ6LwQyJy0eWJpMNtuqTIv BDVzHTekEjYtjqPbRJv7aDa+V2vKwPfayJRct6B+RIIDrr5K2KMHS1M9ZhwGDXUZnOdtZI/XD NnQihkAJGpk4SbOzGtVsvAmqWmzE1zYyLxip7f9j3dMXnyu3Bkst6RNmogB0ARyRhqd50dXlO NmVPn3WOBkJYMfqM9cMR85rXfzF+GY1DtfQyDzKrDq3uKP7pqHM7/U60mVy9gpHO3HGMLdiHV rc5GcWihuc5JkX5t3MYvdcR9Wu5/3R23IS90RJFK1xK3kD/LGm+QgcLOVDllsPxGMlthzGY5C SUZ+8LLNrS/MaV/dSIGVdbdC81kWFcHU5u5UxxTY68s50LoaM9hU9/bNEaDJcv4XXuI+JjtGB MQSfE5GMcbwzcsAGvYio+Mn9+CFAtyUSpq67k/EpgbAJG/XoB0s+jVGmkVr1bamYQzrr1uimZ kvtbjgN9apyxXKOlgYn2byH6QyOO98w2VLBpDKkircis/B5Z5YanRt72nG+HNb4ICUMIIRwaU I+Sfm21868REHnBf45VwziPbY0CIUbD0IhcPPBL0KN4If0lpqkikFjP1RNv0fxiF0gO27MuXR PIvaf6ybs+9rEfk9Ogm168ou/JDOFJtjtwE39VkWeJRdiTt5gv5MnYHCnV Remove some superfluous variable initializing before hex32_arg call (as the same init is done here already). Signed-off-by: Peter Seiderer Reviewed-by: Simon Horman --- Changes v6 -> v7 - rebased on actual net-next/main - no changes Changes v5 -> v6 - adjust to dropped patch ''net: pktgen: use defines for the various dec/hex number parsing digits lengths' Changes v4 -> v5 - split up patchset into part i/ii (suggested by Simon Horman) - add rev-by Simon Horman Changes v3 -> v4 - new patch (factored out of patch 'net: pktgen: fix access outside of user given buffer in pktgen_if_write()') --- net/core/pktgen.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/core/pktgen.c b/net/core/pktgen.c index b97a94cb85ac..204f93de03aa 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -1787,7 +1787,7 @@ static ssize_t pktgen_if_write(struct file *file, } if (!strcmp(name, "tos")) { - __u32 tmp_value = 0; + __u32 tmp_value; len = hex32_arg(&user_buffer[i], 2, &tmp_value); if (len < 0) return len; @@ -1803,7 +1803,7 @@ static ssize_t pktgen_if_write(struct file *file, } if (!strcmp(name, "traffic_class")) { - __u32 tmp_value = 0; + __u32 tmp_value; len = hex32_arg(&user_buffer[i], 2, &tmp_value); if (len < 0) return len;