From patchwork Wed Feb 26 19:27:24 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Krakauer X-Patchwork-Id: 13993057 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB23823A9B1 for ; Wed, 26 Feb 2025 19:28:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740598112; cv=none; b=CU3Ink5iYnGW3gXBLtGby1e4ZbGAAh2UVDgvDKtOwhIlePRfFUBaYa8NnquXKvT0jqOiU2xUmlcBxbAfKUSrUFhHCbQ8CubxUI1yfV3YsKtegDpg5km676dA+ixrcMIFIc7azkrkWXrGTk5H9xB4W2zrf8hkLXfjc7dqJh+u7HY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740598112; c=relaxed/simple; bh=tZ4mEjz0mMBNAvIEKtBrdqpxwP3sR5OVhL8PyV1SRr8=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Hbrlc0DqlftiFr0XYd+Tl7EXUqdFwS0EpzEByLPgvgDhaHOnQpXzqhkCpiZ8USDz4d5wmdk2u/qXEE9G7nJju0eb2rpSKmnZYPgsp7+Ilf3p5s4MMPoyMadoAiw3/z6z1mPQ84DEkdT9mURbYleqf47UqemXdrf3t9E5YUQcOyg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--krakauer.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=JaYDl7bj; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--krakauer.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="JaYDl7bj" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-2fc2b258e82so387642a91.0 for ; Wed, 26 Feb 2025 11:28:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740598110; x=1741202910; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=EAHfytQNUsiD5c8K+E1ZBkdfL4DOZcpSAfUWQ+cotG0=; b=JaYDl7bjX5h0huLcAR1OIKmxjCo9+3BOJW4FfQeY7V0kDeGvNWRtTCBQ8DUUco/W/3 0hp+RPfL5nQXwbB78Uzq4ijgG+T6IVGen0M9WNxSzsJnp7f+7YcPjKIND7viHySSwA9G SwYG/XklvpZbx25GurISQmV4kfWvKOGUi0Rmhwjcrr5r4fd8vAUdb0K0FqFR+MryYp0f ThbuOPbr1Rg2qAmnnanuvDfV+v+y/WwZ71KlOlo7TOOJpQJ0YrQMzPvS3FmrGfWg9WHK Y2syXJMs2cGBy6/4gy/sBlMV/Y3uZcXxH7bJsHqfkqlORW17PP2TeLhRIbYAJykYjqjS HxsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740598110; x=1741202910; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EAHfytQNUsiD5c8K+E1ZBkdfL4DOZcpSAfUWQ+cotG0=; b=iuJfm1CLYLDli5CbGRKumsM5BWzasn07jkuce72MS3S29+vxHa6xu2V+xJ52a0paan Ks6V2oI5JHfUal3kdqsSQktANHvcNVNh3pmgAmTXNhqf23P/DOEOZkTsggVI8glU/6Je VrEgHnMOgednXA7WhEUtkPi5b9iOwqKo5XRFnL6mSiIW3P2K3yXI+NFMmfQOF6IFeYf1 nwym6kAHYA3NbEH0s+c0zQ7xfbgf2bOc7TZZIri8dpSWUOUO+XXjkNvyxsIrGdn7vyTZ N0tl5QCzotK4rCm1k3V2Yi9xb+bFpl+G/Z+U5+N4R7FZ2ijXaGVuPFMis/tLzU6rkjlP DWvw== X-Forwarded-Encrypted: i=1; AJvYcCXeCvLdRE8+YgXSQAn1uODN/Ozk8DgHMIl7on6fxGX/zT41oWfjlsXpIVPEaSEawWU6K0iFlKzccHXWaO80XRY=@vger.kernel.org X-Gm-Message-State: AOJu0YzdYA3aHLKC6MMyCYHyGEpcwQ5YqS2C54lzxQVMl4BZegSZuefn QC3hsOewIR4sWjP35hfRsxE4zbOJ26yTuaWB0kRcLX6hxQ6e3qYY2vB6yJTpNjRNdR7Z+uBYFtK TxkoUf6e9 X-Google-Smtp-Source: AGHT+IHnpgBcjLWJK3P1K4UEwO48PptHkVPMDaQtRyrbfS1CeCFR9+JXWBlM+SMFre4xrXqt/dk+pNsU4kVPXg== X-Received: from pjbsg17.prod.google.com ([2002:a17:90b:5211:b0:2fa:2661:76ac]) (user=krakauer job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2d88:b0:2ea:5dea:eb0a with SMTP id 98e67ed59e1d1-2fe7e2e0f5dmr6628296a91.4.1740598109628; Wed, 26 Feb 2025 11:28:29 -0800 (PST) Date: Wed, 26 Feb 2025 11:27:24 -0800 In-Reply-To: <20250226192725.621969-1-krakauer@google.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250226192725.621969-1-krakauer@google.com> X-Mailer: git-send-email 2.48.1.658.g4767266eb4-goog Message-ID: <20250226192725.621969-3-krakauer@google.com> Subject: [PATCH v2 2/3] selftests/net: only print passing message in GRO tests when tests pass From: Kevin Krakauer To: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Shuah Khan , linux-kernel@vger.kernel.org, Kevin Krakauer gro.c:main no longer erroneously claims a test passes when running as a sender. Tested: Ran `gro.sh -t large` to verify the sender no longer prints a status. Signed-off-by: Kevin Krakauer --- tools/testing/selftests/net/gro.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/net/gro.c b/tools/testing/selftests/net/gro.c index b2184847e388..d5824eadea10 100644 --- a/tools/testing/selftests/net/gro.c +++ b/tools/testing/selftests/net/gro.c @@ -1318,11 +1318,13 @@ int main(int argc, char **argv) read_MAC(src_mac, smac); read_MAC(dst_mac, dmac); - if (tx_socket) + if (tx_socket) { gro_sender(); - else + } else { + /* Only the receiver exit status determines test success. */ gro_receiver(); + fprintf(stderr, "Gro::%s test passed.\n", testname); + } - fprintf(stderr, "Gro::%s test passed.\n", testname); return 0; }