From patchwork Thu Jun 28 16:56:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Petr Machata X-Patchwork-Id: 10494575 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D72DC603EE for ; Thu, 28 Jun 2018 16:56:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 61A9E2A53B for ; Thu, 28 Jun 2018 16:56:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 55CEB2A592; Thu, 28 Jun 2018 16:56:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D373E2A53B for ; Thu, 28 Jun 2018 16:56:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967399AbeF1Q4u (ORCPT ); Thu, 28 Jun 2018 12:56:50 -0400 Received: from mail-eopbgr00059.outbound.protection.outlook.com ([40.107.0.59]:24096 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965914AbeF1Q4r (ORCPT ); Thu, 28 Jun 2018 12:56:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+yKSv0kFnzl8HdeUB7Sr7dDiVumMjFio+dhSDj4NvMA=; b=uEzyQ+RaeYxEfBKssqL1Jrdego3up07qGD7pp6HO0c5tNKlMXV4Qt2pGpDm1a5EDVGxBRkyRMJxAPRAnW9e0dHj4sJghJ44wEsR2PHwRb4wZWpNEjcFrm9wgVWm0I1AyXK9jQCbmISYrGIY7OLGnNTBmiLcq6+v161U5HABUjT0= Received: from t540p (78.45.160.211) by AM0PR05MB4177.eurprd05.prod.outlook.com (2603:10a6:208:57::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.20; Thu, 28 Jun 2018 16:56:44 +0000 From: Petr Machata To: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: davem@davemloft.net, shuah@kernel.org Subject: [PATCH net-next 4/4] selftests: forwarding: mirror_gre_changes: Fix waiting for neighbor In-Reply-To: References: Message-Id: <254e52c2f5694e96a86e622337637ff1b9c5e12b.1530204784.git.petrm@mellanox.com> Date: Thu, 28 Jun 2018 18:56:39 +0200 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 X-Originating-IP: [78.45.160.211] X-ClientProxiedBy: DB6P193CA0019.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::29) To AM0PR05MB4177.eurprd05.prod.outlook.com (2603:10a6:208:57::26) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7129925c-acdf-438b-aad8-08d5dd182133 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652034)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600026)(711020)(48565401081)(2017052603328)(7153060)(7193020); SRVR:AM0PR05MB4177; X-Microsoft-Exchange-Diagnostics: 1; AM0PR05MB4177; 3:sw9jhYeoG/6sucRI7AkS5ggZhTRu471rgFOZ4FrlZFKp10QOUM44FtwqBPYsVnmXoL1+uUBASTQj8U2ryLKKH5UuLuSCh52eeWzU4i1ZqYATj0cUeA/dkY6YxvkHDBUapgEwGP86YOqMFqNI7jwlHuiJn3+lhTjk9Tr+XMgN/ZWOIFb1YGFo2v3wGP2UbBiZ/lJHdQbtswnSm8tWdeAIIcL9avTmR94/88nzkz9UhTlaWwfc0RdAVTnwcesJD8MR; 25:SmwuDb3OhbUvDaqtBuhM/Hlt8gn96Ko8FT8D1DoZGPf5K4QRopVNIYW0yd8ZmPd22CieUtnZXq3/oYymis/9YUyruKFeZhgED3tWVeLUE+qOPff7UIe6b8xc2Awhqpq87q1puoLdSfJ4YrnR8Y8/yFsMTBIBQ5ZCX+3HN178kE88i5wldFPTitDGhXExuuU9eYTTBU5ZgD2FMITTq8uTqwL9FN2GHdf+EkfjxFt1+NtsR49GgK/8Solj7kjeHG1bUuuY6fT8XuB7VLbLBm9DrvsKxbCttvjqcPaabtDwOwSNxtU9/EOysM6JDnKFm5igYb0HakvkxuFES8AQ6dU3vw==; 31:vZDPbnvShOCN4eCIhBWuUAqjwhPTDEQCQPDnjGNGKDXdydANOhlvLvAgl4HqO64t3fgDfBfCa5r+p5sx8/gq7nBROIFTKYhKwEzwCxjex144jA+5nT/j/AC7T5pWr78JR8LKnKN5mYhccfvBciGhj4HqkDicin/l1NsMN4P+QxR6NC6yNfs+aZq/Bgp49bjsDxiMIXyM1uJR/28WhyHWQi8L8noFU2E1SWfCP0LLiF8= X-MS-TrafficTypeDiagnostic: AM0PR05MB4177: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=petrm@mellanox.com; X-Microsoft-Exchange-Diagnostics: 1; AM0PR05MB4177; 20:Y1d9hjMPEhONRH5shL9F7kqvPcft7unmCfw5Mf9e4e8p9anC/SPnIaIWcvUtk56qhGyo0yusbfrePxQdtk0flhP1sZyT0Rgf5Zk4kLMMQv7Tpu8CjvSWAkOijfoip0CVkTlQVuSMJBjD/ldmFoCU8y6dLJMknOT13R8n8re7dJgVF1Du5f5yexq5ReDy71ng2aF6IQB7rXH4slEAvThYcpgAiNE3oxrkCsWNWnHUL2BrP9sTEjn7BCqLtDm+jbsCqfJDMxb0VFBhs8TxPw7aNLuPNV0M9WzYMkcFxm0E50fFkegoZAW3Hsxh4ATzucnuwvVT4dGk7R4K6jQ7/xiYe+uxIq71LLPUQdNkx4ldtVLzZxJyCjv1v1xuv4SBI1rO/3uVMUDMkf4kA+3mkMhYTxruLC58pFxARi8boCwZU7lS54uUHppZWBLRgyJAa73aQc/U5hbI82yHY536Iptg1gxIr8O5Ig1vQU6MBz4ONuhMHK4ZneaQOc5fIHi+GuKr; 4:hif01e0BAGPRT9Vx1T3xmzvg+EN+n6tmRQLVPdmoGS2xlZzKsfCCJ8fpy27N4JXCAVwiz5mQjBj8oPObvwcnIja7XVAZu7mymAH7ILBV2DOVDD+zfhbnSoW72d92em+xKJKalSLLPa2wfX+PgtBfcEeqyYNkgMWT+4xZs+lD2HI/OAlSFZz5wGzjnMd673LEpTS76uSbDaIxPlZPrV3QTLMnwfzGjmmFGj3bQYnMMIs171aUROZ26FvQ02+DQHTRGBGwZ5Fb/KxCA+XNRQR5PA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:AM0PR05MB4177; BCL:0; PCL:0; RULEID:; SRVR:AM0PR05MB4177; X-Forefront-PRVS: 0717E25089 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(346002)(376002)(136003)(396003)(366004)(189003)(199004)(47776003)(16526019)(66066001)(58126008)(16586007)(68736007)(36756003)(316002)(106356001)(25786009)(86362001)(4326008)(118296001)(50466002)(53936002)(48376002)(478600001)(105586002)(6666003)(5660300001)(2906002)(386003)(3846002)(6116002)(26005)(8676002)(81166006)(11346002)(305945005)(7736002)(956004)(476003)(6496006)(2616005)(81156014)(446003)(52116002)(186003)(76176011)(8936002)(51416003)(6486002)(97736004)(486006); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB4177; H:t540p; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM0PR05MB4177; 23:LTGRmcen4RO3RPYm5QK95mJDobnGLJRUyY5mNYfqP?= =?us-ascii?Q?YHWA2Yd9HbBvKNlVWZejniQGXlCJPeKBahhyR1jBe5S+gS4WJfNsP0ok+tIU?= =?us-ascii?Q?P8QAMPfrVUrLcVT+hkCyE28l7gkP35Fsy9/tEx8HjnXJ237N69dvYUOwBVbo?= =?us-ascii?Q?FdBlID+bOqObT2g0mlL+g92YupHCS6imk7gh9vtj32bjhvS4MDSF3vous7El?= =?us-ascii?Q?qiSe+2i+0WsTAOtngjGYo/2pJnCPx7KGPkgDOqIVWxGuoYi5UwMFVafur/Vb?= =?us-ascii?Q?Lq1LkPGIMa+PgH3OZfCUAlIY3k1VohyuXCovzhplEc2NL3VmxW8KF1goRmdg?= =?us-ascii?Q?gsqjcmqJtSDVIAC/ztoF/Edc1cgqdrRHoZZFwICqVElX945MRtlZNx28mn78?= =?us-ascii?Q?r6vrhztUDejWADfUSPJQrg/r82v8sXOVPrW3G07RYJg31OcNB8wyTKLV/MhU?= =?us-ascii?Q?Drx3VoG/2ZG7T/dCGgxGtunnqq+thoRrbciJbBH5p73d7gz2WM9Diqo6ay2S?= =?us-ascii?Q?PMqdRgQg3K/EWCjoLcGt6NLJZqUkEsa6QWzVXVgvyI3iVUMnlqgc/ezMz2ur?= =?us-ascii?Q?i91GnzT+NDvim7hIbzjtAgszHm3wQxKKgLFl8F+YoKLPKyiqu9ep1fn3oKEW?= =?us-ascii?Q?Y2be8ktUjd5cEkqnX1zSjKwfr4w/3afavTqyJlK5sD0iz8usCzETg4gXyUoZ?= =?us-ascii?Q?Yto3QawTxkt6IVLoLKUwBeuJrsYKaarGfJN25qlmfoR7ZzwGA+vU5PXa7bKk?= =?us-ascii?Q?NsVdvv2JeCU+Y0coDJOwyy3KKDWS5dnZ0z1on9fPvE9lsTD3z0EPtN0W/lDl?= =?us-ascii?Q?+t3l4cpiRBdDkhkttfTJhqUVPMWF7cUcGzodR85W21Sli4ERJHLLfhkyBpfh?= =?us-ascii?Q?fWpur6+jEE9Sgu12k4Qt5f+a32AtGEbt0pCDwH1Dd+n4yjRgwnjS/lZaQh5B?= =?us-ascii?Q?C5fTQYYYgIYV5zY6nZrpbvxcLRBXCTV7p6qzCZOLaR0ONN/AOveaoFqCqk0n?= =?us-ascii?Q?2j5zzPchtsjWMK+oQ3drUv+iXWClG8g+OYN+5Aj0xJwChq6VnBWG0d6PaN2o?= =?us-ascii?Q?LYg9R5vURz47sOpym/nHlyk9tIiqtuhnkMNCx7gXuQNVG1lik56DaPopozNd?= =?us-ascii?Q?nZerO87DpSqzB6mvutqE5bZY8tKaVnk?= X-Microsoft-Antispam-Message-Info: zFSXe9oegf2MqigSmZR9ZnGAJ0uSykkS9XkBeqHQuNBw46RfMETaFupmn+vcDMN2bwvt2OOO9t2N+NvX7AV+bHHYqb0Oi9aLQXUx1jikiP/yKprqtt6mhwaC4qclgpx5/j2tsQmy2BS0SsOcSBDt2CzedAP6YhsYkAO3IyPhTAZmAw0oNpB7+UsO8whlUJ9/WNT7fQgXDa9yBvVscH5inaS55hJ1mSfpuITvt/DRZLNMyjC2sIhOo+n1mmBaQ5f1ebowBtcNeqwSnp3/AtUEWGg+8VULE/Q5F0bT2OoMSJU/Ixrv7rnerGR5ScqNekqHiDvy12ClvYJi9V5zEVU7CtcyslOBG4xbrL4myDThvKk= X-Microsoft-Exchange-Diagnostics: 1; AM0PR05MB4177; 6:7NovxOQjNJsqVthKRcD4jZKNfrIzQ+BP7k4YEZBWCPC/H6CqjNyZPs5ZSD1WXbRo1PNvMHqF2njyHrDgCBrzzfr/3RhMt92raE7jyw5Vst4f/DxBrsdM2T+hkwxpVa4delVnLQ2JoO2RHQcxez+MXqZwYs0utr4UKDmkNi4AdA6Y5xkIg3gQqt/IF4yPU9xFyiQJuHkWO34yvzhydvnGJI9HjEUKTG8Yu4+DEriGzbC96wt/S1doobNkyt6Skpx83fXoprGb9ju9pHnJzMVjGw6xtfwa3B5b6UJ5++ixcrZ3lurDAEfUQRnooqv8Bm4C95PD6Mpd0TN+8WJor/bS4NxShqxO98bVdLpddmNur5f2jzqAVeF2hjB1O42guN9QEQYwmgxwrDAI7mCiqYGeii43k6eI+QWppFF8epXBvRNqUqC/LRnsmwMWa3DNXRiIdS5pnDFxdiEzb+VapyuPzQ==; 5:HcbHuucvfGOwJXLN/xPONdt4gbCX08G5MCay2fvtjxOP5JFWYU2N2wOFoILaLRqzqfaqmI/mVjqT76vR3CzRHGF151AES/VQZG6htj68GTo7r1eg/cBajcnIQTkd8Kirll8M8oDrn1m15piVmF9P7UyGGA2VCvqQ82DK0dHIZeE=; 24:AbTPqTmRgx0UfwMXDroLQMIZNG3wE+qAavuXk+J6LABZeLBUeMGZtQMVbG11KoEYSei05lmckrQ19aXCxsxxC6Bf/AectVRHczTRIIoK2UA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM0PR05MB4177; 7:m/T7qyZNAQWcT7Hpq1/TVvjKDVtgdPWXiZGyAG0m8kLX5ZxWxeC6LqMH9Y8JIE/TAzynfiC0fdwzMoOyqfniRY+hg0fg1woq9qwboXkFTHT3IFB2ZtlMT6RtCUco7yG7IHVM+RTzDxpWpVjDisi3t4RslpiYXdxiu1cplEYrOv7C/tYhOKVYTVzCg05bjdEvuhI9i6upO3XnRXeZ+Fu+uDTPv2eUHRnTmNzalVnGAr4vUn8oYhnz/Cn/bNCJNhVQ X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2018 16:56:44.4249 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7129925c-acdf-438b-aad8-08d5dd182133 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4177 Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When running the test on soft devices, there's no mechanism to gratuitously start resolving the neighbor for remote tunnel endpoint. So instead of passively waiting, wait for the device to be up, and then probe the neighbor with a ping. Signed-off-by: Petr Machata --- tools/testing/selftests/net/forwarding/mirror_gre_changes.sh | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/tools/testing/selftests/net/forwarding/mirror_gre_changes.sh b/tools/testing/selftests/net/forwarding/mirror_gre_changes.sh index aa29d46186a8..135902aa8b11 100755 --- a/tools/testing/selftests/net/forwarding/mirror_gre_changes.sh +++ b/tools/testing/selftests/net/forwarding/mirror_gre_changes.sh @@ -122,15 +122,8 @@ test_span_gre_egress_up() # After setting the device up, wait for neighbor to get resolved so that # we can expect mirroring to work. ip link set dev $swp3 up - while true; do - ip neigh sh dev $swp3 $remote_ip nud reachable | - grep -q ^ - if [[ $? -ne 0 ]]; then - sleep 1 - else - break - fi - done + setup_wait_dev $swp3 + ping -c 1 -I $swp3 $remote_ip &>/dev/null quick_test_span_gre_dir $tundev ingress mirror_uninstall $swp1 ingress