kself test fail for "kci_test_bridge_parent_id"

Commit Message

ALOK TIWARI March 25, 2025, 7:11 p.m. UTC

Hi,


"kci_test_bridge_parent_id" test failed with error "as device can not be 
enslaved while up".

Here is Error log.
-------------------
 > ./rtnetlink.sh  -t kci_test_bridge_parent_id -v
COMMAND: ip link add name test-dummy0 type dummy
COMMAND: ip link set test-dummy0 up
COMMAND: modprobe -q netdevsim
COMMAND: ip link add name test-bond0 type bond mode 802.3ad
COMMAND: ip link set dev eni10np1 master test-bond0
     Error: Device can not be enslaved while up.
COMMAND: ip link set dev eni20np1 master test-bond0
     Error: Device can not be enslaved while up.
COMMAND: ip link add name test-br0 type bridge
COMMAND: ip link set dev test-bond0 master test-br0
FAIL: bridge_parent_id
-------------------

upstream commit ec4ffd100ffb ("Revert "net: rtnetlink: Enslave device 
before bringing it up""), suggest the following scenario!
$ ip link set dummy0 up
$ ip link set dummy0 master bond0 down

According to last commit, do we need to modify 
"kci_test_bridge_parent_id" test set to down.

Success log with modified test case
 > ./rtnetlink.sh  -t kci_test_bridge_parent_id -v
COMMAND: ip link add name test-dummy0 type dummy
COMMAND: ip link set test-dummy0 up
COMMAND: modprobe -q netdevsim
COMMAND: ip link add name test-bond0 type bond mode 802.3ad
COMMAND: ip link set dev eni10np1 master test-bond0 down
COMMAND: ip link set dev eni20np1 master test-bond0 down
COMMAND: ip link add name test-br0 type bridge
COMMAND: ip link set dev test-bond0 master test-br0
PASS: bridge_parent_id

Thanks,
Alok

Patch

--- a/tools/testing/selftests/net/rtnetlink.sh
+++ b/tools/testing/selftests/net/rtnetlink.sh
@@ -1129,8 +1129,8 @@  kci_test_bridge_parent_id()
         dev10=`ls ${sysfsnet}10/net/`
         dev20=`ls ${sysfsnet}20/net/`
         run_cmd ip link add name test-bond0 type bond mode 802.3ad
-       run_cmd ip link set dev $dev10 master test-bond0
-       run_cmd ip link set dev $dev20 master test-bond0
+       run_cmd ip link set dev $dev10 master test-bond0 down
+       run_cmd ip link set dev $dev20 master test-bond0 down
         run_cmd ip link add name test-br0 type bridge