From patchwork Mon Mar 31 16:50:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nam Cao X-Patchwork-Id: 14033807 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 898ED1DF748; Mon, 31 Mar 2025 16:50:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743439854; cv=none; b=Kz4h2k7BYpweH9rzHi/DXQi+55yVU6P6jkDK68wz7vO3Ji6wGsIXzinSSeaQRCHUGb8xE7bGKM6aio0VXkb5rGMSNWwTLglxJX1Y15+aYiBRNbb0nELin1K7k8E/rY2AVeggB6fubd2c6bu/r2noDttSRclwASArGqqeAph+rnk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743439854; c=relaxed/simple; bh=bgMwNkhBGnv8rP3ZdwMmJTU8/JPMOzHPhegnc9gemY8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=kxqnOeCly+o+h74NUcfENmx2EQPHEwjuFaSM0/LewGnQArL8aHz15IOroQqdp3D3uDHqBLnIxMwcTV4xiAYqY15OOLepqq0jiGXJt2ufBXr11uwjf1Puxv4UE1dDQ2FuLMhzGdPQgrqy7Bg/RyvAt4nDFDOHoGbEMFya+kxKtr8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=RQzOTIXI; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=NTq5m2PU; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="RQzOTIXI"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="NTq5m2PU" From: Nam Cao DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1743439849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CbpPGliuR2iTK+/0zgI72kw6GIkb/4OY3SUNCgGx+MI=; b=RQzOTIXIzsE34ANhyDzSXgAhNiZVpmtmNPt2sIWfc5UB5yQzsmcDv+EdXOMQdcIfkYT1ZT a1FJXNyNEwGq5vhOQEW23EBo3jYPfiGBw1yD30Go1EfzE44VzRR7WZ/1wlkblUTX1q51DA yv/L4J3wswnJLa6QGQIbv+vcZihXDUeX51CUKHfRhTnfRm0A2wrysbOc5tJMNLNAW2vm5e Wq0L0VOoMb2AMBBlIZFWmFOsQeioDHkuWDOd1pRkSwdNJndHqFlrIhNRBdWcVEwkLvo0JP Dlh5bGtWmzdzX3KZ3CgQB8wcJE3jsvTHXmmUtzwh0xGzk6RVRrhfdGqqEd8aKQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1743439849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CbpPGliuR2iTK+/0zgI72kw6GIkb/4OY3SUNCgGx+MI=; b=NTq5m2PU5/F6l9bLpli0Ajd211xsV/DSVnq7JQI9d5vSCMYaahUf2B8TPJa01fbOt7+4oW aehLwA7z9RP+DsDA== To: Christian Brauner Cc: Shuah Khan , John Ogness , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Nam Cao Subject: [PATCH 1/3] selftests: coredump: Properly initialize pointer Date: Mon, 31 Mar 2025 18:50:42 +0200 Message-Id: In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The buffer pointer "line" is not initialized. This pointer is passed to getline(). It can still work if the stack is zero-initialized, because getline() can work with a NULL pointer as buffer. But this is obviously broken. This bug shows up while running the test on a riscv64 machine. Fix it by properly initializing the pointer. Fixes: 15858da53542 ("selftests: coredump: Add stackdump test") Signed-off-by: Nam Cao --- tools/testing/selftests/coredump/stackdump_test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/testing/selftests/coredump/stackdump_test.c b/tools/testing/selftests/coredump/stackdump_test.c index 137b2364a082..1dc54e128586 100644 --- a/tools/testing/selftests/coredump/stackdump_test.c +++ b/tools/testing/selftests/coredump/stackdump_test.c @@ -100,6 +100,8 @@ TEST_F(coredump, stackdump) FILE *file; pid_t pid; + line = NULL; + /* * Step 1: Setup core_pattern so that the stackdump script is executed when the child * process crashes