| Message ID | d1a101897be9ee31b11f13ec61384f004dafd40c.1568116761.git.esyr@redhat.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Update clone3 self-tests | expand |
On 9/10/19 6:03 AM, Eugene Syromiatnikov wrote: > clone3() is available on most architectures, so there's no reason to > restrict the respective self-tests to x86_64. > Is it missing on any? Please key off of the return value and exit with skip if unsupported. > * tools/testing/selftests/clone3/Makefile (TEST_GEN_PROGS): Set always, > not only ifeq ($(ARCH),x86_64). > Please - no file names in commit log. > Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com> > --- > tools/testing/selftests/clone3/Makefile | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/clone3/Makefile b/tools/testing/selftests/clone3/Makefile > index 4efcf45..faa069c 100644 > --- a/tools/testing/selftests/clone3/Makefile > +++ b/tools/testing/selftests/clone3/Makefile > @@ -4,8 +4,6 @@ ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/i386/) > > CFLAGS += -I../../../../usr/include/ > > -ifeq ($(ARCH),x86_64) > - TEST_GEN_PROGS := clone3 clone3_set_tid > -endif > +TEST_GEN_PROGS := clone3 clone3_set_tid > > include ../lib.mk > This is fine. Where is the code to handle unsupported case? thanks, -- Shuah
diff --git a/tools/testing/selftests/clone3/Makefile b/tools/testing/selftests/clone3/Makefile index 4efcf45..faa069c 100644 --- a/tools/testing/selftests/clone3/Makefile +++ b/tools/testing/selftests/clone3/Makefile @@ -4,8 +4,6 @@ ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/i386/) CFLAGS += -I../../../../usr/include/ -ifeq ($(ARCH),x86_64) - TEST_GEN_PROGS := clone3 clone3_set_tid -endif +TEST_GEN_PROGS := clone3 clone3_set_tid include ../lib.mk
clone3() is available on most architectures, so there's no reason to restrict the respective self-tests to x86_64. * tools/testing/selftests/clone3/Makefile (TEST_GEN_PROGS): Set always, not only ifeq ($(ARCH),x86_64). Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com> --- tools/testing/selftests/clone3/Makefile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)