| Message ID | ea8458462b876ee445173e3effb535fd126137ed.1716446893.git.tanggeliang@kylinos.cn (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 49784c7979321c49a8055f5c588d24c34a8c55fc |
| Headers | show |
| Series | fixes for test_sockmap | expand |
Geliang Tang wrote: > From: Geliang Tang <tanggeliang@kylinos.cn> > > bpf_map_lookup_elem is invoked in bpf_prog3() already, no need to invoke > it again. This patch drops it. > > Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn> > --- > tools/testing/selftests/bpf/progs/test_sockmap_kern.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/tools/testing/selftests/bpf/progs/test_sockmap_kern.h b/tools/testing/selftests/bpf/progs/test_sockmap_kern.h > index 99d2ea9fb658..2399958991e7 100644 > --- a/tools/testing/selftests/bpf/progs/test_sockmap_kern.h > +++ b/tools/testing/selftests/bpf/progs/test_sockmap_kern.h > @@ -177,9 +177,6 @@ int bpf_prog3(struct __sk_buff *skb) > return bpf_sk_redirect_hash(skb, &tls_sock_map, &ret, flags); > #endif > } > - f = bpf_map_lookup_elem(&sock_skb_opts, &one); > - if (f && *f) > - ret = SK_DROP; > err = bpf_skb_adjust_room(skb, 4, 0, 0); > if (err) > return SK_DROP; > -- > 2.43.0 > Acked-by: John Fastabend <john.fastabend@gmail.com>
diff --git a/tools/testing/selftests/bpf/progs/test_sockmap_kern.h b/tools/testing/selftests/bpf/progs/test_sockmap_kern.h index 99d2ea9fb658..2399958991e7 100644 --- a/tools/testing/selftests/bpf/progs/test_sockmap_kern.h +++ b/tools/testing/selftests/bpf/progs/test_sockmap_kern.h @@ -177,9 +177,6 @@ int bpf_prog3(struct __sk_buff *skb) return bpf_sk_redirect_hash(skb, &tls_sock_map, &ret, flags); #endif } - f = bpf_map_lookup_elem(&sock_skb_opts, &one); - if (f && *f) - ret = SK_DROP; err = bpf_skb_adjust_room(skb, 4, 0, 0); if (err) return SK_DROP;