| Message ID | f7b1e9d468224cbc136d304362315499fe39848f.1707298927.git.pabeni@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 876e32473d1dd61cb58ece9965c3b3ea3ab307ab |
| Headers | show |
| Series | [net-next] selftests: net: include forwarding lib | expand |
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Wed, 7 Feb 2024 10:42:45 +0100 you wrote: > The altnames test uses the forwarding/lib.sh and that dependency > currently causes failures when running the test after install: > > make -C tools/testing/selftests/ TARGETS=net install > ./tools/testing/selftests/kselftest_install/run_kselftest.sh \ > -t net:altnames.sh > # ... > # ./altnames.sh: line 8: ./forwarding/lib.sh: No such file or directory > # RTNETLINK answers: Operation not permitted > # ./altnames.sh: line 73: tests_run: command not found > # ./altnames.sh: line 65: pre_cleanup: command not found > > [...] Here is the summary with links: - [net-next] selftests: net: include forwarding lib https://git.kernel.org/netdev/net-next/c/876e32473d1d You are awesome, thank you!
diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile index 211753756bde..7b6918d5f4af 100644 --- a/tools/testing/selftests/net/Makefile +++ b/tools/testing/selftests/net/Makefile @@ -97,6 +97,8 @@ TEST_PROGS += vlan_hw_filter.sh TEST_FILES := settings TEST_FILES += in_netns.sh lib.sh net_helper.sh setup_loopback.sh setup_veth.sh +TEST_INCLUDES := forwarding/lib.sh + include ../lib.mk $(OUTPUT)/reuseport_bpf_numa: LDLIBS += -lnuma
The altnames test uses the forwarding/lib.sh and that dependency currently causes failures when running the test after install: make -C tools/testing/selftests/ TARGETS=net install ./tools/testing/selftests/kselftest_install/run_kselftest.sh \ -t net:altnames.sh # ... # ./altnames.sh: line 8: ./forwarding/lib.sh: No such file or directory # RTNETLINK answers: Operation not permitted # ./altnames.sh: line 73: tests_run: command not found # ./altnames.sh: line 65: pre_cleanup: command not found Address the issue leveraging the TEST_INCLUDES infrastructure provided by commit 2a0683be5b4c ("selftests: Introduce Makefile variable to list shared bash scripts") Signed-off-by: Paolo Abeni <pabeni@redhat.com> --- tools/testing/selftests/net/Makefile | 2 ++ 1 file changed, 2 insertions(+)