From patchwork Mon Jan 31 15:42:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guillaume Nault X-Patchwork-Id: 12730794 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F139BC433FE for ; Mon, 31 Jan 2022 15:42:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379783AbiAaPmK (ORCPT ); Mon, 31 Jan 2022 10:42:10 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:23542 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350284AbiAaPmK (ORCPT ); Mon, 31 Jan 2022 10:42:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643643729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hkxchTylyBIw36KxB2bjQj4NjTJ8gEN7NWBvja/ptEI=; b=OtgrpUGvsyy2TZRhrjCjDfrMqRL3pJE9NqjoBlqkwIosAY+5OPsm3AOUqkcZ/2cCD+FCm6 0g9EsnFuSn7jds4Sj4r5Zf1w0qmIZ7Dk86CukO6jaWzuewCsZ/jSyVtVr06ZEukX25IMf3 hngVqQaopH5dvbaVKT0lfHzD+lKCnM0= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-541-y1rtsdR2MDuhadJgqkeJZw-1; Mon, 31 Jan 2022 10:42:07 -0500 X-MC-Unique: y1rtsdR2MDuhadJgqkeJZw-1 Received: by mail-wr1-f70.google.com with SMTP id x4-20020adfbb44000000b001d83e815683so4955474wrg.8 for ; Mon, 31 Jan 2022 07:42:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hkxchTylyBIw36KxB2bjQj4NjTJ8gEN7NWBvja/ptEI=; b=EgP1kIrWRau95J5tkARuDNwoqn+FnhtieYKQr4qz6g4MYsGPWiQKB1iCP0rnpPyBfB C5vejaAPfuNPc3meDqgLHdrHn+WT9NHsvLLmoiKqHbuyX1YkiCw2uoQPMhzH8OfOb7On 9eaJNfkLS+tlJNbxlA0D65CTAqRw7IpEnvdxdAr5Trv2pZr3Q+tZyDuvsaN/JXn286iZ JqEbP7FBGq5flfuu5oaeFQVzYIP0aZi6h8EjaeFCmGDetRV+3vAYeC67v5LH3UeZHi+z WWpg3Nabpj/dOKWjB59X8nUDFp0FV1P6WMNf/L2OcizMG3qzj1tdMaK9HruFHgRU4L4z hZeg== X-Gm-Message-State: AOAM5304EToDRkM25TUx/Lm+X/DetwA8mCl/4q+eczkiy+2oyaVddTSH PGvJ/UzQYuFcWAZQA3bA6T677/wKOkbafdJz2DyMEPgV6PkniANv9ZP/efjgG4ouT2R69QVlR+8 y6Lrk9NcPOgCdyOHnNJJyhIgO+oaT X-Received: by 2002:adf:9dc6:: with SMTP id q6mr17692038wre.679.1643643726601; Mon, 31 Jan 2022 07:42:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJy1DwCI3Fw2wTecxht4WC3IQ8a5vpBieNVHkhHesxDAYIX779C8wLRFnFWyOh+KqnTZ7JI11A== X-Received: by 2002:adf:9dc6:: with SMTP id q6mr17692030wre.679.1643643726417; Mon, 31 Jan 2022 07:42:06 -0800 (PST) Received: from pc-4.home (2a01cb058918ce00dd1a5a4f9908f2d5.ipv6.abo.wanadoo.fr. [2a01:cb05:8918:ce00:dd1a:5a4f:9908:f2d5]) by smtp.gmail.com with ESMTPSA id i9sm14449262wry.32.2022.01.31.07.42.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 07:42:06 -0800 (PST) Date: Mon, 31 Jan 2022 16:42:04 +0100 From: Guillaume Nault To: David Miller , Jakub Kicinski Cc: netdev@vger.kernel.org, Shuah Khan , linux-kselftest@vger.kernel.org, Roopa Prabhu Subject: [PATCH net-next 2/4] selftests: fib rule: Drop erroneous TABLE variable Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org The fib_rule6_del_by_pref() and fib_rule4_del_by_pref() functions use an uninitialised $TABLE variable. They should use $RTABLE instead. This doesn't alter the result of the test, as it just makes the grep command less specific (but since the script always uses the same table number, that doesn't really matter). Let's fix it anyway and, while there, specify the filtering parameters directly in 'ip -X rule show' to avoid the extra grep command entirely. Signed-off-by: Guillaume Nault --- tools/testing/selftests/net/fib_rule_tests.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/net/fib_rule_tests.sh b/tools/testing/selftests/net/fib_rule_tests.sh index f04f337dd7c6..012f9385d68c 100755 --- a/tools/testing/selftests/net/fib_rule_tests.sh +++ b/tools/testing/selftests/net/fib_rule_tests.sh @@ -96,7 +96,7 @@ fib_rule6_del() fib_rule6_del_by_pref() { - pref=$($IP -6 rule show | grep "$1 lookup $TABLE" | cut -d ":" -f 1) + pref=$($IP -6 rule show $1 table $RTABLE | cut -d ":" -f 1) $IP -6 rule del pref $pref } @@ -168,7 +168,7 @@ fib_rule4_del() fib_rule4_del_by_pref() { - pref=$($IP rule show | grep "$1 lookup $TABLE" | cut -d ":" -f 1) + pref=$($IP rule show $1 table $RTABLE | cut -d ":" -f 1) $IP rule del pref $pref }