From patchwork Thu Sep 6 21:07:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brad Love X-Patchwork-Id: 10591069 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6224E14BD for ; Thu, 6 Sep 2018 21:08:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AAAB92A410 for ; Thu, 6 Sep 2018 21:08:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9EE602A432; Thu, 6 Sep 2018 21:08:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4D21E2A410 for ; Thu, 6 Sep 2018 21:08:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727659AbeIGBpT (ORCPT ); Thu, 6 Sep 2018 21:45:19 -0400 Received: from sub5.mail.dreamhost.com ([208.113.200.129]:57688 "EHLO homiemail-a119.g.dreamhost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726505AbeIGBpT (ORCPT ); Thu, 6 Sep 2018 21:45:19 -0400 Received: from homiemail-a119.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a119.g.dreamhost.com (Postfix) with ESMTP id 896E36000D730; Thu, 6 Sep 2018 14:08:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=nextdimension.cc; h=from :to:cc:subject:date:message-id; s=nextdimension.cc; bh=+kjieoVaY 7kJkHM0oHZvf7ykbF0=; b=fmfMv0ScKnygvmvkcVU45gwpizp1YKQyZm+ri6Ma0 WyQEPPF7/aA/xU1xIKlNVe4kJtOuyTW93rZdMqWCn4a8ybWNUivPVxCxwHLP+mDu HcnGSxtMuqTsyvd4OM+mh/hay5Iq4ophme8QXFQmV67ukZVXVnRlhYk/lzp5FVrC 2A= Received: from localhost.localdomain (66-90-189-166.dyn.grandenetworks.net [66.90.189.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: brad@nextdimension.ws) by homiemail-a119.g.dreamhost.com (Postfix) with ESMTPSA id 422A16000D72A; Thu, 6 Sep 2018 14:08:02 -0700 (PDT) From: Brad Love To: linux-media@vger.kernel.org, mkrufky@linuxtv.org Cc: Brad Love Subject: [PATCH 0/2] au0828 Oops fix and message correction Date: Thu, 6 Sep 2018 16:07:47 -0500 Message-Id: <1536268069-25435-1-git-send-email-brad@nextdimension.cc> X-Mailer: git-send-email 2.7.4 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP An end user reported oopsing on connection of multiple Hauppauge 950Q devices. The oops is related to analog setup failing during usb probe for a device. If analog setup fails then dev is kfree'd and then drivers usb disconnect function is called, which requires valid dev. Hence, immediate oops. Patch 2 is just error message correction around the failure spot. An invalid function name is corrected. Brad Love (2): au0828: cannot kfree dev before usb disconnect au0828: Fix incorrect error messages drivers/media/usb/au0828/au0828-core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)