From patchwork Thu Jun 10 21:42:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 12314025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 739C0C48BD1 for ; Thu, 10 Jun 2021 21:44:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 534206141F for ; Thu, 10 Jun 2021 21:44:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230374AbhFJVqs (ORCPT ); Thu, 10 Jun 2021 17:46:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:53862 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229941AbhFJVqs (ORCPT ); Thu, 10 Jun 2021 17:46:48 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C5305613CA; Thu, 10 Jun 2021 21:44:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623361491; bh=ZWd349hON24nbsKTW/zSfU0MgSTsBzl5Ei1e0dljQpc=; h=From:To:Cc:Subject:Date:From; b=XrdweSX5RuIhdapW4UDwutKy6U8reEUNfOVi/K8VoNtI3fANRcna+OwGH7p34Nyrw NaVpVIUt8XQcjci2sXuS9wh0dKC0IeqZNPV3eYIjesCmGhHWGhaFmSvgPUISHlu0V4 auCaJDracLWjsVIzeo0l/a2sHqw9ramXcR8iMPOSOwmBIOnBRB5i3jjaL9IuFRb8HJ WdrsiBw4VWUp3nmahYkWApbvgkLWRaTMT+L0FR/7ZwvOP2vW7sBNb8JYSNb4zbcbC3 v2y/GTQOjJz12hs/VPZh659Se9MXW9BLOaD+Gv81UBMISwY6cnjJ2tWhkWwyktPbFy U5iJcO7e51QLA== From: Arnd Bergmann To: Hans Verkuil , Mauro Carvalho Chehab Cc: Arnd Bergmann , "Lad, Prabhakar" , Eduardo Valentin , Sakari Ailus , Greg Kroah-Hartman , Vaibhav Gupta , Liu Shixin , Laurent Pinchart , Jacopo Mondi , Andy Shevchenko , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH v2 0/7] media: v4l2: compat ioctl fixes Date: Thu, 10 Jun 2021 23:42:58 +0200 Message-Id: <20210610214305.4170835-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Arnd Bergmann There was a report from Syzbot a while ago that I tried fixed earlier, but my fix did not get picked up because of a merge conflict with another patch I had in my tree. I finally managed to take a close enough look at the merge conflict to figure out that the subdev driver handling for VIDIOC_DQEVENT_TIME32 was wrong in all combinations of the patches and just needs to be removed. In the process I also came across a couple of other issues, so the series has now grown to seven patches. I have done randconfig build testing and found no compile time issues, but the driver specific patches have not been tested so far. Arnd Link: https://patchwork.linuxtv.org/project/linux-media/patch/20210318134334.2933141-1-arnd@kernel.org/ Arnd Bergmann (7): media: v4l2-core: ignore native time32 ioctls on 64-bit media: v4l2-core: explicitly clear ioctl input data media: subdev: remove VIDIOC_DQEVENT_TIME32 handling media: v4l2-core: return -ENODEV from ioctl when not registered media: atomisp: remove compat_ioctl32 code media: subdev: fix compat_ioctl32 media: subdev: disallow ioctl for saa6588/davinci drivers/media/i2c/adv7842.c | 3 + drivers/media/i2c/saa6588.c | 4 +- drivers/media/pci/bt8xx/bttv-driver.c | 6 +- drivers/media/pci/saa7134/saa7134-video.c | 6 +- drivers/media/platform/davinci/vpbe_display.c | 2 +- drivers/media/platform/davinci/vpbe_venc.c | 6 +- drivers/media/radio/si4713/si4713.c | 3 + drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 3 + drivers/media/v4l2-core/v4l2-ioctl.c | 57 +- drivers/media/v4l2-core/v4l2-subdev.c | 43 +- drivers/staging/media/atomisp/Makefile | 1 - drivers/staging/media/atomisp/TODO | 5 + .../atomisp/pci/atomisp_compat_ioctl32.c | 1202 ----------------- .../staging/media/atomisp/pci/atomisp_fops.c | 8 +- include/media/v4l2-subdev.h | 7 +- 15 files changed, 81 insertions(+), 1275 deletions(-) delete mode 100644 drivers/staging/media/atomisp/pci/atomisp_compat_ioctl32.c