mbox series

[v4,00/15] Support OVTI7251 on Microsoft Surface line

Message ID 20220505230402.449643-1-djrscally@gmail.com (mailing list archive)
Headers show
Series Support OVTI7251 on Microsoft Surface line | expand

Message

Daniel Scally May 5, 2022, 11:03 p.m. UTC
Hello all

This series extends the OV7251 driver so it's functional on the
Microsoft Surface line of laptops, where it's used as the IR
camera for face login. The camera sensor is connected to a CIO2
device which packs the 10-bit greyscale data into 25 pixels per 32
bytes similar to the IPU3 formats for Bayer data, so I also added
a new format to describe that and added it to the ipu3-cio2 driver's
list of supported formats. 

Series-level changes:

	- None

Thanks
Dan
Daniel Scally (15):
  media: uapi: Add IPU3 packed Y10 format
  media: ipu3-cio2: Add support for V4L2_PIX_FMT_IPU3_Y10
  media: i2c: Add acpi support to ov7251
  media: i2c: Provide ov7251_check_hwcfg()
  media: i2c: Remove per-mode frequencies from ov7251
  media: i2c: Add ov7251_pll_configure()
  media: i2c: Add support for new frequencies to ov7251
  media: i2c: Add ov7251_detect_chip()
  media: i2c: Add pm_runtime support to ov7251
  media: i2c: Remove .s_power() from ov7251
  media: ipu3-cio2: Add INT347E to cio2-bridge
  media: i2c: Extend .get_selection() for ov7251
  media: i2c: add ov7251_init_ctrls()
  media: i2c: Add hblank control to ov7251
  media: i2c: Add vblank control to ov7251 driver

 .../media/v4l/pixfmt-yuv-luma.rst             |  14 +-
 drivers/media/i2c/ov7251.c                    | 749 +++++++++++++-----
 drivers/media/pci/intel/ipu3/cio2-bridge.c    |   2 +
 drivers/media/pci/intel/ipu3/ipu3-cio2-main.c |   5 +
 drivers/media/v4l2-core/v4l2-ioctl.c          |   1 +
 include/uapi/linux/videodev2.h                |   3 +-
 6 files changed, 553 insertions(+), 221 deletions(-)

Comments

Andy Shevchenko May 6, 2022, 10:37 p.m. UTC | #1
On Fri, May 06, 2022 at 12:03:47AM +0100, Daniel Scally wrote:
> Hello all
> 
> This series extends the OV7251 driver so it's functional on the
> Microsoft Surface line of laptops, where it's used as the IR
> camera for face login. The camera sensor is connected to a CIO2
> device which packs the 10-bit greyscale data into 25 pixels per 32
> bytes similar to the IPU3 formats for Bayer data, so I also added
> a new format to describe that and added it to the ipu3-cio2 driver's
> list of supported formats. 

Good to me
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

AFAIU the __be16 and related stuff you are planning to update later on,
correct?

> Series-level changes:
> 
> 	- None
> 
> Thanks
> Dan
> Daniel Scally (15):
>   media: uapi: Add IPU3 packed Y10 format
>   media: ipu3-cio2: Add support for V4L2_PIX_FMT_IPU3_Y10
>   media: i2c: Add acpi support to ov7251
>   media: i2c: Provide ov7251_check_hwcfg()
>   media: i2c: Remove per-mode frequencies from ov7251
>   media: i2c: Add ov7251_pll_configure()
>   media: i2c: Add support for new frequencies to ov7251
>   media: i2c: Add ov7251_detect_chip()
>   media: i2c: Add pm_runtime support to ov7251
>   media: i2c: Remove .s_power() from ov7251
>   media: ipu3-cio2: Add INT347E to cio2-bridge
>   media: i2c: Extend .get_selection() for ov7251
>   media: i2c: add ov7251_init_ctrls()
>   media: i2c: Add hblank control to ov7251
>   media: i2c: Add vblank control to ov7251 driver
> 
>  .../media/v4l/pixfmt-yuv-luma.rst             |  14 +-
>  drivers/media/i2c/ov7251.c                    | 749 +++++++++++++-----
>  drivers/media/pci/intel/ipu3/cio2-bridge.c    |   2 +
>  drivers/media/pci/intel/ipu3/ipu3-cio2-main.c |   5 +
>  drivers/media/v4l2-core/v4l2-ioctl.c          |   1 +
>  include/uapi/linux/videodev2.h                |   3 +-
>  6 files changed, 553 insertions(+), 221 deletions(-)
> 
> -- 
> 2.25.1
>
Daniel Scally May 6, 2022, 10:45 p.m. UTC | #2
On 06/05/2022 23:37, Andy Shevchenko wrote:
> On Fri, May 06, 2022 at 12:03:47AM +0100, Daniel Scally wrote:
>> Hello all
>>
>> This series extends the OV7251 driver so it's functional on the
>> Microsoft Surface line of laptops, where it's used as the IR
>> camera for face login. The camera sensor is connected to a CIO2
>> device which packs the 10-bit greyscale data into 25 pixels per 32
>> bytes similar to the IPU3 formats for Bayer data, so I also added
>> a new format to describe that and added it to the ipu3-cio2 driver's
>> list of supported formats. 
> Good to me
> Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>


Thank you!

>
> AFAIU the __be16 and related stuff you are planning to update later on,
> correct?


Yep - I'm trying to get the IR LED to work reliably when the camera is
streaming which needs a couple more changes to this driver, so I can
include it in that series.

>
>> Series-level changes:
>>
>> 	- None
>>
>> Thanks
>> Dan
>> Daniel Scally (15):
>>   media: uapi: Add IPU3 packed Y10 format
>>   media: ipu3-cio2: Add support for V4L2_PIX_FMT_IPU3_Y10
>>   media: i2c: Add acpi support to ov7251
>>   media: i2c: Provide ov7251_check_hwcfg()
>>   media: i2c: Remove per-mode frequencies from ov7251
>>   media: i2c: Add ov7251_pll_configure()
>>   media: i2c: Add support for new frequencies to ov7251
>>   media: i2c: Add ov7251_detect_chip()
>>   media: i2c: Add pm_runtime support to ov7251
>>   media: i2c: Remove .s_power() from ov7251
>>   media: ipu3-cio2: Add INT347E to cio2-bridge
>>   media: i2c: Extend .get_selection() for ov7251
>>   media: i2c: add ov7251_init_ctrls()
>>   media: i2c: Add hblank control to ov7251
>>   media: i2c: Add vblank control to ov7251 driver
>>
>>  .../media/v4l/pixfmt-yuv-luma.rst             |  14 +-
>>  drivers/media/i2c/ov7251.c                    | 749 +++++++++++++-----
>>  drivers/media/pci/intel/ipu3/cio2-bridge.c    |   2 +
>>  drivers/media/pci/intel/ipu3/ipu3-cio2-main.c |   5 +
>>  drivers/media/v4l2-core/v4l2-ioctl.c          |   1 +
>>  include/uapi/linux/videodev2.h                |   3 +-
>>  6 files changed, 553 insertions(+), 221 deletions(-)
>>
>> -- 
>> 2.25.1
>>