[v5,0/2] media: i2c: Add driver for OmniVision OV8858

Message

Jacopo Mondi Jan. 16, 2023, 3:44 p.m. UTC

Hello,
  this is a new version of Nicholas' first submission available at
https://lore.kernel.org/all/[e-mail]/

This is a re-write of the previous version so I've restarted numeration from 0
even if in this version I have not changed the register tables.

Functionally the most notable difference is the addition of support for binned
mode in 4 data lanes mode.

There is more space for optimization on top of this series, in example the
register tables can be reworked to share more common settings between modes. I
have started the effort, but as it is a tedious and error-prone work I would
rather have this first version merged and the iterate on top. Programming of the
analog crop rectangle and output size could also be made parametric, but the
current modes have a few undocumented registers and I didn't feel like biting
the bullet and see if the can be safely removed or not.

Also, the BSP driver mentions a "not well supported" R1A version of the chip.
I would be in favour of removing it if no one oppose.

Images are still rather "dark" when tested with libcamera but preview is working
as expected in both modes (full res and half-res binned mode) and with 2 and 4
data lanes.

Nicholas could you let me know if things are fine with you here ?

v4 -> v5:
- Address Sakari's comments
 - Remove macros for ARRAY_SIZE
 - Refuse 4 lanes in R1A mode
 - Remove clk_set_rate
 - Fetch the i2c client from the subdev
 - Make pixel_rate variable local
 - Support V4L2_SUBDEV_FL_HAS_EVENTS

v3 -> v4:
- s/ov8858_read_reg/ov8858_read
- correct autosuspend sequence in probe
- added tags

v2 -> v3:
- Address Laurent's comments; most significant changes
  - Use v4l2_subdev_state everywhere and drop cur_mode
  - Simplify s_stream
  - Re-sort functions definition
  - Write analogue and digital gain as 16 bits registers
  - put fwnode in error path and remove function

v1 -> v2:
- Unified and simplified modes
- Adjust blanking values to match FPS
- Address Laurent's comment:
  - rework reg_write() function
  - move to subdev state
  - cosmetic change

Jacopo Mondi (1):
  dt-bindings: media: Add OmniVision OV8858

Nicholas Roth (1):
  media: i2c: Add driver for OmniVision OV8858

 .../bindings/media/i2c/ovti,ov8858.yaml       |  106 +
 MAINTAINERS                                   |    9 +
 drivers/media/i2c/Kconfig                     |   13 +
 drivers/media/i2c/Makefile                    |    1 +
 drivers/media/i2c/ov8858.c                    | 2001 +++++++++++++++++
 5 files changed, 2130 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov8858.yaml
 create mode 100644 drivers/media/i2c/ov8858.c

--
2.39.0