| Message ID | 20230727154108.308320-1-umang.jain@ideasonboard.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | media: i2c: imx519: Support for Sony IMX519 sensor | expand |
Hi Umang, Quoting Umang Jain (2023-07-27 16:41:06) > Series adds driver support for Sony IMX519 sensor. > > Lee, can do add S-o-B tags please to these patches > since I've updated your email IDs at various places from > info@ to lee.jackson@. Can you dig and find out what your start point was here please? This series should already be numbered at least v6, there are 5 previous postings. The most recent of which was already Signed off by 'lee.jackson@arducam.com' So that makes me weary that v5 was not used as the start point for this refresh. Previous versions are identifiable here: - https://patchwork.linuxtv.org/project/linux-media/list/?series=&submitter=&state=*&q=imx519&archive=both&delegate= Could you check through any previous review comments and make sure they have all been addressed too please? It would be useful if the cover letter or patch described a changelog from the previous version too to identify what has been updated. I see the kernel test robot reported failures based on missing dependencies. It's helpful to list any dependency information here in the cover letter too. -- Kieran > > Thanks! > > Lee Jackson (2): > media: dt-bindings: imx519: Add IMX519 DT bindings > media: i2c: imx519: Support for the Sony IMX519 sensor > > .../bindings/media/i2c/sony,imx519.yaml | 113 + > MAINTAINERS | 8 + > drivers/media/i2c/Kconfig | 11 + > drivers/media/i2c/Makefile | 1 + > drivers/media/i2c/imx519.c | 2134 +++++++++++++++++ > 5 files changed, 2267 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml > create mode 100644 drivers/media/i2c/imx519.c > > -- > 2.39.1 >
On Fri, Jul 28, 2023 at 09:52:08AM +0100, Kieran Bingham wrote: > Hi Umang, > > Quoting Umang Jain (2023-07-27 16:41:06) > > Series adds driver support for Sony IMX519 sensor. > > > > Lee, can do add S-o-B tags please to these patches > > since I've updated your email IDs at various places from > > info@ to lee.jackson@. > > Can you dig and find out what your start point was here please? > > This series should already be numbered at least v6, there are 5 previous > postings. The most recent of which was already Signed off by > 'lee.jackson@arducam.com' So that makes me weary that v5 was not used as > the start point for this refresh. > > Previous versions are identifiable here: > > - https://patchwork.linuxtv.org/project/linux-media/list/?series=&submitter=&state=*&q=imx519&archive=both&delegate= > > Could you check through any previous review comments and make sure they > have all been addressed too please? > > It would be useful if the cover letter or patch described a changelog > from the previous version too to identify what has been updated. I second this. A summary of the major changes in the cover letter plus a detailed changelog in each patch is invaluable for review. > I see the kernel test robot reported failures based on missing > dependencies. > > It's helpful to list any dependency information here in the cover > letter too. You can use the --base argument to git-format-patch to record the base commit, and point in the cover letter to a public branch where the series can be found. > > Thanks! > > > > Lee Jackson (2): > > media: dt-bindings: imx519: Add IMX519 DT bindings > > media: i2c: imx519: Support for the Sony IMX519 sensor > > > > .../bindings/media/i2c/sony,imx519.yaml | 113 + > > MAINTAINERS | 8 + > > drivers/media/i2c/Kconfig | 11 + > > drivers/media/i2c/Makefile | 1 + > > drivers/media/i2c/imx519.c | 2134 +++++++++++++++++ > > 5 files changed, 2267 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml > > create mode 100644 drivers/media/i2c/imx519.c