[v2,00/14] media: rkisp1: Various cleanups and fixes

Message

Laurent Pinchart Sept. 25, 2023, 12:40 a.m. UTC

Hello,

This patch series performs various cleanups in the rkisp1 driver and
fixes two issues.

The series starts in 01/14 with an update to MAINTAINERS to add myself
as a co-maintainer for the driver. I have authored most of the changes
to the rkisp1 driver in the recent past and plan to keep improving the
code base (including upstreaming i.MX8MP support), and I'd like to be
CC'ed on patches.

I have named the series v2 as it contains the second version of the
conversion to the V4L2 subdev active state in patches 02/14 to 04/14.
The remaining of the series is new. Patches 05/15 and 06/14 are two
small cleanups, and patch 07/14 is the first fix, for the line stride
calculation. Patches 08/14 to 13/14 continue with small cleanups, and
patch 14/14 finally fixes the resizer configuration when upscaling
vertically by a factor of 2.

I have successfully tested this series on a RK339 (Rock Pi 4), as well
as an i.MX8MP (Debix) with a few additional patches.

Laurent Pinchart (14):
  MAINTAINERS: Add co-maintainer for the rkisp1 driver
  media: rkisp1: resizer: Use V4L2 subdev active state
  media: rkisp1: isp: Use V4L2 subdev active state
  media: rkisp1: csi: Use V4L2 subdev active state
  media: rkisp1: Convert hex constants to lowercase
  media: rkisp1: Constify rkisp1_v12_params_ops
  media: rkisp1: Fix line stride calculation
  media: rkisp1: Remove dual crop control register from config structure
  media: rkisp1: Program RKISP1_CIF_MI_SP_Y_PIC_SIZE register
  media: rkisp1: resizer: Constify argument and local variables
  media: rkisp1: resizer: Use v4l2_area instead of v4l2_rect to store
    size
  media: rkisp1: resizer: Drop unneeded local variable
  media: rkisp1: resizer: Improve debug message when configuring resizer
  media: rkisp1: resizer: Fix resizer disable check when starting stream

 MAINTAINERS                                   |   1 +
 .../platform/rockchip/rkisp1/rkisp1-capture.c |  24 +-
 .../platform/rockchip/rkisp1/rkisp1-common.h  |  18 -
 .../platform/rockchip/rkisp1/rkisp1-csi.c     | 107 +--
 .../platform/rockchip/rkisp1/rkisp1-isp.c     | 263 +++-----
 .../platform/rockchip/rkisp1/rkisp1-params.c  |   4 +-
 .../platform/rockchip/rkisp1/rkisp1-regs.h    | 618 +++++++++---------
 .../platform/rockchip/rkisp1/rkisp1-resizer.c | 255 +++-----
 8 files changed, 564 insertions(+), 726 deletions(-)