[v2,0/9] media: v4l2-subdev: Rename pad config 'try_*' fields

Message

Laurent Pinchart Oct. 27, 2023, 9:16 a.m. UTC

Hello,

This series is the result of me getting bothered by the following note
in the documentation of the v4l2_subdev_pad_config structure:

 * Note: This struct is also used in active state, and the 'try' prefix is
 * historical and to be removed.

So I decided to drop the prefix.

Patches 1/9 and 2/9 are small preliminary cleanups that have been posted
separately to the list. I have included them in this v2 as the other
patches depend on them.

Patch 3/9 drops usage of the pad config 'try_*' fields from the
microchip-isc driver by dropping dead code. It has also been posted
separately to the list, and is a dependency for 9/9.

Patches 4/9 to 8/9 then replace direct usage of the fields in drivers with
the corresponding accessor functions. There was a relatively large
number of them in sensor drivers (in 8/9), but more worryingly, the
atmel-isi (4/9) and tegra-video (7/9) should really not have messed up
with creating a v4l2_subdev_pad_config structure manually. It would be
nice if the maintainers of those drivers could address the issue.

Finally, patch 9/9 renames the fields, which becomes easy after
addressing all the drivers.

The patches have been compile-tested only.

The series is based on "[PATCH v4 0/9] Unify sub-device state access
functions" ([1]).

[1] https://lore.kernel.org/linux-media/[e-mail]

Laurent Pinchart (9):
  media: v4l2-subdev: Fix indentation in v4l2-subdev.h
  media: v4l2-subdev: Drop outdated comment for v4l2_subdev_pad_config
  media: microchip-isc: Remove dead code in pipeline validation
  media: atmel-isi: Use accessors for pad config 'try_*' fields
  media: atmel-isc: Use accessors for pad config 'try_*' fields
  media: atomisp: Use accessors for pad config 'try_*' fields
  media: tegra-video: Use accessors for pad config 'try_*' fields
  media: i2c: Use accessors for pad config 'try_*' fields
  media: v4l2-subdev: Rename pad config 'try_*' fields

 drivers/media/i2c/adv7183.c                   |  2 +-
 drivers/media/i2c/imx274.c                    | 12 +++---
 drivers/media/i2c/mt9m001.c                   |  2 +-
 drivers/media/i2c/mt9m111.c                   |  2 +-
 drivers/media/i2c/mt9t112.c                   |  2 +-
 drivers/media/i2c/mt9v011.c                   |  2 +-
 drivers/media/i2c/mt9v111.c                   |  2 +-
 drivers/media/i2c/ov2640.c                    |  2 +-
 drivers/media/i2c/ov2680.c                    |  4 +-
 drivers/media/i2c/ov6650.c                    | 34 +++++++++-------
 drivers/media/i2c/ov772x.c                    |  2 +-
 drivers/media/i2c/ov9640.c                    |  2 +-
 drivers/media/i2c/rj54n1cb0c.c                |  2 +-
 drivers/media/i2c/saa6752hs.c                 |  2 +-
 drivers/media/i2c/tw9910.c                    |  2 +-
 drivers/media/platform/atmel/atmel-isi.c      | 13 ++++---
 .../platform/microchip/microchip-isc-base.c   | 39 -------------------
 drivers/media/v4l2-core/v4l2-subdev.c         |  6 +--
 .../media/atomisp/i2c/atomisp-gc2235.c        |  2 +-
 .../media/atomisp/i2c/atomisp-mt9m114.c       |  2 +-
 .../media/atomisp/i2c/atomisp-ov2722.c        |  2 +-
 .../staging/media/atomisp/pci/atomisp_tpg.c   |  2 +-
 .../media/deprecated/atmel/atmel-isc-base.c   | 10 +++--
 drivers/staging/media/tegra-video/vi.c        | 14 ++++---
 include/media/v4l2-subdev.h                   | 19 +++------
 include/uapi/linux/v4l2-subdev.h              |  2 +-
 26 files changed, 77 insertions(+), 108 deletions(-)