[v4,0/1] media: v4l2-subdev: Make .init_cfg() an internal operation

Message

Laurent Pinchart Nov. 27, 2023, 9:07 a.m. UTC

Hello,

This patch addresses a historical issue in the V4L2 subdev in-kernel
API.

The subdev .init_cfg() pad operation used to initialize a
v4l2_subdev_pad_config structure. This was changed to initializing a
v4l2_subdev_state a while ago, but the operation wasn't renamed, and
stayed a pad operation. Not only is the name confusing for new
developers, it is also the only pad operation that doesn't operate on a
pad, leading to more confusion.

This patch addresses those two issues by renaming the operation to
.init_cfg() and moving it to the subdev internal operations. All of the
preparatory patches from previous version have been applied by Sakari
already, leaving only this patch for a respin.

The patch is based on Sakari's latest test branch ([1]), containing
patches scheduled for v6.8. I would like to get it merged in v6.8 as
well, as it touches many drivers and rebasing it is painful. Mauro,
Hans, for this reason, I would appreciate if you could review this patch
now and not when Sakari or I will send a pull request.

[1] https://git.linuxtv.org/sailus/media_tree.git/log/?h=test

Laurent Pinchart (1):
  media: v4l2-subdev: Rename .init_cfg() operation to .init_state()

 drivers/media/i2c/adv7180.c                   | 10 ++--
 drivers/media/i2c/ccs/ccs-core.c              |  6 +--
 drivers/media/i2c/ds90ub913.c                 | 10 ++--
 drivers/media/i2c/ds90ub953.c                 | 10 ++--
 drivers/media/i2c/ds90ub960.c                 | 11 ++--
 drivers/media/i2c/gc2145.c                    | 10 ++--
 drivers/media/i2c/hi846.c                     | 10 ++--
 drivers/media/i2c/imx214.c                    | 12 +++--
 drivers/media/i2c/imx219.c                    |  9 ++--
 drivers/media/i2c/imx290.c                    | 10 ++--
 drivers/media/i2c/imx296.c                    | 10 ++--
 drivers/media/i2c/imx334.c                    | 12 +++--
 drivers/media/i2c/imx335.c                    | 12 +++--
 drivers/media/i2c/imx412.c                    | 12 +++--
 drivers/media/i2c/imx415.c                    | 10 ++--
 drivers/media/i2c/mt9m001.c                   | 10 ++--
 drivers/media/i2c/mt9m111.c                   | 10 ++--
 drivers/media/i2c/mt9m114.c                   | 16 +++---
 drivers/media/i2c/mt9p031.c                   |  8 +--
 drivers/media/i2c/mt9v111.c                   | 10 ++--
 drivers/media/i2c/ov01a10.c                   | 10 ++--
 drivers/media/i2c/ov02a10.c                   | 10 ++--
 drivers/media/i2c/ov2640.c                    | 10 ++--
 drivers/media/i2c/ov2680.c                    | 10 ++--
 drivers/media/i2c/ov2740.c                    | 10 ++--
 drivers/media/i2c/ov5640.c                    | 10 ++--
 drivers/media/i2c/ov5645.c                    | 12 +++--
 drivers/media/i2c/ov5670.c                    | 10 ++--
 drivers/media/i2c/ov7251.c                    | 12 +++--
 drivers/media/i2c/ov8858.c                    | 10 ++--
 drivers/media/i2c/ov9282.c                    | 12 +++--
 drivers/media/i2c/st-vgxy61.c                 | 10 ++--
 drivers/media/i2c/tc358746.c                  | 10 ++--
 drivers/media/i2c/tda1997x.c                  | 10 ++--
 drivers/media/i2c/thp7312.c                   | 10 ++--
 drivers/media/i2c/tvp5150.c                   |  6 +--
 drivers/media/pci/intel/ivsc/mei_csi.c        | 10 ++--
 drivers/media/platform/cadence/cdns-csi2rx.c  | 10 ++--
 .../platform/microchip/microchip-csi2dc.c     | 10 ++--
 .../platform/microchip/microchip-isc-scaler.c | 10 ++--
 drivers/media/platform/nxp/imx-mipi-csis.c    | 10 ++--
 drivers/media/platform/nxp/imx7-media-csi.c   |  6 +--
 .../platform/nxp/imx8-isi/imx8-isi-crossbar.c | 10 ++--
 .../platform/nxp/imx8-isi/imx8-isi-pipe.c     | 10 ++--
 drivers/media/platform/nxp/imx8mq-mipi-csi2.c | 10 ++--
 .../platform/renesas/rzg2l-cru/rzg2l-csi2.c   | 10 ++--
 .../platform/renesas/rzg2l-cru/rzg2l-ip.c     | 10 ++--
 .../media/platform/renesas/vsp1/vsp1_brx.c    |  1 -
 .../media/platform/renesas/vsp1/vsp1_clu.c    |  1 -
 .../media/platform/renesas/vsp1/vsp1_entity.c | 53 +++++++++----------
 .../media/platform/renesas/vsp1/vsp1_entity.h |  2 -
 .../media/platform/renesas/vsp1/vsp1_hsit.c   |  1 -
 .../media/platform/renesas/vsp1/vsp1_lif.c    |  1 -
 .../media/platform/renesas/vsp1/vsp1_lut.c    |  1 -
 .../media/platform/renesas/vsp1/vsp1_rwpf.c   |  1 -
 .../media/platform/renesas/vsp1/vsp1_sru.c    |  1 -
 .../media/platform/renesas/vsp1/vsp1_uds.c    |  1 -
 .../media/platform/renesas/vsp1/vsp1_uif.c    |  1 -
 .../platform/rockchip/rkisp1/rkisp1-csi.c     | 10 ++--
 .../platform/rockchip/rkisp1/rkisp1-isp.c     | 10 ++--
 .../platform/rockchip/rkisp1/rkisp1-resizer.c | 10 ++--
 .../st/stm32/stm32-dcmipp/dcmipp-byteproc.c   |  6 +--
 .../st/stm32/stm32-dcmipp/dcmipp-parallel.c   |  6 +--
 .../platform/sunxi/sun4i-csi/sun4i_csi.c      |  1 +
 .../platform/sunxi/sun4i-csi/sun4i_csi.h      |  1 +
 .../platform/sunxi/sun4i-csi/sun4i_v4l2.c     |  9 ++--
 .../sunxi/sun6i-csi/sun6i_csi_bridge.c        | 10 ++--
 .../sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c   | 10 ++--
 .../sun8i_a83t_mipi_csi2.c                    | 10 ++--
 drivers/media/platform/ti/cal/cal-camerarx.c  | 10 ++--
 drivers/media/platform/video-mux.c            | 10 ++--
 .../media/platform/xilinx/xilinx-csi2rxss.c   | 10 ++--
 .../media/test-drivers/vimc/vimc-debayer.c    | 11 ++--
 drivers/media/test-drivers/vimc/vimc-scaler.c | 11 ++--
 drivers/media/test-drivers/vimc/vimc-sensor.c | 11 ++--
 drivers/media/v4l2-core/v4l2-subdev.c         | 20 +++----
 drivers/staging/media/imx/imx-ic-prp.c        |  2 +-
 drivers/staging/media/imx/imx-ic-prpencvf.c   |  2 +-
 drivers/staging/media/imx/imx-media-csi.c     |  2 +-
 drivers/staging/media/imx/imx-media-utils.c   |  8 +--
 drivers/staging/media/imx/imx-media-vdic.c    |  2 +-
 drivers/staging/media/imx/imx-media.h         |  4 +-
 drivers/staging/media/imx/imx6-mipi-csi2.c    |  2 +-
 .../staging/media/starfive/camss/stf-isp.c    |  6 ++-
 .../media/sunxi/sun6i-isp/sun6i_isp_proc.c    | 10 ++--
 include/media/v4l2-subdev.h                   |  7 +--
 86 files changed, 487 insertions(+), 264 deletions(-)


base-commit: 851fbdaebd3b1b4c47c2e2e38342c5ccf292ce27