[v4,0/7] media: Sony IMX335 improvements

Message

Umang Jain Dec. 11, 2023, 12:59 p.m. UTC

The Sony IMX335 is not yet compatible with libcamera, as it is missing
the get selection API call.

It also misses a way to describe how to power on the sensor.

Now that I've got this camera functioning on Debix-SOM and Pi5, I expect
to be able to do quite a bit more cleanup to the code here. But these
patches should already be valid for consideration.

The series provides the bindings required to reference the power
supplies, and then performs some initial clean up to the driver for
error reporting before adding the regulator enablement, implementing the
get_selection api (as well as set selection, which returns the static
configuration) and restricts the hblanking to match the configuration.

v4:
 - Fixed kernel test bot warning in Patch 7/7:
   drivers/media/i2c/imx335.c:160: warning: Function parameter or member 'cur_mbus_code' not described in 'imx335'
 - Dropped "[PATCH v3 8/8] media: i2c: imx335: Support multiple link frequency"
   from series, as the general timing register should also be programmed in
   conjunction (which was missing). Currently under investigation, will
   be posted as separate patch.

v3:
 - Remove #define and use ARRAY_SIZE(imx335_supply_name) directly in 4/8
 - Add two new patches for 10-bit mode(7/8) and multiple link frequency
   support(8/8)

v2:
 - Supplies are no longer 'required'
 - media: i2c: imx335: Fix logging line endings - New patch
 - line endings are fixed
 - error paths are handled for the regulator in imx335_power_on
 - set_selection is defined alongside get_selection

Kieran Bingham (6):
  media: dt-bindings: media: imx335: Add supply bindings
  media: i2c: imx335: Fix logging line endings
  media: i2c: imx335: Improve configuration error reporting
  media: i2c: imx335: Enable regulator supplies
  media: i2c: imx335: Implement get selection API
  media: i2c: imx335: Fix hblank min/max values

Umang Jain (1):
  media: i2c: imx335: Support 2592x1940 10-bit mode

 .../bindings/media/i2c/sony,imx335.yaml       |  13 ++
 drivers/media/i2c/imx335.c                    | 211 +++++++++++++++---
 2 files changed, 191 insertions(+), 33 deletions(-)