| Message ID | 20240311105623.20406-1-jackson.lee@chipsnmedia.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add auto suspend/resume,YUV422 format,SPS/PPS generation for each IDR | expand |
Hello Hans, Sebastian, and Nicolas Can you please review the following patch for the V2 ? https://www.spinics.net/lists/kernel/msg5136434.html thanks. Jackson > -----Original Message----- > From: jackson.lee > Sent: Monday, March 11, 2024 7:57 PM > To: mchehab@kernel.org; nicolas@ndufresne.ca; > sebastian.fricke@collabora.com > Cc: linux-media@vger.kernel.org; linux-kernel@vger.kernel.org; > hverkuil@xs4all.nl; Nas Chung <nas.chung@chipsnmedia.com>; lafley.kim > <lafley.kim@chipsnmedia.com>; b-brnich@ti.com; jackson.lee > <jackson.lee@chipsnmedia.com> > Subject: [RESEND PATCH v2 0/4] Add auto suspend/resume,YUV422 > format,SPS/PPS generation for each IDR > > From: "Jackson.lee" <jackson.lee@chipsnmedia.com> > > The wave5 codec driver is a stateful encoder/decoder. > The following patches is for supporting yuv422 inpuy format, supporting > runtime suspend/resume feature and extra things. > > v4l2-compliance results: > ======================== > > v4l2-compliance 1.24.1, 64 bits, 64-bit time_t > > Buffer ioctls: > warn: v4l2-test-buffers.cpp(693): VIDIOC_CREATE_BUFS not > supported > warn: v4l2-test-buffers.cpp(693): VIDIOC_CREATE_BUFS not > supported > test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK > test VIDIOC_EXPBUF: OK > test Requests: OK (Not Supported) > > Total for wave5-dec device /dev/video0: 45, Succeeded: 45, Failed: 0, > Warnings: 2 Total for wave5-enc device /dev/video1: 45, Succeeded: 45, > Failed: 0, Warnings: 0 > > Fluster test results: > ===================== > > Running test suite JCT-VC-HEVC_V1 with decoder GStreamer-H.265-V4L2-Gst1.0 > Using 1 parallel job(s) > Ran 132/147 tests successfully in 94.782 secs > > (1 test fails because of not supporting to parse multi frames, 1 test > fails because of a missing frame and slight corruption, 2 tests fail > because of sizes which are incompatible with the IP, 11 tests fail because > of unsupported 10 bit format) > > Running test suite JVT-AVC_V1 with decoder GStreamer-H.264-V4L2-Gst1.0 > Using 1 parallel job(s) > Ran 77/135 tests successfully in 37.364 secs > > (58 fail because the hardware is unable to decode MBAFF / FMO / Field / > Extended profile streams.) > > > Chnage since v1: > ================= > > * For [PATCH v2 0/4] media: chips-media: wave5: Support SPS/PPS generation > for each IDR > - define a macro for register addresses > > * For [PATCH v2 1/4] media: chips-media: wave5: Support runtime > suspend/resume > - add auto suspend/resume > > * For [PATCH v2 2/4] media: chips-media: wave5: Use helpers to calculate > bytesperline and sizeimage > - use helper functions to calculate bytesperline and sizeimage > > * For [PATCH v2 3/4] media: chips-media: wave5: Support YUV422 raw pixel- > formats on the encoder > - remove unnecessary codes > > Change since v0: > ================= > The DEFAULT_SRC_SIZE macro was defined using multiple lines, To make a > simple define, tab and multiple lines has been removed, The macro is > defined using one line. > > Jackson.lee (4): > media: chips-media: wave5: Support SPS/PPS generation for each IDR > media: chips-media: wave5: Support runtime suspend/resume > media: chips-media: wave5: Use helpers to calculate bytesperline and > sizeimage. > media: chips-media: wave5: Support YUV422 raw pixel-formats on the > encoder. > > .../platform/chips-media/wave5/wave5-helper.c | 24 ++ > .../platform/chips-media/wave5/wave5-helper.h | 4 + > .../platform/chips-media/wave5/wave5-hw.c | 23 +- > .../chips-media/wave5/wave5-vpu-dec.c | 261 +++++------------- > .../chips-media/wave5/wave5-vpu-enc.c | 260 +++++++++-------- > .../platform/chips-media/wave5/wave5-vpu.c | 43 +++ > .../platform/chips-media/wave5/wave5-vpu.h | 4 - > .../platform/chips-media/wave5/wave5-vpuapi.c | 14 +- > .../platform/chips-media/wave5/wave5-vpuapi.h | 1 + > .../chips-media/wave5/wave5-vpuconfig.h | 25 +- > .../media/platform/chips-media/wave5/wave5.h | 3 + > 11 files changed, 329 insertions(+), 333 deletions(-) > > -- > 2.43.0
Hello Sebastian, Hans and Nicolas Could you please review the below patch series ? https://patchwork.linuxtv.org/project/linux-media/list/?series=12404 thanks Jackson > -----Original Message----- > From: jackson.lee <jackson.lee@chipsnmedia.com> > Sent: Monday, March 11, 2024 7:56 PM > To: mchehab@kernel.org; nicolas@ndufresne.ca; > sebastian.fricke@collabora.com > Cc: linux-media@vger.kernel.org; linux-kernel@vger.kernel.org; > hverkuil@xs4all.nl; Nas Chung <nas.chung@chipsnmedia.com>; lafley.kim > <lafley.kim@chipsnmedia.com>; b-brnich@ti.com; jackson.lee > <jackson.lee@chipsnmedia.com> > Subject: [RESEND PATCH v2 0/4] Add auto suspend/resume,YUV422 > format,SPS/PPS generation for each IDR > > From: "Jackson.lee" <jackson.lee@chipsnmedia.com> > > The wave5 codec driver is a stateful encoder/decoder. > The following patches is for supporting yuv422 inpuy format, supporting > runtime suspend/resume feature and extra things. > > v4l2-compliance results: > ======================== > > v4l2-compliance 1.24.1, 64 bits, 64-bit time_t > > Buffer ioctls: > warn: v4l2-test-buffers.cpp(693): VIDIOC_CREATE_BUFS not > supported > warn: v4l2-test-buffers.cpp(693): VIDIOC_CREATE_BUFS not > supported > test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK > test VIDIOC_EXPBUF: OK > test Requests: OK (Not Supported) > > Total for wave5-dec device /dev/video0: 45, Succeeded: 45, Failed: 0, > Warnings: 2 Total for wave5-enc device /dev/video1: 45, Succeeded: 45, > Failed: 0, Warnings: 0 > > Fluster test results: > ===================== > > Running test suite JCT-VC-HEVC_V1 with decoder GStreamer-H.265-V4L2-Gst1.0 > Using 1 parallel job(s) > Ran 132/147 tests successfully in 94.782 secs > > (1 test fails because of not supporting to parse multi frames, 1 test > fails because of a missing frame and slight corruption, 2 tests fail > because of sizes which are incompatible with the IP, 11 tests fail because > of unsupported 10 bit format) > > Running test suite JVT-AVC_V1 with decoder GStreamer-H.264-V4L2-Gst1.0 > Using 1 parallel job(s) > Ran 77/135 tests successfully in 37.364 secs > > (58 fail because the hardware is unable to decode MBAFF / FMO / Field / > Extended profile streams.) > > > Chnage since v1: > ================= > > * For [PATCH v2 0/4] media: chips-media: wave5: Support SPS/PPS generation > for each IDR > - define a macro for register addresses > > * For [PATCH v2 1/4] media: chips-media: wave5: Support runtime > suspend/resume > - add auto suspend/resume > > * For [PATCH v2 2/4] media: chips-media: wave5: Use helpers to calculate > bytesperline and sizeimage > - use helper functions to calculate bytesperline and sizeimage > > * For [PATCH v2 3/4] media: chips-media: wave5: Support YUV422 raw pixel- > formats on the encoder > - remove unnecessary codes > > Change since v0: > ================= > The DEFAULT_SRC_SIZE macro was defined using multiple lines, To make a > simple define, tab and multiple lines has been removed, The macro is > defined using one line. > > Jackson.lee (4): > media: chips-media: wave5: Support SPS/PPS generation for each IDR > media: chips-media: wave5: Support runtime suspend/resume > media: chips-media: wave5: Use helpers to calculate bytesperline and > sizeimage. > media: chips-media: wave5: Support YUV422 raw pixel-formats on the > encoder. > > .../platform/chips-media/wave5/wave5-helper.c | 24 ++ > .../platform/chips-media/wave5/wave5-helper.h | 4 + > .../platform/chips-media/wave5/wave5-hw.c | 23 +- > .../chips-media/wave5/wave5-vpu-dec.c | 261 +++++------------- > .../chips-media/wave5/wave5-vpu-enc.c | 260 +++++++++-------- > .../platform/chips-media/wave5/wave5-vpu.c | 43 +++ > .../platform/chips-media/wave5/wave5-vpu.h | 4 - > .../platform/chips-media/wave5/wave5-vpuapi.c | 14 +- > .../platform/chips-media/wave5/wave5-vpuapi.h | 1 + > .../chips-media/wave5/wave5-vpuconfig.h | 25 +- > .../media/platform/chips-media/wave5/wave5.h | 3 + > 11 files changed, 329 insertions(+), 333 deletions(-) > > -- > 2.43.0
Hey Jackson, On 25.03.2024 06:19, jackson.lee wrote: >Hello Sebastian, Hans and Nicolas > >Could you please review the below patch series ? Sorry for the delay, me and Nicolas are currently quite busy. So, the review of the patchset will be delayed a bit longer, current goal would be review this until the 20th of April. I'll try to keep you updated. Greetings, Sebastian > > >https://patchwork.linuxtv.org/project/linux-media/list/?series=12404 > > >thanks >Jackson > >> -----Original Message----- >> From: jackson.lee <jackson.lee@chipsnmedia.com> >> Sent: Monday, March 11, 2024 7:56 PM >> To: mchehab@kernel.org; nicolas@ndufresne.ca; >> sebastian.fricke@collabora.com >> Cc: linux-media@vger.kernel.org; linux-kernel@vger.kernel.org; >> hverkuil@xs4all.nl; Nas Chung <nas.chung@chipsnmedia.com>; lafley.kim >> <lafley.kim@chipsnmedia.com>; b-brnich@ti.com; jackson.lee >> <jackson.lee@chipsnmedia.com> >> Subject: [RESEND PATCH v2 0/4] Add auto suspend/resume,YUV422 >> format,SPS/PPS generation for each IDR >> >> From: "Jackson.lee" <jackson.lee@chipsnmedia.com> >> >> The wave5 codec driver is a stateful encoder/decoder. >> The following patches is for supporting yuv422 inpuy format, supporting >> runtime suspend/resume feature and extra things. >> >> v4l2-compliance results: >> ======================== >> >> v4l2-compliance 1.24.1, 64 bits, 64-bit time_t >> >> Buffer ioctls: >> warn: v4l2-test-buffers.cpp(693): VIDIOC_CREATE_BUFS not >> supported >> warn: v4l2-test-buffers.cpp(693): VIDIOC_CREATE_BUFS not >> supported >> test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK >> test VIDIOC_EXPBUF: OK >> test Requests: OK (Not Supported) >> >> Total for wave5-dec device /dev/video0: 45, Succeeded: 45, Failed: 0, >> Warnings: 2 Total for wave5-enc device /dev/video1: 45, Succeeded: 45, >> Failed: 0, Warnings: 0 >> >> Fluster test results: >> ===================== >> >> Running test suite JCT-VC-HEVC_V1 with decoder GStreamer-H.265-V4L2-Gst1.0 >> Using 1 parallel job(s) >> Ran 132/147 tests successfully in 94.782 secs >> >> (1 test fails because of not supporting to parse multi frames, 1 test >> fails because of a missing frame and slight corruption, 2 tests fail >> because of sizes which are incompatible with the IP, 11 tests fail because >> of unsupported 10 bit format) >> >> Running test suite JVT-AVC_V1 with decoder GStreamer-H.264-V4L2-Gst1.0 >> Using 1 parallel job(s) >> Ran 77/135 tests successfully in 37.364 secs >> >> (58 fail because the hardware is unable to decode MBAFF / FMO / Field / >> Extended profile streams.) >> >> >> Chnage since v1: >> ================= >> >> * For [PATCH v2 0/4] media: chips-media: wave5: Support SPS/PPS generation >> for each IDR >> - define a macro for register addresses >> >> * For [PATCH v2 1/4] media: chips-media: wave5: Support runtime >> suspend/resume >> - add auto suspend/resume >> >> * For [PATCH v2 2/4] media: chips-media: wave5: Use helpers to calculate >> bytesperline and sizeimage >> - use helper functions to calculate bytesperline and sizeimage >> >> * For [PATCH v2 3/4] media: chips-media: wave5: Support YUV422 raw pixel- >> formats on the encoder >> - remove unnecessary codes >> >> Change since v0: >> ================= >> The DEFAULT_SRC_SIZE macro was defined using multiple lines, To make a >> simple define, tab and multiple lines has been removed, The macro is >> defined using one line. >> >> Jackson.lee (4): >> media: chips-media: wave5: Support SPS/PPS generation for each IDR >> media: chips-media: wave5: Support runtime suspend/resume >> media: chips-media: wave5: Use helpers to calculate bytesperline and >> sizeimage. >> media: chips-media: wave5: Support YUV422 raw pixel-formats on the >> encoder. >> >> .../platform/chips-media/wave5/wave5-helper.c | 24 ++ >> .../platform/chips-media/wave5/wave5-helper.h | 4 + >> .../platform/chips-media/wave5/wave5-hw.c | 23 +- >> .../chips-media/wave5/wave5-vpu-dec.c | 261 +++++------------- >> .../chips-media/wave5/wave5-vpu-enc.c | 260 +++++++++-------- >> .../platform/chips-media/wave5/wave5-vpu.c | 43 +++ >> .../platform/chips-media/wave5/wave5-vpu.h | 4 - >> .../platform/chips-media/wave5/wave5-vpuapi.c | 14 +- >> .../platform/chips-media/wave5/wave5-vpuapi.h | 1 + >> .../chips-media/wave5/wave5-vpuconfig.h | 25 +- >> .../media/platform/chips-media/wave5/wave5.h | 3 + >> 11 files changed, 329 insertions(+), 333 deletions(-) >> >> -- >> 2.43.0 >
Hello Sebastian Thanks for your reply. > -----Original Message----- > From: sebastian.fricke@collabora.com <sebastian.fricke@collabora.com> > Sent: Thursday, April 4, 2024 4:47 PM > To: jackson.lee <jackson.lee@chipsnmedia.com> > Cc: mchehab@kernel.org; nicolas@ndufresne.ca; hverkuil@xs4all.nl; linux- > media@vger.kernel.org; linux-kernel@vger.kernel.org; Nas Chung > <nas.chung@chipsnmedia.com>; lafley.kim <lafley.kim@chipsnmedia.com>; b- > brnich@ti.com > Subject: Re: [RESEND PATCH v2 0/4] Add auto suspend/resume,YUV422 > format,SPS/PPS generation for each IDR > > Hey Jackson, > > On 25.03.2024 06:19, jackson.lee wrote: > >Hello Sebastian, Hans and Nicolas > > > >Could you please review the below patch series ? > > Sorry for the delay, me and Nicolas are currently quite busy. So, the > review of the patchset will be delayed a bit longer, current goal would be > review this until the 20th of April. I'll try to keep you updated. > > Greetings, > Sebastian > > > > > > >https://patchwork.linuxtv.org/project/linux-media/list/?series=12404 > > > > > >thanks > >Jackson > > > >> -----Original Message----- > >> From: jackson.lee <jackson.lee@chipsnmedia.com> > >> Sent: Monday, March 11, 2024 7:56 PM > >> To: mchehab@kernel.org; nicolas@ndufresne.ca; > >> sebastian.fricke@collabora.com > >> Cc: linux-media@vger.kernel.org; linux-kernel@vger.kernel.org; > >> hverkuil@xs4all.nl; Nas Chung <nas.chung@chipsnmedia.com>; lafley.kim > >> <lafley.kim@chipsnmedia.com>; b-brnich@ti.com; jackson.lee > >> <jackson.lee@chipsnmedia.com> > >> Subject: [RESEND PATCH v2 0/4] Add auto suspend/resume,YUV422 > >> format,SPS/PPS generation for each IDR > >> > >> From: "Jackson.lee" <jackson.lee@chipsnmedia.com> > >> > >> The wave5 codec driver is a stateful encoder/decoder. > >> The following patches is for supporting yuv422 inpuy format, > >> supporting runtime suspend/resume feature and extra things. > >> > >> v4l2-compliance results: > >> ======================== > >> > >> v4l2-compliance 1.24.1, 64 bits, 64-bit time_t > >> > >> Buffer ioctls: > >> warn: v4l2-test-buffers.cpp(693): VIDIOC_CREATE_BUFS not > >> supported > >> warn: v4l2-test-buffers.cpp(693): VIDIOC_CREATE_BUFS not > >> supported > >> test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK > >> test VIDIOC_EXPBUF: OK > >> test Requests: OK (Not Supported) > >> > >> Total for wave5-dec device /dev/video0: 45, Succeeded: 45, Failed: 0, > >> Warnings: 2 Total for wave5-enc device /dev/video1: 45, Succeeded: > >> 45, > >> Failed: 0, Warnings: 0 > >> > >> Fluster test results: > >> ===================== > >> > >> Running test suite JCT-VC-HEVC_V1 with decoder > >> GStreamer-H.265-V4L2-Gst1.0 Using 1 parallel job(s) > >> Ran 132/147 tests successfully in 94.782 secs > >> > >> (1 test fails because of not supporting to parse multi frames, 1 test > >> fails because of a missing frame and slight corruption, 2 tests fail > >> because of sizes which are incompatible with the IP, 11 tests fail > >> because of unsupported 10 bit format) > >> > >> Running test suite JVT-AVC_V1 with decoder > >> GStreamer-H.264-V4L2-Gst1.0 Using 1 parallel job(s) > >> Ran 77/135 tests successfully in 37.364 secs > >> > >> (58 fail because the hardware is unable to decode MBAFF / FMO / > >> Field / Extended profile streams.) > >> > >> > >> Chnage since v1: > >> ================= > >> > >> * For [PATCH v2 0/4] media: chips-media: wave5: Support SPS/PPS > >> generation for each IDR > >> - define a macro for register addresses > >> > >> * For [PATCH v2 1/4] media: chips-media: wave5: Support runtime > >> suspend/resume > >> - add auto suspend/resume > >> > >> * For [PATCH v2 2/4] media: chips-media: wave5: Use helpers to > >> calculate bytesperline and sizeimage > >> - use helper functions to calculate bytesperline and sizeimage > >> > >> * For [PATCH v2 3/4] media: chips-media: wave5: Support YUV422 raw > >> pixel- formats on the encoder > >> - remove unnecessary codes > >> > >> Change since v0: > >> ================= > >> The DEFAULT_SRC_SIZE macro was defined using multiple lines, To make > >> a simple define, tab and multiple lines has been removed, The macro > >> is defined using one line. > >> > >> Jackson.lee (4): > >> media: chips-media: wave5: Support SPS/PPS generation for each IDR > >> media: chips-media: wave5: Support runtime suspend/resume > >> media: chips-media: wave5: Use helpers to calculate bytesperline and > >> sizeimage. > >> media: chips-media: wave5: Support YUV422 raw pixel-formats on the > >> encoder. > >> > >> .../platform/chips-media/wave5/wave5-helper.c | 24 ++ > >> .../platform/chips-media/wave5/wave5-helper.h | 4 + > >> .../platform/chips-media/wave5/wave5-hw.c | 23 +- > >> .../chips-media/wave5/wave5-vpu-dec.c | 261 +++++------------- > >> .../chips-media/wave5/wave5-vpu-enc.c | 260 +++++++++-------- > >> .../platform/chips-media/wave5/wave5-vpu.c | 43 +++ > >> .../platform/chips-media/wave5/wave5-vpu.h | 4 - > >> .../platform/chips-media/wave5/wave5-vpuapi.c | 14 +- > >> .../platform/chips-media/wave5/wave5-vpuapi.h | 1 + > >> .../chips-media/wave5/wave5-vpuconfig.h | 25 +- > >> .../media/platform/chips-media/wave5/wave5.h | 3 + > >> 11 files changed, 329 insertions(+), 333 deletions(-) > >> > >> -- > >> 2.43.0 > >
From: "Jackson.lee" <jackson.lee@chipsnmedia.com> The wave5 codec driver is a stateful encoder/decoder. The following patches is for supporting yuv422 inpuy format, supporting runtime suspend/resume feature and extra things. v4l2-compliance results: ======================== v4l2-compliance 1.24.1, 64 bits, 64-bit time_t Buffer ioctls: warn: v4l2-test-buffers.cpp(693): VIDIOC_CREATE_BUFS not supported warn: v4l2-test-buffers.cpp(693): VIDIOC_CREATE_BUFS not supported test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK test Requests: OK (Not Supported) Total for wave5-dec device /dev/video0: 45, Succeeded: 45, Failed: 0, Warnings: 2 Total for wave5-enc device /dev/video1: 45, Succeeded: 45, Failed: 0, Warnings: 0 Fluster test results: ===================== Running test suite JCT-VC-HEVC_V1 with decoder GStreamer-H.265-V4L2-Gst1.0 Using 1 parallel job(s) Ran 132/147 tests successfully in 94.782 secs (1 test fails because of not supporting to parse multi frames, 1 test fails because of a missing frame and slight corruption, 2 tests fail because of sizes which are incompatible with the IP, 11 tests fail because of unsupported 10 bit format) Running test suite JVT-AVC_V1 with decoder GStreamer-H.264-V4L2-Gst1.0 Using 1 parallel job(s) Ran 77/135 tests successfully in 37.364 secs (58 fail because the hardware is unable to decode MBAFF / FMO / Field / Extended profile streams.) Chnage since v1: ================= * For [PATCH v2 0/4] media: chips-media: wave5: Support SPS/PPS generation for each IDR - define a macro for register addresses * For [PATCH v2 1/4] media: chips-media: wave5: Support runtime suspend/resume - add auto suspend/resume * For [PATCH v2 2/4] media: chips-media: wave5: Use helpers to calculate bytesperline and sizeimage - use helper functions to calculate bytesperline and sizeimage * For [PATCH v2 3/4] media: chips-media: wave5: Support YUV422 raw pixel-formats on the encoder - remove unnecessary codes Change since v0: ================= The DEFAULT_SRC_SIZE macro was defined using multiple lines, To make a simple define, tab and multiple lines has been removed, The macro is defined using one line. Jackson.lee (4): media: chips-media: wave5: Support SPS/PPS generation for each IDR media: chips-media: wave5: Support runtime suspend/resume media: chips-media: wave5: Use helpers to calculate bytesperline and sizeimage. media: chips-media: wave5: Support YUV422 raw pixel-formats on the encoder. .../platform/chips-media/wave5/wave5-helper.c | 24 ++ .../platform/chips-media/wave5/wave5-helper.h | 4 + .../platform/chips-media/wave5/wave5-hw.c | 23 +- .../chips-media/wave5/wave5-vpu-dec.c | 261 +++++------------- .../chips-media/wave5/wave5-vpu-enc.c | 260 +++++++++-------- .../platform/chips-media/wave5/wave5-vpu.c | 43 +++ .../platform/chips-media/wave5/wave5-vpu.h | 4 - .../platform/chips-media/wave5/wave5-vpuapi.c | 14 +- .../platform/chips-media/wave5/wave5-vpuapi.h | 1 + .../chips-media/wave5/wave5-vpuconfig.h | 25 +- .../media/platform/chips-media/wave5/wave5.h | 3 + 11 files changed, 329 insertions(+), 333 deletions(-)