mbox series

[v2,0/2] media: uvcvideo: Support partial control reads and minor changes

Message ID 20241008-uvc-readless-v2-0-04d9d51aee56@chromium.org (mailing list archive)
Headers show
Series media: uvcvideo: Support partial control reads and minor changes | expand

Message

Ricardo Ribalda Oct. 8, 2024, 3 p.m. UTC 
Some cameras do not return all the bytes requested from a control
if it can fit in less bytes. Eg: returning 0xab instead of 0x00ab.
Support these devices.

Also, now that we are at it, improve uvc_query_ctrl() logging.

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
Changes in v2:
- Rewrite error handling (Thanks Sakari)
- Discard 2/3. It is not needed after rewriting the error handling.
- Link to v1: https://lore.kernel.org/r/20241008-uvc-readless-v1-0-042ac4581f44@chromium.org

---
Ricardo Ribalda (2):
      media: uvcvideo: Support partial control reads
      media: uvcvideo: Add more logging to uvc_query_ctrl()

 drivers/media/usb/uvc/uvc_video.c | 27 +++++++++++++++++++++++----
 1 file changed, 23 insertions(+), 4 deletions(-)
---
base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc
change-id: 20241008-uvc-readless-23f9b8cad0b3

Best regards,

Comments

Sakari Ailus Oct. 8, 2024, 8:08 p.m. UTC | #1 
On Tue, Oct 08, 2024 at 03:00:06PM +0000, Ricardo Ribalda wrote:
> Some cameras do not return all the bytes requested from a control
> if it can fit in less bytes. Eg: returning 0xab instead of 0x00ab.
> Support these devices.
> 
> Also, now that we are at it, improve uvc_query_ctrl() logging.
> 
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>

For both:

Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>