[00/10] media: rcar: Minor cleanups and improvements

Message

Tomi Valkeinen Jan. 20, 2025, 1:10 p.m. UTC

I've started looking at multi-stream support, and came up with these
while working towards streams.

 Tomi

Signed-off-by: Tomi Valkeinen <[e-mail]>
---
Tomi Valkeinen (10):
      media: rcar-csi2: Move Y8 entry to a better place
      media: rcar-csi2: Add RAW10 and RAW12 formats
      media: rcar-isp: Add RAW8, RAW10 and RAW12 formats
      media: rcar-csi2: Use v4l2_get_link_freq()
      media: rcar-vin: Use v4l2_subdev_{enable|disable}_streams()
      media: rcar-isp: Use v4l2_subdev_{enable|disable}_streams()
      media: rcar-csi2: Use v4l2_subdev_{enable|disable}_streams()
      media: rcar-isp: Convert to subdev state
      media: rcar-isp: Convert to .{enable|disable}_streams
      media: rcar-csi2: Convert to .{enable|disable}_streams

 drivers/media/platform/renesas/rcar-csi2.c         | 118 ++++++++++-----
 drivers/media/platform/renesas/rcar-isp.c          | 162 +++++++++++++--------
 drivers/media/platform/renesas/rcar-vin/rcar-dma.c |   4 +-
 3 files changed, 190 insertions(+), 94 deletions(-)
---
base-commit: 94794b5ce4d90ab134b0b101a02fddf6e74c437d
change-id: 20250120-rcar-media-impro-2c37c1036e19

Best regards,

Comments

Niklas Söderlund Jan. 21, 2025, 9:24 p.m. UTC | #1

Hi Tomi,

Thanks for a great cleanup series!

On 2025-01-20 15:10:33 +0200, Tomi Valkeinen wrote:
> I've started looking at multi-stream support, and came up with these
> while working towards streams.
> 
>  Tomi
> 
> Signed-off-by: Tomi Valkeinen <[e-mail]>

I have tested this in Gen2, Gen3 and Gen4 without noticing any 
regressions. The log is now spammed with the helpful suggestion that the 
CSI-2 TX subdevices shall implement V4L2_CID_LINK_FREQ control. This is 
annoying but out of scope for this series, but would be nice at some 
point.

  [   37.421531] v4l2_get_link_freq: Link frequency estimated using pixel rate: result might be inaccurate
  [   37.430991] v4l2_get_link_freq: Consider implementing support for V4L2_CID_LINK_FREQ in the transmitter driver

For the whole series,

Reviewed-by: Niklas Söderlund <[e-mail]>
Tested-by: Niklas Söderlund <[e-mail]>

> ---
> Tomi Valkeinen (10):
>       media: rcar-csi2: Move Y8 entry to a better place
>       media: rcar-csi2: Add RAW10 and RAW12 formats
>       media: rcar-isp: Add RAW8, RAW10 and RAW12 formats
>       media: rcar-csi2: Use v4l2_get_link_freq()
>       media: rcar-vin: Use v4l2_subdev_{enable|disable}_streams()
>       media: rcar-isp: Use v4l2_subdev_{enable|disable}_streams()
>       media: rcar-csi2: Use v4l2_subdev_{enable|disable}_streams()
>       media: rcar-isp: Convert to subdev state
>       media: rcar-isp: Convert to .{enable|disable}_streams
>       media: rcar-csi2: Convert to .{enable|disable}_streams
> 
>  drivers/media/platform/renesas/rcar-csi2.c         | 118 ++++++++++-----
>  drivers/media/platform/renesas/rcar-isp.c          | 162 +++++++++++++--------
>  drivers/media/platform/renesas/rcar-vin/rcar-dma.c |   4 +-
>  3 files changed, 190 insertions(+), 94 deletions(-)
> ---
> base-commit: 94794b5ce4d90ab134b0b101a02fddf6e74c437d
> change-id: 20250120-rcar-media-impro-2c37c1036e19
> 
> Best regards,
> -- 
> Tomi Valkeinen <[e-mail]>
>

Tomi Valkeinen Jan. 22, 2025, 8:02 a.m. UTC | #2

Hi,

On 21/01/2025 23:24, Niklas Söderlund wrote:
> Hi Tomi,
> 
> Thanks for a great cleanup series!
> 
> On 2025-01-20 15:10:33 +0200, Tomi Valkeinen wrote:
>> I've started looking at multi-stream support, and came up with these
>> while working towards streams.
>>
>>   Tomi
>>
>> Signed-off-by: Tomi Valkeinen <[e-mail]>
> 
> I have tested this in Gen2, Gen3 and Gen4 without noticing any
> regressions. The log is now spammed with the helpful suggestion that the
> CSI-2 TX subdevices shall implement V4L2_CID_LINK_FREQ control. This is
> annoying but out of scope for this series, but would be nice at some
> point.
> 
>    [   37.421531] v4l2_get_link_freq: Link frequency estimated using pixel rate: result might be inaccurate
>    [   37.430991] v4l2_get_link_freq: Consider implementing support for V4L2_CID_LINK_FREQ in the transmitter driver

Which drivers need fixing? The staging max96712 is one (there seems to 
be a TODO there about it), and adv748x? I'm not going to work on that 
right now, but just collecting the details.

> For the whole series,
> 
> Reviewed-by: Niklas Söderlund <[e-mail]>
> Tested-by: Niklas Söderlund <[e-mail]>

Thanks!

  Tomi