Message ID | 20250224-uvc-data-backup-v2-0-de993ed9823b@chromium.org (mailing list archive) |
---|---|
Headers | show
Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D73A52505C8 for <linux-media@vger.kernel.org>; Mon, 24 Feb 2025 10:34:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740393298; cv=none; b=gfsx/XOnEHae6nZp73d+WDazBhWDaIHo8XeQTEe+VtFNWubUAwIki9Q9uKSSSZpcnvoKHrOxdxuAiVcqnp1OFAglysyd3+GzQyKoyL8jjGJ6LusHuLeGh9BQMH63fQoJsfBu/X+R8pK0H6riXaf863jtTBTzKuI1uAip0/riYKo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740393298; c=relaxed/simple; bh=ifUIY51mD67INF7Ty4UagC3PivMGO5cVpDC7jcHo0ZI=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=lBvqrUrhG9pM+mQqvFR4mApOiICGKU9S+kkMcymN9BBgeXaGRSyonpKId+dQP6G8/qwv/51oAr8S3F3afpdXpPdjPqRE1TJFmepdCTPW0MJRf/9jsHd+tANT6okwdiklmdJR3VHCMMmOKOwqUakSq0v6MXJLxKyJyEkuEsA7mnU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=K7WiLPpb; arc=none smtp.client-ip=209.85.222.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="K7WiLPpb" Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-7c095b5365eso269308085a.1 for <linux-media@vger.kernel.org>; Mon, 24 Feb 2025 02:34:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1740393296; x=1740998096; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=Rpru3d4kK5T418MxLBJyNUhgDCiefpb3TqvSQ99StII=; b=K7WiLPpban+/3jcskyaCoOekweLRJ702vve3L/TaqC32asKRrv4QJ1QeyW6teSTnlq ZaxDpi/DxurliHCe+ZXBAPP4enO9FytrwMK4rheOrevy4U77lsZQK6yB9LWa+5jqcmgu XIWaGysyZJkUuILTQLTM4TfFU/ZHCSKJC65OY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740393296; x=1740998096; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Rpru3d4kK5T418MxLBJyNUhgDCiefpb3TqvSQ99StII=; b=b+kOwf7rLuNmimHXAu9E0rCyj8H20c2s+911BILLZN98uIQXOUvXpt8V1WT0gxXI8y lsujV35LJZoEiT5iivvJdfg0ca8320PKjueTgWHYCrKg17/ERvIVzjJEB8VOWkKoYO3q Sg1rcWBMF3jokvbq/7EcbRa3Hs6C+vuJlJx5IVzHeOzQakTR5J/RIXVq90rW2sJH93IS 8aOa3EyC2FUr2Pt64uSCgSzugkO9tCneQ0EId7NFFPHq5A/A4pQoUqmsZzZPM5UYsICw CAl3llAqpZ/XV8NbNGpbRbzoyBXe+PwsNFD8xQp3NH1bCKkjkertpffdMR9GujlWAGl7 3iPQ== X-Gm-Message-State: AOJu0YygzAn6i5O551raGUWk2wWFufsSVqnKJZlVgJbZGqLqToQ5CDtZ DJB3jVSabNk3vBGxMPGFbH36eGgymcMHbHEwUJYfHX0QVqyLjiyxP6AN8jKmMQ== X-Gm-Gg: ASbGncvusmHDNOtO9HuK0pi4v3NXTCFlB9SFFcaTomb4UadJfNMGV3EtpaJJ6pmSiek gfABP+1xv30sQpc0mnuYQCxg1rmmnxQWEorzjqBDJwBL7Wf89ft5wzGwkQcxWeApYmZ1sOLXhIg UNvOL23OEltUhfEztTCZ1jF4U3lwnrMqo4vISir5J8w3YQHnOYhjDguhaifWc2bEZKAzvdv1s2S lRrqoSt8d7X0vV0dESxJJJLW6nqd/+d2gmcj6xzu8Sgjttm6n/tLcV1h8BD4pUgYZ1afP3jfd9q oPPLEFjr74WBUF6Dpcoa1Vx22RUcz5qGmqB6RKtjLUdxTtKBrDfv8ozdHcoJBRlhVg1ZBeMQUkd adDY= X-Google-Smtp-Source: AGHT+IEwuaTcW/NqR0O8qiW1KQMI5TU+w6SLZl+84kr+4cdqIGTyZOv63vcOE4pdfK+EPhQ2Y3R4ag== X-Received: by 2002:a05:620a:444c:b0:7c0:7d64:6da7 with SMTP id af79cd13be357-7c0ceefd41cmr1639587285a.21.1740393295682; Mon, 24 Feb 2025 02:34:55 -0800 (PST) Received: from denia.c.googlers.com (15.237.245.35.bc.googleusercontent.com. [35.245.237.15]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c0b0b7f637sm787139985a.33.2025.02.24.02.34.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2025 02:34:54 -0800 (PST) From: Ricardo Ribalda <ribalda@chromium.org> Subject: [PATCH v2 0/3] media: uvcvideo: Make sure the ctrl cache is in sync with the device Date: Mon, 24 Feb 2025 10:34:52 +0000 Message-Id: <20250224-uvc-data-backup-v2-0-de993ed9823b@chromium.org> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: <linux-media.vger.kernel.org> List-Subscribe: <mailto:linux-media+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-media+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAExLvGcC/3WNQQqDMBBFryKz7pQkSsWueg9xMY2jDkUjiQkt4 t2buu/yPfjv7xDYCwe4Fzt4ThLELRnMpQA70TIySp8ZjDKVNlphTBZ72gifZF9xRVJU3/qhIeY G8mr1PMj7LLZd5knC5vznPEj6Z/+3kkaFda0rzVXZWFs+7OTdLHG+Oj9CdxzHF3WLwHyxAAAA To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Hans de Goede <hdegoede@redhat.com>, Mauro Carvalho Chehab <mchehab@kernel.org> Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda <ribalda@chromium.org>, stable@kernel.org X-Mailer: b4 0.14.1 |
Series |
media: uvcvideo: Make sure the ctrl cache is in sync with the device
|
expand
|
Hans discovered a bug in the error handling of uvc_ctrl_commit(), lets fix it. It has been tested with v4l2-compliance -d /dev/video0 Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> --- Changes in v2: - Fix commit message (Thanks Laurent). - Change logic for err_ctrl. It looks nicer now. - Link to v1: https://lore.kernel.org/r/20241210-uvc-data-backup-v1-0-77141e439cc3@chromium.org --- Ricardo Ribalda (3): media: uvcvideo: Return the number of processed controls media: uvcvideo: Send control events for partial succeeds media: uvcvideo: Rollback non processed entities on error drivers/media/usb/uvc/uvc_ctrl.c | 53 ++++++++++++++++++++++++++++++---------- 1 file changed, 40 insertions(+), 13 deletions(-) --- base-commit: c2b96a6818159fba8a3bcc38262da9e77f9b3ec7 change-id: 20241210-uvc-data-backup-a0a76df9aee9 Best regards,