From patchwork Thu Oct 4 22:13:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 10626937 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 80C8315A6 for ; Thu, 4 Oct 2018 22:13:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5687C2951F for ; Thu, 4 Oct 2018 22:13:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4897929525; Thu, 4 Oct 2018 22:13:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B28F02951F for ; Thu, 4 Oct 2018 22:13:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726075AbeJEFJU (ORCPT ); Fri, 5 Oct 2018 01:09:20 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:46282 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725758AbeJEFJU (ORCPT ); Fri, 5 Oct 2018 01:09:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Sender:Message-Id:Date:Subject:Cc:To: From:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dybwuh6sFMgQQX+lZKihlUsmmMJQ/YU4G58y3uUq2R0=; b=Y5AOla/o9b+ersxnXNM8vJlino +gnfze7p/hFLguUh0IvpMiqgpo33GlWpcms3VwZDQv/7EfOLVsEDZyq2cheheMdYE+5mhP0kvJhk6 vsMX3q90xRbUZ7I5pEG6td4Dq7Yoi6x/RV5VJwVqPs5snOD8wm7C352BeF1+OW1RObrNfxxZLOpax cqgQf1KFQh/H7JmZNkgYcYWbJ3jXB0lCk1y1pl7RVM79XDMwosa0KaxWvRmStpf3a3po34Beb7TVG 13+4RU/5jJYv30hBfrq+fhbhaarCPJfCH1/jpSZ/xzfv5c5r/TU9MDmxS/DHKFpyaekh7OrXNpByX XbxF8NQw==; Received: from [179.95.46.242] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1g8BsW-0003Ef-NE; Thu, 04 Oct 2018 22:13:52 +0000 Received: from mchehab by bombadil.infradead.org with local (Exim 4.91) (envelope-from ) id 1g8BsT-0000kR-KL; Thu, 04 Oct 2018 18:13:49 -0400 From: Mauro Carvalho Chehab Cc: Mauro Carvalho Chehab , Linux Media Mailing List , Mauro Carvalho Chehab , =?utf-8?q?Niklas_S=C3=B6derl?= =?utf-8?q?und?= , Sakari Ailus , Steve Longerbeam , Hans Verkuil , Sebastian Reichel Subject: [PATCH 0/3] Coding style cleanups after the fwnode patchset Date: Thu, 4 Oct 2018 18:13:45 -0400 Message-Id: X-Mailer: git-send-email 2.17.1 To: unlisted-recipients:; (no To-header on input) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The fwnode patchset added a several new warnings, as identified by checkpatch.pl --strict. Those are at the core stuff, and makes harder to review patches there. The most irritating stuff there are functions like: some_very_long_function_that_has_a_very_comprehensive_name( ...); Functions ending with a "(" without arguments doesn't follow the right coding style, and it is an heritage of the usage of "indent". Ok, it sounds that the patches were actually trying to follow an existing coding style inside it. As we're about to close the media merge window, and the fwnode patches already changed a lot of code there, before that becomes an habit to follow its weird style, let's fix it. After this series, all we have is the lack of SPDX inside the sources, and some long lines (with is inevitable without renaming those kAPI functions). Btw, I was tempted to rename them, renaming functions like: v4l2_async_notifier_parse_fwnode_endpoints_by_port to something like: v4l2_async_parse_fwnode_ep_by_port or even: v4l2_parse_fwnode_ep_by_port with is probably good enough, but, as this is part of the kAPI, I opted to keep it as-is - for now. Mauro Carvalho Chehab (3): media: v4l2-core: cleanup coding style at V4L2 async/fwnode media: v4l2-fwnode: cleanup functions that parse endpoints media: v4l2-fwnode: simplify v4l2_fwnode_reference_parse_int_props() call drivers/media/v4l2-core/v4l2-async.c | 45 +++--- drivers/media/v4l2-core/v4l2-fwnode.c | 190 ++++++++++++++------------ include/media/v4l2-async.h | 12 +- include/media/v4l2-fwnode.h | 45 +++--- include/media/v4l2-mediabus.h | 32 +++-- 5 files changed, 177 insertions(+), 147 deletions(-)