mbox series

[v2,0/4] media: si2157: rework firmware load logic

Message ID cover.1639049865.git.mchehab+huawei@kernel.org (mailing list archive)
Headers show
Series media: si2157: rework firmware load logic | expand

Message

Mauro Carvalho Chehab Dec. 9, 2021, 11:41 a.m. UTC 
As pointed bt Robert, if there's already a firmware for si2157 at
/lib/firmware, it is preferred to use it, instead of the default firmware.

Yet, when this is missed, the driver may still work. That's the case,
for instance, of the devices explicitly flagged with dont_load_firmware
(currently, Terratec Cinergy TC2).

So, rework the firmware logic in a way that it will emit a warning for
devices that are using the eeprom firmware and may not work well
with it.

Compile-tested only.

Robert,

Could you please test it on your devices?

--

v2:
 - added a patch to allow supporting different firmwares depending on
   the device's reported ROM ID.
   
Mauro Carvalho Chehab (3):
  media: si2157: move firmware load to a separate function
  media: si2157: rework the firmware load logic
  media: si2157: use a different namespace for firmware

Robert Schlabbach (1):
  media: si2157: Add optional firmware download

 drivers/media/tuners/si2157.c      | 248 +++++++++++++++++------------
 drivers/media/tuners/si2157_priv.h |  14 ++
 2 files changed, 163 insertions(+), 99 deletions(-)