| Message ID | 0c086fea0d3f0771f6c8627e99edb719e282a49c.1638179135.git.mchehab+huawei@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Solve the remaining issues with clang and W=1 on media | expand |
On Mon, Nov 29, 2021 at 9:48 AM Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote: > > Such function is currently unused, but could be needed in the > future. So, keep it, marking it as __always_unused, in order to > avoid a clang W=1 error. > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > --- > > See [PATCH v2 00/20] at: https://lore.kernel.org/all/cover.1638179135.git.mchehab+huawei@kernel.org/ > > drivers/media/platform/davinci/vpbe_osd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Lad Prabhakar <prabhakar.csengg@gmail.com> Cheers, Prabhakar > diff --git a/drivers/media/platform/davinci/vpbe_osd.c b/drivers/media/platform/davinci/vpbe_osd.c > index 91b571a0ac2c..32f7ef547c82 100644 > --- a/drivers/media/platform/davinci/vpbe_osd.c > +++ b/drivers/media/platform/davinci/vpbe_osd.c > @@ -45,7 +45,7 @@ static const struct platform_device_id vpbe_osd_devtype[] = { > MODULE_DEVICE_TABLE(platform, vpbe_osd_devtype); > > /* register access routines */ > -static inline u32 osd_read(struct osd_state *sd, u32 offset) > +static inline u32 __always_unused osd_read(struct osd_state *sd, u32 offset) > { > struct osd_state *osd = sd; > > -- > 2.33.1 >
diff --git a/drivers/media/platform/davinci/vpbe_osd.c b/drivers/media/platform/davinci/vpbe_osd.c index 91b571a0ac2c..32f7ef547c82 100644 --- a/drivers/media/platform/davinci/vpbe_osd.c +++ b/drivers/media/platform/davinci/vpbe_osd.c @@ -45,7 +45,7 @@ static const struct platform_device_id vpbe_osd_devtype[] = { MODULE_DEVICE_TABLE(platform, vpbe_osd_devtype); /* register access routines */ -static inline u32 osd_read(struct osd_state *sd, u32 offset) +static inline u32 __always_unused osd_read(struct osd_state *sd, u32 offset) { struct osd_state *osd = sd;
Such function is currently unused, but could be needed in the future. So, keep it, marking it as __always_unused, in order to avoid a clang W=1 error. Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> --- See [PATCH v2 00/20] at: https://lore.kernel.org/all/cover.1638179135.git.mchehab+huawei@kernel.org/ drivers/media/platform/davinci/vpbe_osd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)