From patchwork Tue Feb 3 01:08:16 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Klimov X-Patchwork-Id: 5163 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n1318LcR031257 for ; Tue, 3 Feb 2009 01:08:21 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752918AbZBCBIV (ORCPT ); Mon, 2 Feb 2009 20:08:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753033AbZBCBIU (ORCPT ); Mon, 2 Feb 2009 20:08:20 -0500 Received: from fg-out-1718.google.com ([72.14.220.157]:44655 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752918AbZBCBIU (ORCPT ); Mon, 2 Feb 2009 20:08:20 -0500 Received: by fg-out-1718.google.com with SMTP id 16so763430fgg.17 for ; Mon, 02 Feb 2009 17:08:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:cc :content-type:date:message-id:mime-version:x-mailer :content-transfer-encoding; bh=2bheBgXb0ZgxhJLiG6sF828gWplorBhLZIBbx8Xzyg8=; b=pShLA7WlGIuFoLCZYNfGkyrNetehX+S96HuETDBMJkn2oDPF2VsdbVQ7Hoa6J/FLZs ZlPMclAuyCAQCIJAt7nVBRcyivqPXioK5sMnCqq1baJnwalrnH7+meQn2Sh7W1prEJCW Ondr87KjIHolWC1c+yyI23G7vfVqpfXTMPtlQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:content-type:date:message-id:mime-version :x-mailer:content-transfer-encoding; b=ll/5slPjujHTT9p/pWmIY0GINlrjDlMVS3aCj74DToMayC285yvhZj/M1nALn4z3bK RzHM3fjhyfQaeXk+L4OyIKmntfsxzXTNN/T99PwacGg75biE1xF30lsOquTvW4EtdO7g a2naG0pHiPGk/1+Fb3Xd8GyYKJTVc/Xq1cp94= Received: by 10.86.76.20 with SMTP id y20mr124498fga.37.1233623299449; Mon, 02 Feb 2009 17:08:19 -0800 (PST) Received: from ?192.168.1.42? (gw.zunet.ru [217.67.117.64]) by mx.google.com with ESMTPS id d6sm410555fga.39.2009.02.02.17.08.18 (version=SSLv3 cipher=RC4-MD5); Mon, 02 Feb 2009 17:08:19 -0800 (PST) Subject: [patch review 3/8] radio-mr800: add more dev_err messages in probe From: Alexey Klimov To: Douglas Schilling Landgraf Cc: linux-media@vger.kernel.org Date: Tue, 03 Feb 2009 04:08:16 +0300 Message-Id: <1233623296.17456.255.camel@tux.localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.24.2 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Patch adds 3 dev_err messages in usb_amradio_probe() function. Signed-off-by: Alexey Klimov diff -r c9f51bda84de linux/drivers/media/radio/radio-mr800.c --- a/linux/drivers/media/radio/radio-mr800.c Mon Feb 02 02:53:50 2009 +0300 +++ b/linux/drivers/media/radio/radio-mr800.c Mon Feb 02 03:08:13 2009 +0300 @@ -641,19 +641,23 @@ radio = kmalloc(sizeof(struct amradio_device), GFP_KERNEL); - if (!radio) + if (!radio) { + dev_err(&intf->dev, "kmalloc for amradio_device failed\n"); return -ENOMEM; + } radio->buffer = kmalloc(BUFFER_LENGTH, GFP_KERNEL); - if (!(radio->buffer)) { + if (!radio->buffer) { + dev_err(&intf->dev, "kmalloc for radio->buffer failed\n"); kfree(radio); return -ENOMEM; } radio->videodev = video_device_alloc(); - if (!(radio->videodev)) { + if (!radio->videodev) { + dev_err(&intf->dev, "video_device_alloc failed\n"); kfree(radio->buffer); kfree(radio); return -ENOMEM;