From patchwork Sun Feb 8 13:43:28 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Klimov X-Patchwork-Id: 6092 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n18DhMTX004714 for ; Sun, 8 Feb 2009 13:43:22 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752604AbZBHNnV (ORCPT ); Sun, 8 Feb 2009 08:43:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752309AbZBHNnV (ORCPT ); Sun, 8 Feb 2009 08:43:21 -0500 Received: from fg-out-1718.google.com ([72.14.220.154]:36634 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751872AbZBHNnV (ORCPT ); Sun, 8 Feb 2009 08:43:21 -0500 Received: by fg-out-1718.google.com with SMTP id 16so882885fgg.17 for ; Sun, 08 Feb 2009 05:43:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:cc :content-type:date:message-id:mime-version:x-mailer :content-transfer-encoding; bh=IkATcmkA8rvTzgtFhM07mU2oM4wwvC8QtiUXCC4ojoQ=; b=G7XYDr5G1Zf57ghob194am2ia91oo4ZL0uK5i5kcv2wrBkejnPB9DFWP/JMa7tkESs 1o9R7w37bQL7XGnewA6qZ9tTxaNZqME9lR2FaICF2otz5JmyPet3yAhStjovMYLl3lWc ZSJYiKVRmQiAylPys4YG9wCZRmzcPGuv5U1zA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:content-type:date:message-id:mime-version :x-mailer:content-transfer-encoding; b=u1SvA16uGB6DbAPr1VlBH7976WTE6IQwdfm79k/GkUeiOu5OknFwLuZmikktl9vWNQ cRNekpfLl8FUz95H/hSttpZPIIKdAHmhVNr0ZZot1JTW/Dzgw0cgZJQUE3mkfZl2gY/a vCV7rQoyDayQBMTyJb8KsD286Z+ynyy9qreu0= Received: by 10.86.61.13 with SMTP id j13mr1275705fga.59.1234100599257; Sun, 08 Feb 2009 05:43:19 -0800 (PST) Received: from ?192.168.1.42? (gw.zunet.ru [217.67.117.64]) by mx.google.com with ESMTPS id e11sm568948fga.40.2009.02.08.05.43.18 (version=SSLv3 cipher=RC4-MD5); Sun, 08 Feb 2009 05:43:18 -0800 (PST) Subject: [patch review] em28xx-audio: replace printk with em28xx_errdev From: Alexey Klimov To: Douglas Schilling Landgraf Cc: linux-media@vger.kernel.org Date: Sun, 08 Feb 2009 16:43:28 +0300 Message-Id: <1234100608.10910.16.camel@tux.localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.24.2 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hello all, i hope this patch will be useful. Probably this change should looks like: printk(KERN_ERR "em28xx-audio.c:..") but i suppose that em28xx_errdev is better. --- Patch removes printk and place em28xx_errdev macros to provide information about driver name to dmesg. Signed-off-by: Alexey Klimov --- diff -r 71e5a36634ea linux/drivers/media/video/em28xx/em28xx-audio.c --- a/linux/drivers/media/video/em28xx/em28xx-audio.c Mon Feb 02 10:33:31 2009 +0100 +++ b/linux/drivers/media/video/em28xx/em28xx-audio.c Sun Feb 08 15:28:18 2009 +0300 @@ -254,7 +254,7 @@ dev->adev.capture_stream = STREAM_OFF; em28xx_isoc_audio_deinit(dev); } else { - printk(KERN_ERR "An underrun very likely occurred. " + em28xx_errdev("An underrun very likely occurred. " "Ignoring it.\n"); } return 0;