From patchwork Wed Sep 15 21:44:22 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Rosenberg X-Patchwork-Id: 183692 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id o8FLpmn6010035 for ; Wed, 15 Sep 2010 21:51:49 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755440Ab0IOVu5 (ORCPT ); Wed, 15 Sep 2010 17:50:57 -0400 Received: from mx1.vsecurity.com ([209.67.252.12]:63778 "EHLO mx1.vsecurity.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755435Ab0IOVu4 (ORCPT ); Wed, 15 Sep 2010 17:50:56 -0400 X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]); Wed, 15 Sep 2010 21:51:49 +0000 (UTC) X-Greylist: delayed 383 seconds by postgrey-1.27 at vger.kernel.org; Wed, 15 Sep 2010 17:50:55 EDT Received: (qmail 53754 invoked from network); 15 Sep 2010 21:43:57 -0000 Received: from unknown (HELO [138.16.110.183]) (drosenbe@[138.16.110.183]) (envelope-sender ) by mx1.vsecurity.com (qmail-ldap-1.03) with SMTP for ; 15 Sep 2010 21:43:57 -0000 Subject: [PATCH] drivers/media/video/ivtv/ivtvfb.c: prevent reading uninitialized stack memory From: Dan Rosenberg To: awalls@md.metrocast.net Cc: ivtv-devel@ivtvdriver.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, security@kernel.org, stable@kernel.org Date: Wed, 15 Sep 2010 17:44:22 -0400 Message-ID: <1284587062.6275.102.camel@dan> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org --- linux-2.6.35.4.orig/drivers/media/video/ivtv/ivtvfb.c 2010-08-26 19:47:12.000000000 -0400 +++ linux-2.6.35.4/drivers/media/video/ivtv/ivtvfb.c 2010-09-15 14:16:46.797375399 -0400 @@ -458,6 +458,8 @@ static int ivtvfb_ioctl(struct fb_info * struct fb_vblank vblank; u32 trace; + memset(&vblank, 0, sizeof(struct fb_vblank)); + vblank.flags = FB_VBLANK_HAVE_COUNT |FB_VBLANK_HAVE_VCOUNT | FB_VBLANK_HAVE_VSYNC; trace = read_reg(IVTV_REG_DEC_LINE_FIELD) >> 16;