From patchwork Mon Dec 13 01:50:51 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hyunwoong Kim X-Patchwork-Id: 404092 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id oBD2Acl6029252 for ; Mon, 13 Dec 2010 02:10:38 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756595Ab0LMCKg (ORCPT ); Sun, 12 Dec 2010 21:10:36 -0500 Received: from ganesha.gnumonks.org ([213.95.27.120]:39354 "EHLO ganesha.gnumonks.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756189Ab0LMCKf (ORCPT ); Sun, 12 Dec 2010 21:10:35 -0500 Received: from uucp by ganesha.gnumonks.org with local-bsmtp (Exim 4.69) (envelope-from ) id 1PRxs1-0003Q7-B1; Mon, 13 Dec 2010 03:10:33 +0100 Received: from [12.23.102.153] (helo=localhost.localdomain) by jackpot.kr.gnumonks.org with esmtp (Exim 4.69) (envelope-from ) id 1PRwte-0003zf-Q2; Mon, 13 Dec 2010 10:08:10 +0900 From: Hyunwoong Kim To: linux-media@vger.kernel.org, linux-samsung-soc@vger.kernel.org Cc: s.nawrocki@samsung.com, Hyunwoong Kim Subject: [PATCH] [media] s5p-fimc: fix the value of YUV422 1plane formats Date: Mon, 13 Dec 2010 10:50:51 +0900 Message-Id: <1292205051-26707-1-git-send-email-khw0178.kim@samsung.com> X-Mailer: git-send-email 1.6.2.5 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]); Mon, 13 Dec 2010 02:10:39 +0000 (UTC) ================================================================ bit | MSB LSB ================================================================ 00 | Cr1 Y3 Cb1 Y2 Cr0 Y1 Cb0 Y0 ================================================================ 01 | Cb1 Y3 Cr1 Y2 Cb0 Y1 Cr0 Y0 ================================================================ 10 | Y3 Cr1 Y2 Cb1 Y1 Cr0 Y0 Cb0 ================================================================ 11 | Y3 Cb1 Y2 Cr1 Y1 Cb0 Y0 Cr0 ================================================================ V4L2_PIX_FMT_YVYU, V4L2_PIX_FMT_UYVY, V4L2_PIX_FMT_VYUY are also mismatched with datasheet. MSCTRL[17:16], order2p_in, is also mismatched in V4L2_PIX_FMT_UYVY, V4L2_PIX_FMT_YVYU. Signed-off-by: Hyunwoong Kim Reviewed-by: Jonghun Han --- I wonder why fimc_fmt struct has fourcc and color together as member of structure. It seems that the meaning of color is the same as fourcc's meaning. drivers/media/video/s5p-fimc/fimc-core.h | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/media/video/s5p-fimc/fimc-core.h b/drivers/media/video/s5p-fimc/fimc-core.h index a707060..4efc1a1 100644 --- a/drivers/media/video/s5p-fimc/fimc-core.h +++ b/drivers/media/video/s5p-fimc/fimc-core.h @@ -96,15 +96,15 @@ enum fimc_color_fmt { #define fimc_fmt_is_rgb(x) ((x) & 0x10) /* Y/Cb/Cr components order at DMA output for 1 plane YCbCr 4:2:2 formats. */ -#define S5P_FIMC_OUT_CRYCBY S5P_CIOCTRL_ORDER422_CRYCBY -#define S5P_FIMC_OUT_CBYCRY S5P_CIOCTRL_ORDER422_YCRYCB -#define S5P_FIMC_OUT_YCRYCB S5P_CIOCTRL_ORDER422_CBYCRY -#define S5P_FIMC_OUT_YCBYCR S5P_CIOCTRL_ORDER422_YCBYCR +#define S5P_FIMC_OUT_CRYCBY S5P_CIOCTRL_ORDER422_YCBYCR +#define S5P_FIMC_OUT_CBYCRY S5P_CIOCTRL_ORDER422_CBYCRY +#define S5P_FIMC_OUT_YCRYCB S5P_CIOCTRL_ORDER422_YCRYCB +#define S5P_FIMC_OUT_YCBYCR S5P_CIOCTRL_ORDER422_CRYCBY /* Input Y/Cb/Cr components order for 1 plane YCbCr 4:2:2 color formats. */ #define S5P_FIMC_IN_CRYCBY S5P_MSCTRL_ORDER422_CRYCBY -#define S5P_FIMC_IN_CBYCRY S5P_MSCTRL_ORDER422_YCRYCB -#define S5P_FIMC_IN_YCRYCB S5P_MSCTRL_ORDER422_CBYCRY +#define S5P_FIMC_IN_CBYCRY S5P_MSCTRL_ORDER422_CBYCRY +#define S5P_FIMC_IN_YCRYCB S5P_MSCTRL_ORDER422_YCRYCB #define S5P_FIMC_IN_YCBYCR S5P_MSCTRL_ORDER422_YCBYCR /* Cb/Cr chrominance components order for 2 plane Y/CbCr 4:2:2 formats. */