diff mbox

[media] dib0700: fix possible NULL pointer dereference

Message ID 1301163836-7601-1-git-send-email-mk@lab.zgora.pl (mailing list archive)
State Accepted
Headers show

Commit Message

Mariusz Kozlowski March 26, 2011, 6:23 p.m. UTC
None

Comments

Patrick Boettcher April 3, 2011, 3:44 p.m. UTC | #1
On Saturday 26 March 2011 19:23:56 Mariusz Kozlowski wrote:
> Seems like 'adap->fe' test for NULL was meant to be before we dereference
> that pointer.
> 
> Signed-off-by: Mariusz Kozlowski <mk@lab.zgora.pl>

Thanks, applied.

--
Patrick Boettcher - KernelLabs
http://www.kernellabs.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/media/dvb/dvb-usb/dib0700_devices.c b/drivers/media/dvb/dvb-usb/dib0700_devices.c
index 97af266..b48f1e0 100644
--- a/drivers/media/dvb/dvb-usb/dib0700_devices.c
+++ b/drivers/media/dvb/dvb-usb/dib0700_devices.c
@@ -2439,12 +2439,11 @@  static int tfe7090pvr_frontend0_attach(struct dvb_usb_adapter *adap)
 
 	dib0700_set_i2c_speed(adap->dev, 340);
 	adap->fe = dvb_attach(dib7000p_attach, &adap->dev->i2c_adap, 0x90, &tfe7090pvr_dib7000p_config[0]);
-
-	dib7090_slave_reset(adap->fe);
-
 	if (adap->fe == NULL)
 		return -ENODEV;
 
+	dib7090_slave_reset(adap->fe);
+
 	return 0;
 }