From patchwork Thu Apr 14 14:39:57 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Teresa_G=C3=A1mez?= X-Patchwork-Id: 707191 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p3EEeF5q028092 for ; Thu, 14 Apr 2011 14:40:15 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758872Ab1DNOkI (ORCPT ); Thu, 14 Apr 2011 10:40:08 -0400 Received: from mail.x-arc.de ([217.6.246.34]:56303 "EHLO root.phytec.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758813Ab1DNOkH convert rfc822-to-8bit (ORCPT ); Thu, 14 Apr 2011 10:40:07 -0400 Received: from idefix.phytec.de (idefix.phytec.de [172.16.0.10]) by root.phytec.de (Postfix) with ESMTP id 5A0C6BF08D; Thu, 14 Apr 2011 16:42:11 +0200 (CEST) Received: from numalfix.phytec.de ([127.0.0.1]) by idefix.phytec.de (Lotus Domino Release 8.5.2 HF194) with ESMTP id 2011041416400618-176819 ; Thu, 14 Apr 2011 16:40:06 +0200 Received: by numalfix.phytec.de (Postfix, from userid 1010) id 1A65D1A0C1F; Thu, 14 Apr 2011 16:40:06 +0200 (CEST) From: =?UTF-8?q?Teresa=20G=C3=A1mez?= To: linux-media@vger.kernel.org Cc: g.liakhovetski@gmx.de, =?UTF-8?q?Teresa=20G=C3=A1mez?= Subject: [PATCH] mt9v022: fix pixel clock Date: Thu, 14 Apr 2011 16:39:57 +0200 Message-Id: <1302791997-12679-1-git-send-email-t.gamez@phytec.de> X-Mailer: git-send-email 1.7.0.4 MIME-Version: 1.0 X-MIMETrack: Itemize by SMTP Server on Idefix/Phytec(Release 8.5.2 HF194|November 09, 2010) at 14.04.2011 16:40:06, Serialize by Router on Idefix/Phytec(Release 8.5.2 HF194|November 09, 2010) at 14.04.2011 16:40:06, Serialize complete at 14.04.2011 16:40:06 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Thu, 14 Apr 2011 14:40:15 +0000 (UTC) The setup of the pixel clock is done wrong in the mt9v022 driver. The 'Invert Pixel Clock' bit has to be set to 1 for falling edge and not for rising. This is not clearly described in the data sheet. Tested on pcm037 and pcm027/pcm990. Signed-off-by: Teresa Gámez --- drivers/media/video/mt9v022.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/mt9v022.c b/drivers/media/video/mt9v022.c index 6a784c8..dec2a69 100644 --- a/drivers/media/video/mt9v022.c +++ b/drivers/media/video/mt9v022.c @@ -228,7 +228,7 @@ static int mt9v022_set_bus_param(struct soc_camera_device *icd, flags = soc_camera_apply_sensor_flags(icl, flags); - if (flags & SOCAM_PCLK_SAMPLE_RISING) + if (flags & SOCAM_PCLK_SAMPLE_FALLING) pixclk |= 0x10; if (!(flags & SOCAM_HSYNC_ACTIVE_HIGH))