From patchwork Wed May 18 16:06:51 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sanjeev Premi X-Patchwork-Id: 793852 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.3) with ESMTP id p4IG7AYG027120 for ; Wed, 18 May 2011 16:07:12 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757012Ab1ERQHJ (ORCPT ); Wed, 18 May 2011 12:07:09 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:54094 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755225Ab1ERQHI (ORCPT ); Wed, 18 May 2011 12:07:08 -0400 Received: from dbdp20.itg.ti.com ([172.24.170.38]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id p4IG73ck031442 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 18 May 2011 11:07:05 -0500 Received: from dbde71.ent.ti.com (localhost [127.0.0.1]) by dbdp20.itg.ti.com (8.13.8/8.13.8) with ESMTP id p4IG72nY009460; Wed, 18 May 2011 21:37:02 +0530 (IST) Received: from dbdp31.itg.ti.com (172.24.170.98) by DBDE71.ent.ti.com (172.24.170.149) with Microsoft SMTP Server id 8.3.106.1; Wed, 18 May 2011 21:37:02 +0530 Received: from psplinux050.india.ti.com (dbdp20.itg.ti.com [172.24.170.38]) by dbdp31.itg.ti.com (8.13.8/8.13.8) with ESMTP id p4IG70SP013579; Wed, 18 May 2011 21:37:01 +0530 (IST) From: Sanjeev Premi To: CC: Sanjeev Premi , Subject: [PATCH] omap3: isp: fix compiler warning Date: Wed, 18 May 2011 21:36:51 +0530 Message-ID: <1305734811-2354-1-git-send-email-premi@ti.com> X-Mailer: git-send-email 1.7.2.2 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Wed, 18 May 2011 16:07:12 +0000 (UTC) This patch fixes this compiler warning: drivers/media/video/omap3isp/isp.c: In function 'isp_isr_dbg': drivers/media/video/omap3isp/isp.c:392:2: warning: zero-length gnu_printf format string Since printk() is used in next few statements, same was used here as well. Signed-off-by: Sanjeev Premi Cc: laurent.pinchart@ideasonboard.com --- Actually full block can be converted to dev_dbg() as well; but i am not sure about original intent of the mix. Based on comments, i can resubmit with all prints converted to dev_dbg. drivers/media/video/omap3isp/isp.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/omap3isp/isp.c b/drivers/media/video/omap3isp/isp.c index 503bd79..1d38d96 100644 --- a/drivers/media/video/omap3isp/isp.c +++ b/drivers/media/video/omap3isp/isp.c @@ -387,7 +387,7 @@ static inline void isp_isr_dbg(struct isp_device *isp, u32 irqstatus) }; int i; - dev_dbg(isp->dev, ""); + printk(KERN_DEBUG "%s:\n", dev_driver_string(isp->dev)); for (i = 0; i < ARRAY_SIZE(name); i++) { if ((1 << i) & irqstatus)