diff mbox

media: soc_camera_video_start - type should be const

Message ID 1307306757-7068-1-git-send-email-geert@linux-m68k.org (mailing list archive)
State Accepted
Headers show

Commit Message

Geert Uytterhoeven June 5, 2011, 8:45 p.m. UTC
drivers/media/video/soc_camera.c: In function ‘soc_camera_video_start’:
drivers/media/video/soc_camera.c:1515: warning: initialization discards qualifiers from pointer target type

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/media/video/soc_camera.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Guennadi Liakhovetski June 6, 2011, 9:46 a.m. UTC | #1
Hi Geert

On Sun, 5 Jun 2011, Geert Uytterhoeven wrote:

> drivers/media/video/soc_camera.c: In function ‘soc_camera_video_start’:
> drivers/media/video/soc_camera.c:1515: warning: initialization discards qualifiers from pointer target type
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
>  drivers/media/video/soc_camera.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/media/video/soc_camera.c b/drivers/media/video/soc_camera.c
> index 3988643..4e4d412 100644
> --- a/drivers/media/video/soc_camera.c
> +++ b/drivers/media/video/soc_camera.c
> @@ -1512,7 +1512,7 @@ static int video_dev_create(struct soc_camera_device *icd)
>   */
>  static int soc_camera_video_start(struct soc_camera_device *icd)
>  {
> -	struct device_type *type = icd->vdev->dev.type;
> +	const struct device_type *type = icd->vdev->dev.type;
>  	int ret;
>  
>  	if (!icd->dev.parent)
> -- 
> 1.7.0.4

Thanks for the patchm unfortunately, you're not the first:

http://www.mail-archive.com/linux-media@vger.kernel.org/msg32245.html

and not even the second;)

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/media/video/soc_camera.c b/drivers/media/video/soc_camera.c
index 3988643..4e4d412 100644
--- a/drivers/media/video/soc_camera.c
+++ b/drivers/media/video/soc_camera.c
@@ -1512,7 +1512,7 @@  static int video_dev_create(struct soc_camera_device *icd)
  */
 static int soc_camera_video_start(struct soc_camera_device *icd)
 {
-	struct device_type *type = icd->vdev->dev.type;
+	const struct device_type *type = icd->vdev->dev.type;
 	int ret;
 
 	if (!icd->dev.parent)