diff mbox

[6/6] V4l2: OMAP: VOUT: Minor Cleanup, removing the unnecessary code.

Message ID 1307458058-29030-7-git-send-email-amber@ti.com (mailing list archive)
State RFC
Headers show

Commit Message

Scheurer, Amber June 7, 2011, 2:47 p.m. UTC 
Minor changes to remove the unused code from omap_vout driver.

Signed-off-by: Amber Jain <amber@ti.com>
Signed-off-by: Samreen <samreen@ti.com>
---
 drivers/media/video/omap/omap_vout.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

Comments

Vaibhav Hiremath July 5, 2011, 7:07 p.m. UTC | #1 
> -----Original Message-----
> From: JAIN, AMBER
> Sent: Tuesday, June 07, 2011 8:18 PM
> To: linux-media@vger.kernel.org
> Cc: Hiremath, Vaibhav; Semwal, Sumit; JAIN, AMBER; Nilofer, Samreen
> Subject: [PATCH 6/6] V4l2: OMAP: VOUT: Minor Cleanup, removing the
> unnecessary code.
> 
> Minor changes to remove the unused code from omap_vout driver.
> 
> Signed-off-by: Amber Jain <amber@ti.com>
> Signed-off-by: Samreen <samreen@ti.com>
> ---
>  drivers/media/video/omap/omap_vout.c |    6 ------
>  1 files changed, 0 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/media/video/omap/omap_vout.c
> b/drivers/media/video/omap/omap_vout.c
> index 25025a1..4aeea06 100644
> --- a/drivers/media/video/omap/omap_vout.c
> +++ b/drivers/media/video/omap/omap_vout.c
> @@ -1090,10 +1090,7 @@ static int vidioc_enum_fmt_vid_out_mplane(struct
> file *file, void *fh,
>  			struct v4l2_fmtdesc *fmt)
>  {
>  	int index = fmt->index;
> -	enum v4l2_buf_type type = fmt->type;
> 
> -	fmt->index = index;
> -	fmt->type = type;
[Hiremath, Vaibhav] These lines are not present in main-line driver? Which baseline have you used for this patch?

Thanks,
Vaibhav

>  	if (index >= NUM_OUTPUT_FORMATS)
>  		return -EINVAL;
> 
> @@ -1268,10 +1265,7 @@ static int vidioc_enum_fmt_vid_overlay(struct file
> *file, void *fh,
>  			struct v4l2_fmtdesc *fmt)
>  {
>  	int index = fmt->index;
> -	enum v4l2_buf_type type = fmt->type;
> 
> -	fmt->index = index;
> -	fmt->type = type;
>  	if (index >= NUM_OUTPUT_FORMATS)
>  		return -EINVAL;
> 
> --
> 1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Vaibhav Hiremath July 5, 2011, 7:11 p.m. UTC | #2 
> -----Original Message-----
> From: Hiremath, Vaibhav
> Sent: Wednesday, July 06, 2011 12:38 AM
> To: JAIN, AMBER; linux-media@vger.kernel.org
> Cc: Semwal, Sumit; Nilofer, Samreen
> Subject: RE: [PATCH 6/6] V4l2: OMAP: VOUT: Minor Cleanup, removing the
> unnecessary code.
> 
> 
> > -----Original Message-----
> > From: JAIN, AMBER
> > Sent: Tuesday, June 07, 2011 8:18 PM
> > To: linux-media@vger.kernel.org
> > Cc: Hiremath, Vaibhav; Semwal, Sumit; JAIN, AMBER; Nilofer, Samreen
> > Subject: [PATCH 6/6] V4l2: OMAP: VOUT: Minor Cleanup, removing the
> > unnecessary code.
> >
> > Minor changes to remove the unused code from omap_vout driver.
> >
> > Signed-off-by: Amber Jain <amber@ti.com>
> > Signed-off-by: Samreen <samreen@ti.com>
> > ---
> >  drivers/media/video/omap/omap_vout.c |    6 ------
> >  1 files changed, 0 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/media/video/omap/omap_vout.c
> > b/drivers/media/video/omap/omap_vout.c
> > index 25025a1..4aeea06 100644
> > --- a/drivers/media/video/omap/omap_vout.c
> > +++ b/drivers/media/video/omap/omap_vout.c
> > @@ -1090,10 +1090,7 @@ static int vidioc_enum_fmt_vid_out_mplane(struct
> > file *file, void *fh,
> >  			struct v4l2_fmtdesc *fmt)
> >  {
> >  	int index = fmt->index;
> > -	enum v4l2_buf_type type = fmt->type;
> >
> > -	fmt->index = index;
> > -	fmt->type = type;
> [Hiremath, Vaibhav] These lines are not present in main-line driver? Which
> baseline have you used for this patch?
[Hiremath, Vaibhav] My bad, I hit send button quite early. I will queue this up for 3.1.

Acked-by: Vaibhav Hiremath <hvaibhav@ti.com>

Thanks,
Vaibhav

> 
> Thanks,
> Vaibhav
> 
> >  	if (index >= NUM_OUTPUT_FORMATS)
> >  		return -EINVAL;
> >
> > @@ -1268,10 +1265,7 @@ static int vidioc_enum_fmt_vid_overlay(struct
> file
> > *file, void *fh,
> >  			struct v4l2_fmtdesc *fmt)
> >  {
> >  	int index = fmt->index;
> > -	enum v4l2_buf_type type = fmt->type;
> >
> > -	fmt->index = index;
> > -	fmt->type = type;
> >  	if (index >= NUM_OUTPUT_FORMATS)
> >  		return -EINVAL;
> >
> > --
> > 1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Scheurer, Amber July 6, 2011, 3:03 a.m. UTC | #3 
> -----Original Message-----
> From: Hiremath, Vaibhav
> Sent: Wednesday, July 06, 2011 12:38 AM
> To: JAIN, AMBER; linux-media@vger.kernel.org
> Cc: Semwal, Sumit; Nilofer, Samreen
> Subject: RE: [PATCH 6/6] V4l2: OMAP: VOUT: Minor Cleanup, removing the
> unnecessary code.
> 
> 
> > -----Original Message-----
> > From: JAIN, AMBER
> > Sent: Tuesday, June 07, 2011 8:18 PM
> > To: linux-media@vger.kernel.org
> > Cc: Hiremath, Vaibhav; Semwal, Sumit; JAIN, AMBER; Nilofer, Samreen
> > Subject: [PATCH 6/6] V4l2: OMAP: VOUT: Minor Cleanup, removing the
> > unnecessary code.
> >
> > Minor changes to remove the unused code from omap_vout driver.
> >
> > Signed-off-by: Amber Jain <amber@ti.com>
> > Signed-off-by: Samreen <samreen@ti.com>
> > ---
> >  drivers/media/video/omap/omap_vout.c |    6 ------
> >  1 files changed, 0 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/media/video/omap/omap_vout.c
> > b/drivers/media/video/omap/omap_vout.c
> > index 25025a1..4aeea06 100644
> > --- a/drivers/media/video/omap/omap_vout.c
> > +++ b/drivers/media/video/omap/omap_vout.c
> > @@ -1090,10 +1090,7 @@ static int vidioc_enum_fmt_vid_out_mplane(struct
> > file *file, void *fh,
> >  			struct v4l2_fmtdesc *fmt)
> >  {
> >  	int index = fmt->index;
> > -	enum v4l2_buf_type type = fmt->type;
> >
> > -	fmt->index = index;
> > -	fmt->type = type;
> [Hiremath, Vaibhav] These lines are not present in main-line driver? Which
> baseline have you used for this patch?

I checked it again, it is present in mainline. Can you please check 3.0-rc6 branch.

Thanks,
Amber

> 
> Thanks,
> Vaibhav
> 
> >  	if (index >= NUM_OUTPUT_FORMATS)
> >  		return -EINVAL;
> >
> > @@ -1268,10 +1265,7 @@ static int vidioc_enum_fmt_vid_overlay(struct
> file
> > *file, void *fh,
> >  			struct v4l2_fmtdesc *fmt)
> >  {
> >  	int index = fmt->index;
> > -	enum v4l2_buf_type type = fmt->type;
> >
> > -	fmt->index = index;
> > -	fmt->type = type;
> >  	if (index >= NUM_OUTPUT_FORMATS)
> >  		return -EINVAL;
> >
> > --
> > 1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/media/video/omap/omap_vout.c b/drivers/media/video/omap/omap_vout.c
index 25025a1..4aeea06 100644
--- a/drivers/media/video/omap/omap_vout.c
+++ b/drivers/media/video/omap/omap_vout.c
@@ -1090,10 +1090,7 @@  static int vidioc_enum_fmt_vid_out_mplane(struct file *file, void *fh,
 			struct v4l2_fmtdesc *fmt)
 {
 	int index = fmt->index;
-	enum v4l2_buf_type type = fmt->type;
 
-	fmt->index = index;
-	fmt->type = type;
 	if (index >= NUM_OUTPUT_FORMATS)
 		return -EINVAL;
 
@@ -1268,10 +1265,7 @@  static int vidioc_enum_fmt_vid_overlay(struct file *file, void *fh,
 			struct v4l2_fmtdesc *fmt)
 {
 	int index = fmt->index;
-	enum v4l2_buf_type type = fmt->type;
 
-	fmt->index = index;
-	fmt->type = type;
 	if (index >= NUM_OUTPUT_FORMATS)
 		return -EINVAL;