| Message ID | 1308251216-8194-1-git-send-email-jslaby@suse.cz (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Thu, 16 Jun 2011 21:06:56 +0200 Jiri Slaby wrote: > Telling the user they can disable an option if they want is not the > much useful. Describe what it is good for instead. > > The text was derived from Mauro's email. > > Signed-off-by: Jiri Slaby <jslaby@suse.cz> > Cc: Mauro Carvalho Chehab <mchehab@redhat.com> > Cc: Hans Petter Selasky <hselasky@c2i.net> Yes, much better. Thanks. Acked-by: Randy Dunlap <randy.dunlap@oracle.com> > --- > drivers/media/Kconfig | 10 ++++++---- > 1 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig > index dc61895..279e2b9 100644 > --- a/drivers/media/Kconfig > +++ b/drivers/media/Kconfig > @@ -89,11 +89,13 @@ config DVB_NET > default (NET && INET) > depends on NET && INET > help > - The DVB network support in the DVB core can > - optionally be disabled if this > - option is set to N. > + This option enables DVB Network Support which is a part of the DVB > + standard. It is used, for example, by automatic firmware updates used > + on Set-Top-Boxes. It can also be used to access the Internet via the > + DVB card, if the network provider supports it. > > - If unsure say Y. > + You may want to disable the network support on embedded devices. If > + unsure say Y. > > config VIDEO_MEDIA > tristate > -- > 1.7.5.4 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thursday 16 June 2011 21:06:56 Jiri Slaby wrote: > Telling the user they can disable an option if they want is not the > much useful. Describe what it is good for instead. > > The text was derived from Mauro's email. Acked-by: Hans Petter Selasky <hselasky@c2i.net> PS: Don't forget the other patch to add a dependency to DVB_CORE. --HPS -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 06/17/2011 08:04 AM, Hans Petter Selasky wrote:
> PS: Don't forget the other patch to add a dependency to DVB_CORE.
Sorry, I'm not your fixing monkey. Fix your bugs on your own.
thanks,
On Friday 17 June 2011 10:02:21 Jiri Slaby wrote: > On 06/17/2011 08:04 AM, Hans Petter Selasky wrote: > > PS: Don't forget the other patch to add a dependency to DVB_CORE. > > Sorry, I'm not your fixing monkey. Fix your bugs on your own. The PS was intended for Mauro. Sorry if you confused that. --HPS -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig index dc61895..279e2b9 100644 --- a/drivers/media/Kconfig +++ b/drivers/media/Kconfig @@ -89,11 +89,13 @@ config DVB_NET default (NET && INET) depends on NET && INET help - The DVB network support in the DVB core can - optionally be disabled if this - option is set to N. + This option enables DVB Network Support which is a part of the DVB + standard. It is used, for example, by automatic firmware updates used + on Set-Top-Boxes. It can also be used to access the Internet via the + DVB card, if the network provider supports it. - If unsure say Y. + You may want to disable the network support on embedded devices. If + unsure say Y. config VIDEO_MEDIA tristate
Telling the user they can disable an option if they want is not the much useful. Describe what it is good for instead. The text was derived from Mauro's email. Signed-off-by: Jiri Slaby <jslaby@suse.cz> Cc: Mauro Carvalho Chehab <mchehab@redhat.com> Cc: Hans Petter Selasky <hselasky@c2i.net> --- drivers/media/Kconfig | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-)