diff mbox

PCTV 290e nanostick and remote control support

Message ID 1313286189.94904.YahooMailClassic@web121720.mail.ne1.yahoo.com (mailing list archive)
State Superseded
Headers show

Commit Message

Chris Rankin Aug. 14, 2011, 1:43 a.m. UTC 
Hi,

The rc-pinnacle-pctv-hd keymap is missing the definition of the OK key:


Cheers,
Chris

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Devin Heitmueller Aug. 14, 2011, 1:48 a.m. UTC | #1 
On Sat, Aug 13, 2011 at 9:43 PM, Chris Rankin <rankincj@yahoo.com> wrote:
> Hi,
>
> The rc-pinnacle-pctv-hd keymap is missing the definition of the OK key:
>
> --- linux-3.0/drivers/media/rc/keymaps/rc-pinnacle-pctv-hd.c.orig       2011-08-14 02:42:01.000000000 +0100
> +++ linux-3.0/drivers/media/rc/keymaps/rc-pinnacle-pctv-hd.c    2011-08-14 02:12:45.000000000 +0100
> @@ -20,6 +20,7 @@
>        { 0x0701, KEY_MENU }, /* Pinnacle logo */
>        { 0x0739, KEY_POWER },
>        { 0x0703, KEY_VOLUMEUP },
> +       { 0x0705, KEY_OK },
>        { 0x0709, KEY_VOLUMEDOWN },
>        { 0x0706, KEY_CHANNELUP },
>        { 0x070c, KEY_CHANNELDOWN },
>
> Cheers,
> Chris

Wow, how the hell did I miss that?  I did numerous remotes for em28xx
based devices that use that RC profile, and never noticed that issue.

Will have to check the merge logs.  Maybe the key got lost when they
refactored the IR support.

Chris, you should add a signed-off-by tag and submit this as a patch
so it can be included upstream.

Devin
Antti Palosaari Aug. 14, 2011, 12:11 p.m. UTC | #2 
On 08/14/2011 04:48 AM, Devin Heitmueller wrote:
> On Sat, Aug 13, 2011 at 9:43 PM, Chris Rankin <rankincj@yahoo.com> wrote:
>> The rc-pinnacle-pctv-hd keymap is missing the definition of the OK key:
>>
>> --- linux-3.0/drivers/media/rc/keymaps/rc-pinnacle-pctv-hd.c.orig       2011-08-14 02:42:01.000000000 +0100
>> +++ linux-3.0/drivers/media/rc/keymaps/rc-pinnacle-pctv-hd.c    2011-08-14 02:12:45.000000000 +0100
>> @@ -20,6 +20,7 @@
>>        { 0x0701, KEY_MENU }, /* Pinnacle logo */
>>        { 0x0739, KEY_POWER },
>>        { 0x0703, KEY_VOLUMEUP },
>> +       { 0x0705, KEY_OK },
>>        { 0x0709, KEY_VOLUMEDOWN },
>>        { 0x0706, KEY_CHANNELUP },
>>        { 0x070c, KEY_CHANNELDOWN },
>>
>> Cheers,
>> Chris
> 
> Wow, how the hell did I miss that?  I did numerous remotes for em28xx
> based devices that use that RC profile, and never noticed that issue.
> 
> Will have to check the merge logs.  Maybe the key got lost when they
> refactored the IR support.

It seems to be very old bug, year 2007, not coming from merge errors! It
could be even possible there have not been such button originally. Very
weird situation none have found it earlier. For example I just pressed
few buttons to see number are coming to console => OK it works (didn't
looked all buttons sends events).

That's commit which adds those keytables:
commit 54d75ebaa02809f24a16624e32706af3bf97588e

regards
Antti
diff mbox

Patch

--- linux-3.0/drivers/media/rc/keymaps/rc-pinnacle-pctv-hd.c.orig	2011-08-14 02:42:01.000000000 +0100
+++ linux-3.0/drivers/media/rc/keymaps/rc-pinnacle-pctv-hd.c	2011-08-14 02:12:45.000000000 +0100
@@ -20,6 +20,7 @@ 
 	{ 0x0701, KEY_MENU }, /* Pinnacle logo */
 	{ 0x0739, KEY_POWER },
 	{ 0x0703, KEY_VOLUMEUP },
+	{ 0x0705, KEY_OK },
 	{ 0x0709, KEY_VOLUMEDOWN },
 	{ 0x0706, KEY_CHANNELUP },
 	{ 0x070c, KEY_CHANNELDOWN },