diff mbox

[1/3] fc2580: define const as UL to silence a warning

Message ID 1348486638-31169-2-git-send-email-gennarone@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Gianluca Gennari Sept. 24, 2012, 11:37 a.m. UTC 
fc2580.c: In function 'fc2580_set_params':
fc2580.c:150: warning: this decimal constant is unsigned only in ISO C90

Signed-off-by: Gianluca Gennari <gennarone@gmail.com>
---
 drivers/media/tuners/fc2580.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Antti Palosaari Sept. 24, 2012, 11:52 a.m. UTC | #1 
On 09/24/2012 02:37 PM, Gianluca Gennari wrote:
> fc2580.c: In function 'fc2580_set_params':
> fc2580.c:150: warning: this decimal constant is unsigned only in ISO C90
>
> Signed-off-by: Gianluca Gennari <gennarone@gmail.com>

Acked-by: Antti Palosaari <crope@iki.fi>
Reviewed-by: Antti Palosaari <crope@iki.fi>


> ---
>   drivers/media/tuners/fc2580.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/tuners/fc2580.c b/drivers/media/tuners/fc2580.c
> index afc0491..036e94b 100644
> --- a/drivers/media/tuners/fc2580.c
> +++ b/drivers/media/tuners/fc2580.c
> @@ -147,7 +147,7 @@ static int fc2580_set_params(struct dvb_frontend *fe)
>   	f_vco = c->frequency;
>   	f_vco *= fc2580_pll_lut[i].div;
>
> -	if (f_vco >= 2600000000)
> +	if (f_vco >= 2600000000UL)
>   		tmp_val = 0x0e | fc2580_pll_lut[i].band;
>   	else
>   		tmp_val = 0x06 | fc2580_pll_lut[i].band;
>
diff mbox

Patch

diff --git a/drivers/media/tuners/fc2580.c b/drivers/media/tuners/fc2580.c
index afc0491..036e94b 100644
--- a/drivers/media/tuners/fc2580.c
+++ b/drivers/media/tuners/fc2580.c
@@ -147,7 +147,7 @@  static int fc2580_set_params(struct dvb_frontend *fe)
 	f_vco = c->frequency;
 	f_vco *= fc2580_pll_lut[i].div;
 
-	if (f_vco >= 2600000000)
+	if (f_vco >= 2600000000UL)
 		tmp_val = 0x0e | fc2580_pll_lut[i].band;
 	else
 		tmp_val = 0x06 | fc2580_pll_lut[i].band;