From patchwork Tue Sep 25 06:09:05 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lad, Prabhakar" X-Patchwork-Id: 1501941 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id A060ADF28C for ; Tue, 25 Sep 2012 06:09:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753044Ab2IYGJX (ORCPT ); Tue, 25 Sep 2012 02:09:23 -0400 Received: from mail-da0-f46.google.com ([209.85.210.46]:53906 "EHLO mail-da0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751097Ab2IYGJV (ORCPT ); Tue, 25 Sep 2012 02:09:21 -0400 Received: by dady13 with SMTP id y13so269011dad.19 for ; Mon, 24 Sep 2012 23:09:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=3Ke5buBqilE6too7A9zaCPLOsbe9lGTSwGfJLDgQdH0=; b=hojUWJQ3bcC288RYjx3Qs6oDwUQLplsK4JGon1NrSktMf/ix+BHHL1AbPTUEILHH+a OgjqV3TL7vORpTqJ7XWwKM7R/M0pOGHTgcX+z7UvIXGZDW7a5Gm3742vSfeI6Z0ZdF08 N2HPp/Gf4kntgEfrryh+N+17VPKBZFf3CZ6r7aQzpaS67QIo7glqBb3WBrPl5ZMxvWAQ pDmJQ4/haghkoHQPxV1lpuKCTD2eYqshWStiXjUHMCzPGY2OUBS3y/+tbds+Z9J2MBzA H7jOt9TxO0xZwVd7pX4SKBqe1+S556Hf2ofH0jYzfeOrd2MtE0FeHnqwRky46S5PWZsC naJA== Received: by 10.66.79.195 with SMTP id l3mr38116913pax.33.1348553360862; Mon, 24 Sep 2012 23:09:20 -0700 (PDT) Received: from localhost.localdomain ([122.166.13.141]) by mx.google.com with ESMTPS id j9sm9966098pav.15.2012.09.24.23.09.15 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 24 Sep 2012 23:09:19 -0700 (PDT) From: Prabhakar To: LMML Cc: DLOS , LDOC , Mauro Carvalho Chehab , VGER , Sakari Ailus , Manjunath Hadli , Prabhakar Lad , Hans Verkuil , Laurent Pinchart , Sylwester Nawrocki , Hans de Goede , Kyungmin Park , Rob Landley Subject: [PATCH v4] media: v4l2-ctrls: add control for test pattern Date: Tue, 25 Sep 2012 11:39:05 +0530 Message-Id: <1348553345-14296-1-git-send-email-prabhakar.lad@ti.com> X-Mailer: git-send-email 1.7.4.1 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Lad, Prabhakar add V4L2_CID_TEST_PATTERN of type menu, which determines the internal test pattern selected by the device. Signed-off-by: Lad, Prabhakar Signed-off-by: Manjunath Hadli Acked-by: Sakari Ailus Cc: Hans Verkuil Cc: Laurent Pinchart Cc: Mauro Carvalho Chehab Cc: Sylwester Nawrocki Cc: Hans de Goede Cc: Kyungmin Park Cc: Rob Landley Acked-by: Hans Verkuil Acked-by: Sakari Ailus --- This patches has one checkpatch warning for line over 80 characters altough it can be avoided I have kept it for consistency. Changes for v4: 1: Fixed some grammar/style issues, pointed by Hans. Changes for v3: 1: Removed the menu for test pattern, pointed by Sakari. Changes for v2: 1: Included display devices in the description for test pattern as pointed by Hans. 2: In the menu replaced 'Test Pattern Disabled' by 'Disabled' as pointed by Sylwester. 3: Removed the test patterns from menu as the are hardware specific as pointed by Sakari. Documentation/DocBook/media/v4l/controls.xml | 10 ++++++++++ drivers/media/v4l2-core/v4l2-ctrls.c | 2 ++ include/linux/videodev2.h | 1 + 3 files changed, 13 insertions(+), 0 deletions(-) diff --git a/Documentation/DocBook/media/v4l/controls.xml b/Documentation/DocBook/media/v4l/controls.xml index f0fb08d..5450d31 100644 --- a/Documentation/DocBook/media/v4l/controls.xml +++ b/Documentation/DocBook/media/v4l/controls.xml @@ -4313,6 +4313,16 @@ interface and may change in the future. + + V4L2_CID_TEST_PATTERN + menu + + + Some capture/display/sensor devices have + the capability to generate test pattern images. These hardware + specific test patterns can be used to test if a device is working + properly. + diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c index 8f2f40b..41b7732 100644 --- a/drivers/media/v4l2-core/v4l2-ctrls.c +++ b/drivers/media/v4l2-core/v4l2-ctrls.c @@ -740,6 +740,7 @@ const char *v4l2_ctrl_get_name(u32 id) case V4L2_CID_LINK_FREQ: return "Link Frequency"; case V4L2_CID_PIXEL_RATE: return "Pixel Rate"; case V4L2_CID_DPCM_PREDICTOR: return "DPCM Predictor"; + case V4L2_CID_TEST_PATTERN: return "Test Pattern"; default: return NULL; @@ -841,6 +842,7 @@ void v4l2_ctrl_fill(u32 id, const char **name, enum v4l2_ctrl_type *type, case V4L2_CID_EXPOSURE_METERING: case V4L2_CID_SCENE_MODE: case V4L2_CID_DPCM_PREDICTOR: + case V4L2_CID_TEST_PATTERN: *type = V4L2_CTRL_TYPE_MENU; break; case V4L2_CID_LINK_FREQ: diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h index ca9fb78..7014c0b 100644 --- a/include/linux/videodev2.h +++ b/include/linux/videodev2.h @@ -2005,6 +2005,7 @@ enum v4l2_dpcm_predictor { V4L2_DPCM_PREDICTOR_SIMPLE = 0, V4L2_DPCM_PREDICTOR_ADVANCED = 1, }; +#define V4L2_CID_TEST_PATTERN (V4L2_CID_IMAGE_PROC_CLASS_BASE + 4) /* * T U N I N G