From patchwork Tue Oct 23 19:57:26 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ezequiel Garcia X-Patchwork-Id: 1632441 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 9829C3FE1C for ; Tue, 23 Oct 2012 20:00:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933514Ab2JWT7g (ORCPT ); Tue, 23 Oct 2012 15:59:36 -0400 Received: from mail-gh0-f174.google.com ([209.85.160.174]:62157 "EHLO mail-gh0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933486Ab2JWT7d (ORCPT ); Tue, 23 Oct 2012 15:59:33 -0400 Received: by mail-gh0-f174.google.com with SMTP id g15so834680ghb.19 for ; Tue, 23 Oct 2012 12:59:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=Qs9Ut3/+0bcnphbmUktQdMSOVBygIem4vioucKtpyBk=; b=RQUunR4D/NXYY8NP/S0WPLZXrV3RwzbIERGbZD0eI8FYXEjAg1ae/mInk2see0lAyr OrXNuzGZfgM/+HPoR4nHxs8ygQ53PbWEzTi7Jz3kUSR+cPAG7NejYPCJhZjUT/MbJMAV X76HzkKtfmq8q6L0/z+/Bn3NR8WlpOxRmVgvmEflYpSd5ZxFbDscR6gx5rg/sN5dAnNN TJB6M9p8O+VUVPNV4DSUNzYumQfyqB47TTxHJTPXkKRQ4eiZwtMZlLNQD52x9OMDUBe1 A5ogilRU/x9fCTVbJDByFOk3C5grmqhInsv6uRb+9QeWB3eDkkEOtAJ3bm6uwWXQrBFG Jmqw== Received: by 10.236.77.229 with SMTP id d65mr12594836yhe.124.1351022373287; Tue, 23 Oct 2012 12:59:33 -0700 (PDT) Received: from localhost.localdomain ([186.153.120.250]) by mx.google.com with ESMTPS id k63sm12813347yhj.20.2012.10.23.12.59.31 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 23 Oct 2012 12:59:32 -0700 (PDT) From: Ezequiel Garcia To: , Cc: Julia.Lawall@lip6.fr, kernel-janitors@vger.kernel.org, Ezequiel Garcia , Peter Senna Tschudin Subject: [PATCH 23/23] wl128x: Replace memcpy with struct assignment Date: Tue, 23 Oct 2012 16:57:26 -0300 Message-Id: <1351022246-8201-23-git-send-email-elezegarcia@gmail.com> X-Mailer: git-send-email 1.7.4.4 In-Reply-To: <1351022246-8201-1-git-send-email-elezegarcia@gmail.com> References: <1351022246-8201-1-git-send-email-elezegarcia@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org This kind of memcpy() is error-prone. Its replacement with a struct assignment is prefered because it's type-safe and much easier to read. Found by coccinelle. Hand patched and reviewed. Tested by compilation only. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // Signed-off-by: Peter Senna Tschudin Signed-off-by: Ezequiel Garcia --- drivers/media/radio/wl128x/fmdrv_common.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/media/radio/wl128x/fmdrv_common.c b/drivers/media/radio/wl128x/fmdrv_common.c index bf867a6..902f19d 100644 --- a/drivers/media/radio/wl128x/fmdrv_common.c +++ b/drivers/media/radio/wl128x/fmdrv_common.c @@ -1563,8 +1563,7 @@ int fmc_prepare(struct fmdev *fmdev) fmdev->irq_info.mask = FM_MAL_EVENT; /* Region info */ - memcpy(&fmdev->rx.region, ®ion_configs[default_radio_region], - sizeof(struct region_info)); + fmdev->rx.region = region_configs[default_radio_region]; fmdev->rx.mute_mode = FM_MUTE_OFF; fmdev->rx.rf_depend_mute = FM_RX_RF_DEPENDENT_MUTE_OFF;