| Message ID | 1357505952-14439-1-git-send-email-emilgoode@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Emil, You are right, there was a missing piece of code. During merge, part of the orignal patch was missing. I have signaled it to Mauro who have fixed it in media_tree. Regards. Le 06/01/2013 21:59, Emil Goode a écrit : > The function demod_attach_drxd was split into two by commit 36a495a3. > This resulted in a new function tuner_attach_dtt7520x that is not used. > We should register tuner_attach_dtt7520x as a callback in the ngene_info > struct in the same way as done with the other part of the split function. > > Sparse warning: > > drivers/media/pci/ngene/ngene-cards.c:333:12: warning: > ‘tuner_attach_dtt7520x’ defined but not used [-Wunused-function] > > Signed-off-by: Emil Goode <emilgoode@gmail.com> > --- > This patch is a guess at what was intended. I'm not familiar with this code > and I don't have the hardware to test it. > > drivers/media/pci/ngene/ngene-cards.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/pci/ngene/ngene-cards.c b/drivers/media/pci/ngene/ngene-cards.c > index c99f779..60605c8 100644 > --- a/drivers/media/pci/ngene/ngene-cards.c > +++ b/drivers/media/pci/ngene/ngene-cards.c > @@ -732,6 +732,7 @@ static struct ngene_info ngene_info_terratec = { > .name = "Terratec Integra/Cinergy2400i Dual DVB-T", > .io_type = {NGENE_IO_TSIN, NGENE_IO_TSIN}, > .demod_attach = {demod_attach_drxd, demod_attach_drxd}, > + .tuner_attach = {tuner_attach_dtt7520x, tuner_attach_dtt7520x}, > .fe_config = {&fe_terratec_dvbt_0, &fe_terratec_dvbt_1}, > .i2c_access = 1, > }; > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/pci/ngene/ngene-cards.c b/drivers/media/pci/ngene/ngene-cards.c index c99f779..60605c8 100644 --- a/drivers/media/pci/ngene/ngene-cards.c +++ b/drivers/media/pci/ngene/ngene-cards.c @@ -732,6 +732,7 @@ static struct ngene_info ngene_info_terratec = { .name = "Terratec Integra/Cinergy2400i Dual DVB-T", .io_type = {NGENE_IO_TSIN, NGENE_IO_TSIN}, .demod_attach = {demod_attach_drxd, demod_attach_drxd}, + .tuner_attach = {tuner_attach_dtt7520x, tuner_attach_dtt7520x}, .fe_config = {&fe_terratec_dvbt_0, &fe_terratec_dvbt_1}, .i2c_access = 1, };
The function demod_attach_drxd was split into two by commit 36a495a3. This resulted in a new function tuner_attach_dtt7520x that is not used. We should register tuner_attach_dtt7520x as a callback in the ngene_info struct in the same way as done with the other part of the split function. Sparse warning: drivers/media/pci/ngene/ngene-cards.c:333:12: warning: ‘tuner_attach_dtt7520x’ defined but not used [-Wunused-function] Signed-off-by: Emil Goode <emilgoode@gmail.com> --- This patch is a guess at what was intended. I'm not familiar with this code and I don't have the hardware to test it. drivers/media/pci/ngene/ngene-cards.c | 1 + 1 file changed, 1 insertion(+)