diff mbox

[1/3,media] Add header file defining standard image sizes

Message ID 1358630842-12689-2-git-send-email-sylvester.nawrocki@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Sylwester Nawrocki Jan. 19, 2013, 9:27 p.m. UTC
Add common header file defining standard image sizes, so we can
avoid redefining those in each driver.

Signed-off-by: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
---
 include/media/image-sizes.h |   34 ++++++++++++++++++++++++++++++++++
 1 files changed, 34 insertions(+), 0 deletions(-)
 create mode 100644 include/media/image-sizes.h

Comments

Hans Verkuil Jan. 21, 2013, 9:01 a.m. UTC | #1
On Sat January 19 2013 22:27:20 Sylwester Nawrocki wrote:
> Add common header file defining standard image sizes, so we can
> avoid redefining those in each driver.
> 
> Signed-off-by: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
> ---
>  include/media/image-sizes.h |   34 ++++++++++++++++++++++++++++++++++

Since this is a v4l2 core header it should be renamed with a 'v4l2-' prefix.

Regards,

	Hans

>  1 files changed, 34 insertions(+), 0 deletions(-)
>  create mode 100644 include/media/image-sizes.h
> 
> diff --git a/include/media/image-sizes.h b/include/media/image-sizes.h
> new file mode 100644
> index 0000000..10daf92
> --- /dev/null
> +++ b/include/media/image-sizes.h
> @@ -0,0 +1,34 @@
> +/*
> + * Standard image size definitions
> + *
> + * Copyright (C) 2013, Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +#ifndef _IMAGE_SIZES_H
> +#define _IMAGE_SIZES_H
> +
> +#define CIF_WIDTH	352
> +#define CIF_HEIGHT	288
> +
> +#define QCIF_WIDTH	176
> +#define QCIF_HEIGHT	144
> +
> +#define QQCIF_WIDTH	88
> +#define QQCIF_HEIGHT	72
> +
> +#define QQVGA_WIDTH	160
> +#define QQVGA_HEIGHT	120
> +
> +#define QVGA_WIDTH	320
> +#define QVGA_HEIGHT	240
> +
> +#define SXGA_WIDTH	1280
> +#define SXGA_HEIGHT	1024
> +
> +#define VGA_WIDTH	640
> +#define VGA_HEIGHT	480
> +
> +#endif /* _IMAGE_SIZES_H */
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sylwester Nawrocki Jan. 22, 2013, 9:42 p.m. UTC | #2
On 01/21/2013 10:01 AM, Hans Verkuil wrote:
> On Sat January 19 2013 22:27:20 Sylwester Nawrocki wrote:
>> Add common header file defining standard image sizes, so we can
>> avoid redefining those in each driver.
>>
>> Signed-off-by: Sylwester Nawrocki<sylvester.nawrocki@gmail.com>
>> ---
>>   include/media/image-sizes.h |   34 ++++++++++++++++++++++++++++++++++
>
> Since this is a v4l2 core header it should be renamed with a 'v4l2-' prefix.

OK, I'll rename it. I just thought these definitions could be used outside
v4l2 and didn't prefix it with v4l2- originally.

--

Regards,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/include/media/image-sizes.h b/include/media/image-sizes.h
new file mode 100644
index 0000000..10daf92
--- /dev/null
+++ b/include/media/image-sizes.h
@@ -0,0 +1,34 @@ 
+/*
+ * Standard image size definitions
+ *
+ * Copyright (C) 2013, Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+#ifndef _IMAGE_SIZES_H
+#define _IMAGE_SIZES_H
+
+#define CIF_WIDTH	352
+#define CIF_HEIGHT	288
+
+#define QCIF_WIDTH	176
+#define QCIF_HEIGHT	144
+
+#define QQCIF_WIDTH	88
+#define QQCIF_HEIGHT	72
+
+#define QQVGA_WIDTH	160
+#define QQVGA_HEIGHT	120
+
+#define QVGA_WIDTH	320
+#define QVGA_HEIGHT	240
+
+#define SXGA_WIDTH	1280
+#define SXGA_HEIGHT	1024
+
+#define VGA_WIDTH	640
+#define VGA_HEIGHT	480
+
+#endif /* _IMAGE_SIZES_H */