exynos4-is: Correct clock properties description at the DT binding documentation

Commit Message

Sylwester Nawrocki/Kernel \(PLT\) /SRPOL/Staff Engineer/Samsung Electronics April 2, 2013, 1:32 p.m. UTC

The 'camera' DT node needs to have sclk_cam0/1 and pxl_async0/1 clocks
specified, while 'fimc' nodes should have only "fimc" and "sclk_fimc".
"mux" and "parent" are leftovers from early versions of patches adding
DT support, when the IP bus clock parent clock was being set by the
driver. A better solution is needed to have e.g. clocks driver setting
all required parent clocks, before clock consumers start using the
clocks. Currently this binding doesn't describe the parent clocks setup,
it needs to be specified and handled somewhere else.

Signed-off-by: Sylwester Nawrocki <[e-mail]>
Signed-off-by: Kyungmin Park <[e-mail]>
---
 .../devicetree/bindings/media/samsung-fimc.txt     |   10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

--
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/Documentation/devicetree/bindings/media/samsung-fimc.txt b/Documentation/devicetree/bindings/media/samsung-fimc.txt
index 2a63ddd..51c776b 100644
--- a/Documentation/devicetree/bindings/media/samsung-fimc.txt
+++ b/Documentation/devicetree/bindings/media/samsung-fimc.txt
@@ -17,9 +17,9 @@  Required properties:

 - compatible	: must be "samsung,fimc", "simple-bus"
 - clocks	: list of clock specifiers, corresponding to entries in
-		  clock-names property;
-- clock-names	: must contain "fimc", "sclk_fimc" entries, matching entries
-		  in the clocks property.
+		  the clock-names property;
+- clock-names	: must contain "sclk_cam0", "sclk_cam1", "pxl_async0",
+		  "pxl_async1" entries, matching entries in the clocks property.

 The pinctrl bindings defined in ../pinctrl/pinctrl-bindings.txt must be used
 to define a required pinctrl state named "default" and optional pinctrl states:
@@ -32,7 +32,6 @@  way around.

 The 'camera' node must include at least one 'fimc' child node.

-
 'fimc' device nodes
 -------------------

@@ -44,8 +43,7 @@  Required properties:
 - interrupts: should contain FIMC interrupt;
 - clocks: list of clock specifiers, must contain an entry for each required
   entry in clock-names;
-- clock-names: must include "fimc", "sclk_fimc", "mux" entries and optionally
-  "parent" entry.
+- clock-names: must contain "fimc", "sclk_fimc" entries.
 - samsung,pix-limits: an array of maximum supported image sizes in pixels, for
   details refer to Table 2-1 in the S5PV210 SoC User Manual; The meaning of
   each cell is as follows: