From patchwork Mon Apr 29 09:24:58 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 2499091 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id A07793FD1A for ; Mon, 29 Apr 2013 09:37:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756870Ab3D2Jhu (ORCPT ); Mon, 29 Apr 2013 05:37:50 -0400 Received: from mail-pb0-f42.google.com ([209.85.160.42]:46827 "EHLO mail-pb0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755678Ab3D2Jht (ORCPT ); Mon, 29 Apr 2013 05:37:49 -0400 Received: by mail-pb0-f42.google.com with SMTP id up15so414195pbc.1 for ; Mon, 29 Apr 2013 02:37:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:x-gm-message-state; bh=+hq0xdjdxfPBHjcBLs/LAmjdo8og/8DiXut2p8oyZHk=; b=flmDE3n6wFnl1nL/w91pTLF6cmK3IBLpo6S6/zLkt2BwxNZP+sHPA3qGEPu6ZCcxMZ Ykl/gh/wthdP6IF11wklbcw8udMg+kXQV92HiZr+34gEC8FonYI1M/0MA5FA5RN+OKYn KsmcPUbtWhK74+SEU22d+1fzigSibPdRl4S2NcZWZriXq0iddgZgkJnnZod1BxLg3Ohr Z4TT/K5mkpZSaRlzD/81j+KIiEaKYBxkvSr7U66ZaiqHGK9cCypkBGS5O0v0HLdZ2d1G xTQMgGDSI2IcwEGqYFzpQ3Z5OopLn93VeQ6QM6+0tW+MFtYKuMFtQUK95fZXHx0fWmWO RHUg== X-Received: by 10.66.174.143 with SMTP id bs15mr41814869pac.17.1367228269421; Mon, 29 Apr 2013 02:37:49 -0700 (PDT) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id br2sm23328203pbc.46.2013.04.29.02.37.46 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 29 Apr 2013 02:37:48 -0700 (PDT) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: t.stanislaws@samsung.com, s.nawrocki@samsung.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 2/3] [media] s5p-tv: Fix incorrect usage of IS_ERR_OR_NULL in mixer_drv.c Date: Mon, 29 Apr 2013 14:54:58 +0530 Message-Id: <1367227499-543-2-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1367227499-543-1-git-send-email-sachin.kamat@linaro.org> References: <1367227499-543-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQnIjW6BCr7lFpu4Ta7vi+xbwt5zmRiUAsEkEzl0eekrAvdYdJIuAsnUKD6iQgi+zd8vvmQa Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org NULL check on clocks obtained using common clock APIs should not be done. Use IS_ERR only. Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-tv/mixer_drv.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/s5p-tv/mixer_drv.c b/drivers/media/platform/s5p-tv/mixer_drv.c index 5733033..8dd8b88 100644 --- a/drivers/media/platform/s5p-tv/mixer_drv.c +++ b/drivers/media/platform/s5p-tv/mixer_drv.c @@ -222,15 +222,15 @@ static void mxr_release_clocks(struct mxr_device *mdev) { struct mxr_resources *res = &mdev->res; - if (!IS_ERR_OR_NULL(res->sclk_dac)) + if (!IS_ERR(res->sclk_dac)) clk_put(res->sclk_dac); - if (!IS_ERR_OR_NULL(res->sclk_hdmi)) + if (!IS_ERR(res->sclk_hdmi)) clk_put(res->sclk_hdmi); - if (!IS_ERR_OR_NULL(res->sclk_mixer)) + if (!IS_ERR(res->sclk_mixer)) clk_put(res->sclk_mixer); - if (!IS_ERR_OR_NULL(res->vp)) + if (!IS_ERR(res->vp)) clk_put(res->vp); - if (!IS_ERR_OR_NULL(res->mixer)) + if (!IS_ERR(res->mixer)) clk_put(res->mixer); }